pxa: Fix typo in GCDR(x)
PATCH 1/1 pxa: Fix typo in GCDR(x)
Fix a typo in the GCDR(x) macro. It's a good thing no one was using it.
--- include/asm-arm/arch-pxa/pxa-regs.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
include/asm-arm/arch-pxa/pxa-regs.h +1 -1
@@ -1217,7 +1217,7 @@ typedef void (*ExcpHndlr) (void) ;#define GCFER3 __REG(0x40E004AC)/* Clr Falling Edge Det. Enable[127:96] */ #define GSDR (x) __REG2(0x40E00400, ((x) & 0x60) >> 3) -#define GCDR (x) __REG2(0x40300420, ((x) & 0x60) >> 3) +#define GCDR (x) __REG2(0x40E00420, ((x) & 0x60) >> 3)/* Multi-funktion Pin Registers, uncomplete, only: * - GPIO
Signature · 1 line
1.6.0.3
PATCH 1/1 pxa: Fix typo in GCDR(x)
Quoted 7 lines · David Hunter
Fix a typo in the GCDR(x) macro. It's a good thing no one was using it.
Signed-off-by David Hunter <[email protected]>--- include/asm-arm/arch-pxa/pxa-regs.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
applied to u-boot-arm
Best Regards,
J.
PATCH 1/1 pxa: Fix typo in GCDR(x)
Quoted 1 line · Jean-Christophe PLAGNIOL-VILLARD
applied to u-boot-arm
That raises a question. I'm porting U-Boot to our Marvell PXA310-based hardware. (I'm very new to contributing to an open source project using git, so I apologize in advance for the mistakes I'll make out of ignorance.) I have a few patches queued which will attempt to clean up and improve PXA300/310/320 support -- register definitions for now, but later driver stuff as I dive into Ethernet, etc.. Which branch should I be basing my work on: u-boot, -arm, or -pxa?
-Dave
PATCH 1/1 pxa: Fix typo in GCDR(x)
Quoted 5 lines · David Hunter
Quoted 1 line · Jean-Christophe PLAGNIOL-VILLARD
applied to u-boot-arm
Quoted 7 lines
That raises a question. I'm porting U-Boot to our Marvell PXA310-based hardware. (I'm very new to contributing to an open source project using git, so I apologize in advance for the mistakes I'll make out of ignorance.) I have a few patches queued which will attempt to clean up and improve PXA300/310/320 support -- register definitions for now, but later driver stuff as I dive into Ethernet, etc.. Which branch should I be basing my work on: u-boot, -arm, or -pxa?
-arm
depenanding on the quantity of new code we may create a next branch
Best Regards,
J.
PATCH 1/1 pxa: Fix typo in GCDR(x)
In reply to David HunterDear David Hunter,
Quoted 5 lines · In message <[email protected]> you…
That raises a question. I'm porting U-Boot to our Marvell PXA310-based hardware. (I'm very new to contributing to an open source project using git, so I apologize in advance for the mistakes I'll make out of ignorance.) I have a few patches queued which will attempt to clean up
Please see http://www.denx.de/wiki/U-Boot/Patches for details.
Quoted 3 lines
and improve PXA300/310/320 support -- register definitions for now, but later driver stuff as I dive into Ethernet, etc.. Which branch should I be basing my work on: u-boot, -arm, or -pxa?
Normally please use the "master" branch of the mainline U-Boot git
repository (git://git.denx.de/u-boot.git) as reference, unless
(usually late in a release cycle) there has been an announcement to use the "next" branch of this repository instead.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de In English, every word can be verbed. Would that it were so in our programming languages.