Skip to contentSkip to conversation

Soften up the dmesg on SB600 PMP softreset failure recovery

PATCH Applied Shane Huang 3 participants 3 messages Aug 5, 2009 – Aug 12, 2009 libata

lore
Share & tools
lore

Shane Huang

author
#0 lore raw

PATCH 1/1 Soften up the dmesg on SB600 PMP softreset failure recovery

Too strong words led to spurious bug reports: Novell bugzilla #527748, RedHat bugzilla #468800. This patch is used to soften up the dmesg on SB600 PMP softreset failure recovery, so as to remove the scariness and concern from community.

Reported-by pgnet Dev <[email protected]>
Signed-off-by Shane Huang <[email protected]>
Cc Tejun Heo <[email protected]>
drivers/ata/ahci.c +2 -1
diff -ruN a/drivers/ata/ahci.c b/drivers/ata/ahci.c
@@ -1769,7 +1769,8 @@
 		irq_sts = readl(port_mmio + PORT_IRQ_STAT);
 		if (irq_sts & PORT_IRQ_BAD_PMP) {
 			ata_link_printk(link, KERN_WARNING,
-					"failed due to HW bug, retry pmp=0\n");
+					"applying SB600 PMP SRST workaround "
+					"and retrying\n");
 			rc = ahci_do_softreset(link, class, 0, deadline,
 					       ahci_check_ready);
 		}
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Shane Huang

Too strong words led to spurious bug reports: Novell bugzilla #527748, RedHat bugzilla #468800. This patch is used to soften up the dmesg on SB600 PMP softreset failure recovery, so as to remove the scariness and concern from community.

Reported-by pgnet Dev <[email protected]>
Signed-off-by Shane Huang <[email protected]>
Cc Tejun Heo <[email protected]>
Acked-by Tejun Heo <[email protected]>
Signature · 1 line
tejun
Applied
#2 lore raw
In reply to Shane Huang
Quoted 13 lines · Shane Huang

Too strong words led to spurious bug reports: Novell bugzilla #527748, RedHat bugzilla #468800. This patch is used to soften up the dmesg on SB600 PMP softreset failure recovery, so as to remove the scariness and concern from community.

Reported-by pgnet Dev <[email protected]>
Signed-off-by Shane Huang <[email protected]>
Cc Tejun Heo <[email protected]>

diff -ruN a/drivers/ata/ahci.c b/drivers/ata/ahci.c

drivers/ata/ahci.c line 1775

Quoted 8 lines
drivers/ata/ahci.c +2 -1
@@ -1769,7 +1769,8 @@
 		irq_sts = readl(port_mmio + PORT_IRQ_STAT);
 		if (irq_sts & PORT_IRQ_BAD_PMP) {
 			ata_link_printk(link, KERN_WARNING,
-					"failed due to HW bug, retry pmp=0\n");
+					"applying SB600 PMP SRST workaround "
+					"and retrying\n");
 			rc = ahci_do_softreset(link, class, 0, deadline,
 					       ahci_check_ready);

applied