85xx: Add a 36-bit physical configuration for MPC8536DS
PATCH 1/1 85xx: Add a 36-bit physical configuration for MPC8536DS
We move all IO addressed (CCSR, localbus, PCI) above the 4G boundary to allow for larger memory sizes.
--- Makefile | 8 ++++- include/configs/MPC8536DS.h | 78 +++++++++++++++++++++++++++++++++++++----- 2 files changed, 75 insertions(+), 11 deletions(-)
Makefile +7 -1
@@ -2406,8 +2406,14 @@ vme8349_config: unconfig ATUM8548_config: unconfig @$(MKCONFIG) $(@:_config=) ppc mpc85xx atum8548 +MPC8536DS_36BIT_config \ MPC8536DS_config: unconfig - @$(MKCONFIG) $(@:_config=) ppc mpc85xx mpc8536ds freescale + @mkdir -p $(obj)include + @if [ "$(findstring _36BIT_,$@)" ] ; then \ + echo "#define CONFIG_PHYS_64BIT" >>$(obj)include/config.h ; \ + $(XECHO) "... enabling 36-bit physical addressing." ; \ + fi + @$(MKCONFIG) -a MPC8536DS ppc mpc85xx mpc8536ds freescale MPC8540ADS_config: unconfig @$(MKCONFIG) $(@:_config=) ppc mpc85xx mpc8540ads freescale
include/configs/MPC8536DS.h +68 -10
158 lines not on this page · raw message
Signature · 1 line
1.6.0.6
PATCH 1/1 85xx: Add a 36-bit physical configuration for MPC8536DS
Dear Kumar Gala,
Quoted 16 lines · In message <[email protected]> you…
We move all IO addressed (CCSR, localbus, PCI) above the 4G boundary to allow for larger memory sizes.
Signed-off-by Kumar Gala <[email protected]>--- Makefile | 8 ++++- include/configs/MPC8536DS.h | 78 +++++++++++++++++++++++++++++++++++++----- 2 files changed, 75 insertions(+), 11 deletions(-)Makefile +0
-0@@ -2406,8 +2406,14 @@ vme8349_config: unconfig ATUM8548_config: unconfig @$(MKCONFIG) $(@:_config=) ppc mpc85xx atum8548
Makefile vme8349_config: unconfig · line 2416
Quoted 10 lines
Makefile +7
-1+MPC8536DS_36BIT_config \ MPC8536DS_config: unconfig - @$(MKCONFIG) $(@:_config=) ppc mpc85xx mpc8536ds freescale + @mkdir -p $(obj)include + @if [ "$(findstring _36BIT_,$@)" ] ; then \ + echo "#define CONFIG_PHYS_64BIT" >>$(obj)include/config.h ; \ + $(XECHO) "... enabling 36-bit physical addressing." ; \ + fi + @$(MKCONFIG) -a MPC8536DS ppc mpc85xx mpc8536ds freescale
Argh... You know that I hate such long script-like parts in the top level Makefile. Please add such logic to the board config file instead.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If a train station is a place where a train stops,
then what's a workstation?PATCH 1/1 85xx: Add a 36-bit physical configuration for MPC8536DS
Quoted 22 lines · Wolfgang Denk
Dear Kumar Gala,
In message <1249573913-1451-1-git-send-email-
Quoted 18 lines · galak at kernel.crashing.org> you wrote:
We move all IO addressed (CCSR, localbus, PCI) above the 4G boundary to allow for larger memory sizes.
Signed-off-by Kumar Gala <[email protected]>---
Makefile| 8 ++++-include/configs/MPC8536DS.h| 78 +++++++++++++++++++++++++++++++++
++++-----2 files changed, 75 insertions(+), 11 deletions(-)Makefile +0
-0@@ -2406,8 +2406,14 @@ vme8349_config: unconfig
ATUM8548_config: unconfig@$(MKCONFIG) $(@:_config=) ppc mpc85xx atum8548
Quoted 13 lines
Makefile vme8349_config: unconfig · line 2416
Quoted 9 lines
+MPC8536DS_36BIT_config \
MPC8536DS_config: unconfigMakefile +6
-1- @$(MKCONFIG) $(@:_config=) ppc mpc85xx mpc8536ds freescale + @mkdir -p $(obj)include + @if [ "$(findstring _36BIT_,$@)" ] ; then \ + echo "#define CONFIG_PHYS_64BIT" >>$(obj)include/config.h ; \ + $(XECHO) "... enabling 36-bit physical addressing." ; \ + fi + @$(MKCONFIG) -a MPC8536DS ppc mpc85xx mpc8536ds freescaleArgh... You know that I hate such long script-like parts in the top level
Makefile. Please add such logic to the board config file instead.
Do you have an example of doing this for a single config option like this? I'm happy to fix things.
Should I have a:
include/configs/MPC8536DS_36BIT.h
that looks like:
#ifndef MPC8536DS_36BIT_H
#define MPC8536DS_36BIT_H
#define CONFIG_PHYS_64BIT
#include <configs/MPC8536DS.h>
#endif
or is there some other solution to this problem?
- k
PATCH 1/1 85xx: Add a 36-bit physical configuration for MPC8536DS
Dear Kumar Gala,
Quoted 15 lines · In message <[email protected]> you wrote:
Quoted 14 lines
Makefile vme8349_config: unconfig · line 2416
Quoted 10 lines
+MPC8536DS_36BIT_config \
MPC8536DS_config: unconfigMakefile +6
-1- @$(MKCONFIG) $(@:_config=) ppc mpc85xx mpc8536ds freescale + @mkdir -p $(obj)include + @if [ "$(findstring _36BIT_,$@)" ] ; then \ + echo "#define CONFIG_PHYS_64BIT" >>$(obj)include/config.h ; \ + $(XECHO) "... enabling 36-bit physical addressing." ; \ + fi + @$(MKCONFIG) -a MPC8536DS ppc mpc85xx mpc8536ds freescaleArgh... You know that I hate such long script-like parts in the top level
Makefile. Please add such logic to the board config file instead.
Quoted 2 lines
Do you have an example of doing this for a single config option like this? I'm happy to fix things.
One possibility is to replace the ``findstring'' part with
@echo "#define CONFIG_$(@:_config=)" >$(obj)include/config.h
This way include/config.h will have either "#define CONFIG_MPC8536DS" or "#define CONFIG_MPC8536DS_36BIT", which can be trivially evaluated in your board config file.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Until you walk a mile in another man's moccasins, you can't imagine the smell.