tools: unused code removal mpc86x_clk.c
PATCH 1/1 tools: unused code removal mpc86x_clk.c
It is observed that tools/mpc86x_clk.c is not referred anywhere the build entry was commented in Makefile,
all the references related to this file are removed
--- tools/Makefile | 10 --- tools/mpc86x_clk.c | 218 ---------------------------------------------------- 2 files changed, 0 insertions(+), 228 deletions(-) delete mode 100644 tools/mpc86x_clk.c
tools/Makefile +0 -10
@@ -102,12 +102,6 @@ OBJ_FILES-$(CONFIG_NETCONSOLE) += ncb.o OBJ_FILES-y += os_support.o OBJ_FILES-$(CONFIG_SHA1_CHECK_UB_IMG) += ubsha1.o -# Don't build by default -#ifeq ($(ARCH),ppc) -#BIN_FILES-y += mpc86x_clk$(SFX) -#OBJ_FILES-y += mpc86x_clk.o -#endif - # Flattened device tree objects LIBFDT_OBJ_FILES-y += fdt.o LIBFDT_OBJ_FILES-y += fdt_ro.o
@@ -188,10 +182,6 @@ $(obj)mkimage$(SFX): $(obj)crc32.o $(obj)mkimage.o $(obj)image.o $(obj)md5.o $(o $(CC) $(CFLAGS) $(HOST_LDFLAGS) -o $@ $^ $(STRIP) $@ -$(obj)mpc86x_clk$(SFX): $(obj)mpc86x_clk.o - $(CC) $(CFLAGS) $(HOST_LDFLAGS) -o $@ $^ - $(STRIP) $@ - $(obj)ncb$(SFX): $(obj)ncb.o $(CC) $(CFLAGS) $(HOST_LDFLAGS) -o $@ $^ $(STRIP) $@
tools/mpc86x_clk.c deleted +0 -218
218 lines not on this page · raw message
Signature · 1 line
1.5.3.3
PATCH 1/1 tools: unused code removal mpc86x_clk.c
Dear Prafulla Wadaskar,
Quoted 5 lines · In message <[email protected]> you wrote:
It is observed that
tools/mpc86x_clk.cis not referred anywhere the build entry was commented inMakefile,
all the references related to this file are removedSigned-off-by Prafulla Wadaskar <[email protected]>
Why are you removing this tool? Even though it does not get build by default, it is still pretty useful when you have to design the clock system on a MPC8xx processor.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "There are three principal ways to lose money: wine, women, and engi- neers. While the first two are more pleasant, the third is by far the more certain." - Baron Rothschild, ca. 1800
PATCH 1/1 tools: unused code removal mpc86x_clk.c
Quoted 15 lines
-----Original Message-----
From: Wolfgang Denk [mailto:wd at denx.de]
Sent: Monday, August 10, 2009 4:49 PM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
Subject: Re: [U-Boot] [PATCH] tools: unused code removalmpc86x_clk.cDear Prafulla Wadaskar,
In message
Quoted 2 lines · <[email protected]> you wrote:
It is observed that
tools/mpc86x_clk.cis not referred anywhere the build entry was commented inMakefile, all the references
Quoted 8 lines
related to
Quoted 3 lines
this file are removed
Signed-off-by Prafulla Wadaskar <[email protected]>Why are you removing this tool? Even though it does not get build by default, it is still pretty useful when you have to design the clock system on a MPC8xx processor.
I agree, but why it is not build by default?
can someone provide the fix to build it?
even conditional build is okay.
Regards..
Prafulla ..
Quoted 14 lines
Best regards,
Wolfgang Denk
Signature · 7 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "There are three principal ways to lose money: wine, women, and engi- neers. While the first two are more pleasant, the third is by far the more certain." - Baron Rothschild, ca. 1800
PATCH 1/1 tools: unused code removal mpc86x_clk.c
Dear Prafulla Wadaskar,
Quoted 5 lines · In message <[email protected]>…
Quoted 4 lines
Why are you removing this tool? Even though it does not get=20 build by default, it is still pretty useful when you have to=20 design the clock system on a MPC8xx processor.
I agree, but why it is not build by default?
It just adds to the build time, and probably nobody ever uses it.
Quoted 2 lines
can someone provide the fix to build it?
even conditional build is okay.
What exactly is the problem you're tryting to address? Some commented out code in the Makefile?
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de One possible reason that things aren't going according to plan is that there never was a plan in the first place.
PATCH 1/1 tools: unused code removal mpc86x_clk.c
Quoted 22 lines
-----Original Message-----
From: Wolfgang Denk [mailto:wd at denx.de]
Sent: Monday, August 10, 2009 6:30 PM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
Subject: Re: [U-Boot] [PATCH] tools: unused code removalmpc86x_clk.cDear Prafulla Wadaskar,
In message <[email protected].
Quoted 2 lines · com> you wrote:
Quoted 2 lines
Why are you removing this tool? Even though it does not
get=20 build
Quoted 1 line
Quoted 1 line
by default, it is still pretty useful when you have to=20
design the
Quoted 2 lines
Quoted 1 line
clock system on a MPC8xx processor.
I agree, but why it is not build by default?
Quoted 7 lines
It just adds to the build time, and probably nobody ever uses it.
Quoted 2 lines
can someone provide the fix to build it?
even conditional build is okay.What exactly is the problem you're tryting to address? Some commented out code in the
Makefile?
Exactly, let's remove this dead code or support it properly. What do you think?
Copying Pantelis Antoniou, writer of this code
Regards..
Prafulla . .
Quoted 13 lines
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de One possible reason that things aren't going according to plan is that there never was a plan in the first place.