posix-cpu-timers: fix CPUCLOCK_{PROF,VIRT} periodic tics precision
cover posix-cpu-timers: fix CPUCLOCK_{PROF,VIRT} periodic tics precision
Hello.
POSIX 1.b cpu timers where clockid is based on CPUCLOCK_PROF and CPUCLOCK_VIRT, have systematic timer error, the same as had itimers. Error can be showed by program [1]. Results for unpatched and patched kernel are below:
Unpatched kernel:
CLK_PROF
Period 10000: counted time 14.51 , real time 15.99 , error -9.2 %
Period 9998: counted time 15.95 , real time 15.96 , error -0.1 %
Period 1000: counted time 7.99 , real time 15.98 , error -50.0 %
Period 11111: counted time 14.77 , real time 15.96 , error -7.5 %
Period 21315: counted time 15.45 , real time 15.96 , error -3.1 %
Period 1500: counted time 11.98 , real time 15.98 , error -25.0 %
Period 15000: counted time 14.96 , real time 15.96 , error -6.3 %
Period 50000: counted time 15.60 , real time 15.95 , error -2.2 %
Period 777777: counted time 15.56 , real time 15.95 , error -2.5 %
Period 212341: counted time 15.71 , real time 15.95 , error -1.5 %
Period 10001: counted time 14.50 , real time 15.96 , error -9.1 %
Period 1002: counted time 8.01 , real time 15.98 , error -49.9 %
Period 999000: counted time 14.98 , real time 15.95 , error -6.1 %
Period 2222: counted time 11.83 , real time 15.97 , error -26.0 %
Period 500: counted time 8.01 , real time 16.02 , error -50.0 %CLK_VIRT
Period 10000: counted time 14.50 , real time 15.96 , error -9.2 %
Period 9998: counted time 15.95 , real time 15.96 , error -0.1 %
Period 1000: counted time 7.99 , real time 15.98 , error -50.0 %
Period 11111: counted time 14.77 , real time 15.97 , error -7.5 %
Period 21315: counted time 15.45 , real time 15.96 , error -3.2 %
Period 1500: counted time 11.99 , real time 15.99 , error -25.0 %
Period 15000: counted time 14.96 , real time 15.96 , error -6.3 %
Period 50000: counted time 15.60 , real time 15.96 , error -2.2 %
Period 777777: counted time 15.56 , real time 15.95 , error -2.5 %
Period 212341: counted time 15.71 , real time 15.96 , error -1.5 %
Period 10001: counted time 14.50 , real time 15.96 , error -9.1 %
Period 1002: counted time 8.01 , real time 15.99 , error -49.9 %
Period 999000: counted time 14.98 , real time 15.95 , error -6.1 %
Period 2222: counted time 11.83 , real time 15.98 , error -26.0 %
Period 500: counted time 8.01 , real time 16.01 , error -50.0 %
Patched kernel:
CLK_PROF
Period 10000: counted time 16.05 , real time 16.06 , error -0.1 %
Period 9998: counted time 16.30 , real time 16.30 , error -0.0 %
Period 1000: counted time 16.45 , real time 16.45 , error -0.0 %
Period 11111: counted time 15.99 , real time 16.00 , error -0.1 %
Period 21315: counted time 15.99 , real time 15.99 , error -0.1 %
Period 1500: counted time 16.03 , real time 16.03 , error -0.0 %
Period 15000: counted time 15.99 , real time 16.00 , error -0.0 %
Period 50000: counted time 15.95 , real time 15.99 , error -0.3 %
Period 777777: counted time 15.56 , real time 15.99 , error -2.7 %
Period 212341: counted time 16.35 , real time 16.37 , error -0.1 %
Period 10001: counted time 15.99 , real time 16.00 , error -0.0 %
Period 1002: counted time 16.05 , real time 16.05 , error -0.0 %
Period 999000: counted time 15.98 , real time 15.99 , error -0.1 %
Period 2222: counted time 16.02 , real time 16.02 , error -0.0 %
Period 500: counted time 8.02 , real time 16.05 , error -50.0 %CLK_VIRT
Period 10000: counted time 15.99 , real time 16.00 , error -0.1 %
Period 9998: counted time 16.02 , real time 16.03 , error -0.1 %
Period 1000: counted time 16.04 , real time 16.05 , error -0.1 %
Period 11111: counted time 15.99 , real time 16.00 , error -0.1 %
Period 21315: counted time 16.39 , real time 16.40 , error -0.1 %
Period 1500: counted time 16.02 , real time 16.03 , error -0.0 %
Period 15000: counted time 15.97 , real time 16.00 , error -0.1 %
Period 50000: counted time 15.95 , real time 16.00 , error -0.3 %
Period 777777: counted time 15.56 , real time 16.00 , error -2.8 %
Period 212341: counted time 16.14 , real time 16.34 , error -1.2 %
Period 10001: counted time 15.98 , real time 16.00 , error -0.1 %
Period 1002: counted time 16.04 , real time 16.05 , error -0.0 %
Period 999000: counted time 15.98 , real time 16.00 , error -0.1 %
Period 2222: counted time 16.01 , real time 16.02 , error -0.1 %
Period 500: counted time 8.02 , real time 16.05 , error -50.0 %
Even if probably nobody use these timers, I think we should fix them because we have this API in kernel and the timers perform bad. Patch is against Ingo's -tip (-sched-devel) tree where are my previous itmiers patches.
Cheers
Stanislaw
[1] Program for measurement POSIX.1b CPUCLOCK_{PROF,VIRT} cpu timers precision
#include <sys/time.h>
#include <signal.h>
#include <stdio.h>
#include <stdlib.h>
#include <time.h>
#include <string.h>
#include <unistd.h>
#define ARRAY_SIZE(a) (sizeof(a)/sizeof(a[0]))
const int test_periods_us[] = {
10000,
9998,
1000,
11111,
21315,
1500,
15000,
50000,
777777,
212341,
10001,
1002,
999000,
2222,
500,
};volatile int prof_counter;
void handler(int signr)
{
prof_counter++;
}#define CPUCLOCK_PROF 0
#define CPUCLOCK_VIRT 1
#define CPUCLOCK_SCHED 2
#define MAKE_PROCESS_CPUCLOCK(pid, clock) \ ((~(clockid_t) (pid) << 3) | (clockid_t) (clock))
#define CLK_PROF MAKE_PROCESS_CPUCLOCK(0, CPUCLOCK_PROF)
#define CLK_VIRT MAKE_PROCESS_CPUCLOCK(0, CPUCLOCK_VIRT)
#define CLK_SCHED MAKE_PROCESS_CPUCLOCK(0, CPUCLOCK_SCHED)
void test_func(void)
{
long long i = 0;
long long count = 0;
for(i=0; i<3000000000LL; i++)
count++;
}double timeval_diff(const struct timeval *start, const struct timeval *end)
{
return (end->tv_sec - start->tv_sec) + (end->tv_usec - start->tv_usec)/1000000.0;
}void measure_itimer_error(int period_us, clockid_t clk_id)
{
struct sigaction act;
struct timeval start, end;
struct sigevent evt;
double real_time, counted_time;
timer_t tid;
prof_counter = 0;
struct timespec period_ts = {
.tv_sec = 0,
.tv_nsec = period_us * 1000,
};
struct itimerspec timer_spec = {
.it_interval = period_ts,
.it_value = period_ts
};
act.sa_handler = handler;
sigemptyset(&act.sa_mask);
act.sa_flags = 0;
if (sigaction(SIGPROF, &act, NULL) < 0) {
printf("sigaction failed\n");
exit(1);
}
memset(&evt, 0, sizeof(evt));
evt.sigev_notify = SIGEV_SIGNAL;
evt.sigev_signo = SIGPROF;
if (timer_create(clk_id, &evt, &tid) < 0) {
perror("timer_create");
exit(1);
}
if (timer_settime(tid, 0, &timer_spec, NULL) < 0) {
perror("timer_settime");
exit(1);
}
/* run a busy loop and measure it */
gettimeofday(&start, NULL);
test_func();
gettimeofday(&end, NULL);
/* disable the timer */
memset(&timer_spec, 0, sizeof(timer_spec));
if (timer_settime(tid, 0, &timer_spec, NULL) < 0) {
perror("timer_settime");
exit(1);
}
if (timer_delete(tid) < 0) {
perror("timer_delete");
exit(1);
}
counted_time = prof_counter * period_us / 1000000.0;
real_time = timeval_diff(&start, &end);
printf("Period %d:\tcounted time %.2f , real time %.2f , error %.1f %%\n",
period_us, counted_time, real_time, (counted_time/real_time - 1.0)*100.0);
}int main()
{
int i;
printf("CLK_PROF\n");
for (i=0; i<ARRAY_SIZE(test_periods_us); i++)
measure_itimer_error(test_periods_us[i], CLK_PROF);
printf("CLK_VIRT\n");
for (i=0; i<ARRAY_SIZE(test_periods_us); i++)
measure_itimer_error(test_periods_us[i], CLK_VIRT);
return 0;
}PATCH 1/1 posix-cpu-timers: fix CPUCLOCK_{PROF,VIRT} periodic tics precision
When calculating next expires time and timer overrun value for periodic timer use real nanosecond interval value provided by user (same 64 bits algorithm as for CPUCLOCK_SCHED). Then round up values for cputime resolution based on nanosecond value of one cpu tick.
--- include/linux/posix-timers.h | 17 ++++++++ kernel/itimer.c | 11 ----- kernel/posix-cpu-timers.c | 92 +++++++++++++++++++++++++++-------------- 3 files changed, 77 insertions(+), 43 deletions(-)
include/linux/posix-timers.h +17 -0
@@ -13,7 +13,9 @@ union cpu_time_count {struct cpu_timer_list {struct list_head entry;union cpu_time_count expires, incr; +u64 real_incr;struct task_struct *task; +u32 error;int firing; };
@@ -119,4 +121,19 @@ long clock_nanosleep_restart(struct restart_block *restart_block);void update_rlimit_cpu (unsigned long rlim_new); +/* +* Helper for calculating error when rounding time values providing +* in nano or micro seconds to cputime_t ticks. +*/ +static inline u32 cputime_sub_ns (cputime_t ct,s64 real_ns) +{ +struct timespec ts; +s64 cpu_ns; + +cputime_to_timespec (ct, &ts); + cpu_ns =timespec_to_ns (&ts); + +return (cpu_ns <= real_ns) ?0 : cpu_ns - real_ns; +} +#endif
kernel/itimer.c +0 -11
@@ -127,17 +127,6 @@ enum hrtimer_restart it_real_fn(struct hrtimer *timer)return HRTIMER_NORESTART ; } -static inline u32 cputime_sub_ns (cputime_t ct,s64 real_ns) -{ -struct timespec ts; -s64 cpu_ns; - -cputime_to_timespec (ct, &ts); - cpu_ns =timespec_to_ns (&ts); - -return (cpu_ns <= real_ns) ?0 : cpu_ns - real_ns; -} -static void set_cpu_itimer (struct task_struct *tsk,unsigned int clock_id,const struct itimerval *const value,struct itimerval *const ovalue)
kernel/posix-cpu-timers.c +60 -32
144 lines not on this page · raw message
Signature · 1 line
1.6.2.5
Quoted 74 lines · On Tue, 11 Aug 2009 16:31:39 +0200 Stanislaw Gruszka <[email protected]>…
POSIX 1.b cpu timers where clockid is based on
CPUCLOCK_PROFandCPUCLOCK_VIRT, have systematic timer error, the same as had itimers. Error can be showed by program [1]. Results for unpatched and patched kernel are below:Unpatched kernel:
CLK_PROF
Period 10000: counted time 14.51 , real time 15.99 , error -9.2 %
Period 9998: counted time 15.95 , real time 15.96 , error -0.1 %
Period 1000: counted time 7.99 , real time 15.98 , error -50.0 %
Period 11111: counted time 14.77 , real time 15.96 , error -7.5 %
Period 21315: counted time 15.45 , real time 15.96 , error -3.1 %
Period 1500: counted time 11.98 , real time 15.98 , error -25.0 %
Period 15000: counted time 14.96 , real time 15.96 , error -6.3 %
Period 50000: counted time 15.60 , real time 15.95 , error -2.2 %
Period 777777: counted time 15.56 , real time 15.95 , error -2.5 %
Period 212341: counted time 15.71 , real time 15.95 , error -1.5 %
Period 10001: counted time 14.50 , real time 15.96 , error -9.1 %
Period 1002: counted time 8.01 , real time 15.98 , error -49.9 %
Period 999000: counted time 14.98 , real time 15.95 , error -6.1 %
Period 2222: counted time 11.83 , real time 15.97 , error -26.0 %
Period 500: counted time 8.01 , real time 16.02 , error -50.0 %CLK_VIRT
Period 10000: counted time 14.50 , real time 15.96 , error -9.2 %
Period 9998: counted time 15.95 , real time 15.96 , error -0.1 %
Period 1000: counted time 7.99 , real time 15.98 , error -50.0 %
Period 11111: counted time 14.77 , real time 15.97 , error -7.5 %
Period 21315: counted time 15.45 , real time 15.96 , error -3.2 %
Period 1500: counted time 11.99 , real time 15.99 , error -25.0 %
Period 15000: counted time 14.96 , real time 15.96 , error -6.3 %
Period 50000: counted time 15.60 , real time 15.96 , error -2.2 %
Period 777777: counted time 15.56 , real time 15.95 , error -2.5 %
Period 212341: counted time 15.71 , real time 15.96 , error -1.5 %
Period 10001: counted time 14.50 , real time 15.96 , error -9.1 %
Period 1002: counted time 8.01 , real time 15.99 , error -49.9 %
Period 999000: counted time 14.98 , real time 15.95 , error -6.1 %
Period 2222: counted time 11.83 , real time 15.98 , error -26.0 %
Period 500: counted time 8.01 , real time 16.01 , error -50.0 %Patched kernel:
CLK_PROF
Period 10000: counted time 16.05 , real time 16.06 , error -0.1 %
Period 9998: counted time 16.30 , real time 16.30 , error -0.0 %
Period 1000: counted time 16.45 , real time 16.45 , error -0.0 %
Period 11111: counted time 15.99 , real time 16.00 , error -0.1 %
Period 21315: counted time 15.99 , real time 15.99 , error -0.1 %
Period 1500: counted time 16.03 , real time 16.03 , error -0.0 %
Period 15000: counted time 15.99 , real time 16.00 , error -0.0 %
Period 50000: counted time 15.95 , real time 15.99 , error -0.3 %
Period 777777: counted time 15.56 , real time 15.99 , error -2.7 %
Period 212341: counted time 16.35 , real time 16.37 , error -0.1 %
Period 10001: counted time 15.99 , real time 16.00 , error -0.0 %
Period 1002: counted time 16.05 , real time 16.05 , error -0.0 %
Period 999000: counted time 15.98 , real time 15.99 , error -0.1 %
Period 2222: counted time 16.02 , real time 16.02 , error -0.0 %
Period 500: counted time 8.02 , real time 16.05 , error -50.0 %CLK_VIRT
Period 10000: counted time 15.99 , real time 16.00 , error -0.1 %
Period 9998: counted time 16.02 , real time 16.03 , error -0.1 %
Period 1000: counted time 16.04 , real time 16.05 , error -0.1 %
Period 11111: counted time 15.99 , real time 16.00 , error -0.1 %
Period 21315: counted time 16.39 , real time 16.40 , error -0.1 %
Period 1500: counted time 16.02 , real time 16.03 , error -0.0 %
Period 15000: counted time 15.97 , real time 16.00 , error -0.1 %
Period 50000: counted time 15.95 , real time 16.00 , error -0.3 %
Period 777777: counted time 15.56 , real time 16.00 , error -2.8 %
Period 212341: counted time 16.14 , real time 16.34 , error -1.2 %
Period 10001: counted time 15.98 , real time 16.00 , error -0.1 %
Period 1002: counted time 16.04 , real time 16.05 , error -0.0 %
Period 999000: counted time 15.98 , real time 16.00 , error -0.1 %
Period 2222: counted time 16.01 , real time 16.02 , error -0.1 %
Period 500: counted time 8.02 , real time 16.05 , error -50.0 %
Quoted 4 lines
Even if probably nobody use these timers, I think we should fix them because we have this API in kernel and the timers perform bad. Patch is against Ingo's -tip (-sched-devel) tree where are my previous itmiers patches.
I tested my patch on ppc64 and sadly it is broken. I get this output for patched kernel:
CLK_PROF
Period 10000: counted time 46.24 , real time 41.63 , error 11.1 % Period 9998: counted time 46.24 , real time 41.63 , error 11.1 % Period 1000: counted time 42.01 , real time 42.50 , error -1.2 % Period 11111: counted time 45.72 , real time 41.63 , error 9.8 % Period 21315: counted time 43.65 , real time 41.62 , error 4.9 % Period 1500: counted time 63.26 , real time 42.48 , error 48.9 % Period 15000: counted time 44.53 , real time 41.59 , error 7.1 % Period 50000: counted time 42.40 , real time 41.58 , error 2.0 % Period 777777: counted time 41.22 , real time 41.57 , error -0.8 % Period 212341: counted time 41.62 , real time 41.57 , error 0.1 % Period 10001: counted time 46.22 , real time 41.62 , error 11.1 % Period 1002: counted time 42.52 , real time 42.46 , error 0.1 % Period 999000: counted time 40.96 , real time 41.63 , error -1.6 % Period 2222: counted time 76.01 , real time 42.31 , error 79.6 % Period 500: counted time 21.16 , real time 42.46 , error -50.2 % CLK_VIRT Period 10000: counted time 45.68 , real time 41.65 , error 9.7 % Period 9998: counted time 45.66 , real time 41.77 , error 9.3 % Period 1000: counted time 41.89 , real time 42.40 , error -1.2 % Period 11111: counted time 45.17 , real time 41.63 , error 8.5 % Period 21315: counted time 43.10 , real time 41.60 , error 3.6 % Period 1500: counted time 63.10 , real time 42.57 , error 48.2 % Period 15000: counted time 44.04 , real time 41.62 , error 5.8 % Period 50000: counted time 41.90 , real time 41.61 , error 0.7 % Period 777777: counted time 40.44 , real time 41.62 , error -2.8 % Period 212341: counted time 41.19 , real time 41.60 , error -1.0 % Period 10001: counted time 45.66 , real time 41.64 , error 9.7 % Period 1002: counted time 41.74 , real time 42.52 , error -1.8 % Period 999000: counted time 40.96 , real time 41.70 , error -1.8 % Period 2222: counted time 75.50 , real time 42.32 , error 78.4 % Period 500: counted time 21.11 , real time 42.56 , error -50.4 %
Signals are generated more frequent than should. I guess I'm doing something wrong with cputime_to_jiffies() and/or jiffies_to_cputime(), but as far I'm not sure were the bug is.
Anyway, please forgot about the patch as long as I figure this out.
cover posix-cpu-timers: fix CPUCLOCK_{PROF,VIRT} periodic tics precision -v1
In reply to Stanislaw GruszkaReference:
http://lkml.org/lkml/2009/8/11/174
Changelog v0 -> v1:
Fix for PowerPC with CONFIG_VIRT_CPU_ACCOUNTING. Due to rounding return value of cputime_to_jiffies(), calculations of next expiration time not worked as I expected. I removed any conversions and do direct calculations on cputime values treat them as unsigned long long.
Cheers
Stanislaw
PATCH 1/1 posix-cpu-timers: fix CPUCLOCK_{PROF,VIRT} periodic tics precision -v1
When calculating next expires time and timer overrun value for periodic timer use real nanosecond interval value provided by user (same 64 bits algorithm as for CPUCLOCK_SCHED). Then round up values for cputime resolution based on nanosecond value of one cpu tick.
With CONFIG_VIRT_CPU_ACCOUNTING=y we do not need to any extra conversions because cputime is 64 bit value accurately accounted.
--- include/linux/posix-timers.h | 19 ++++++++ kernel/itimer.c | 11 ---- kernel/posix-cpu-timers.c | 104 +++++++++++++++++++++++++++++------------- 3 files changed, 91 insertions(+), 43 deletions(-)
include/linux/posix-timers.h +19 -0
@@ -15,6 +15,10 @@ struct cpu_timer_list {union cpu_time_count expires, incr;struct task_struct *task;int firing; +#ifndef CONFIG_VIRT_CPU_ACCOUNTING +u32 error; +u64 real_incr; +#endif };#define CPUCLOCK_PID (clock) ((pid_t) ~((clock) >> 3))
@@ -119,4 +123,19 @@ long clock_nanosleep_restart(struct restart_block *restart_block);void update_rlimit_cpu (unsigned long rlim_new); +/* +* Helper for calculating error when rounding time values providing +* in nano or micro seconds to cputime_t ticks. +*/ +static inline u32 cputime_sub_ns (cputime_t ct,s64 real_ns) +{ +struct timespec ts; +s64 cpu_ns; + +cputime_to_timespec (ct, &ts); + cpu_ns =timespec_to_ns (&ts); + +return (cpu_ns <= real_ns) ?0 : cpu_ns - real_ns; +} +#endif
kernel/itimer.c +0 -11
@@ -129,17 +129,6 @@ enum hrtimer_restart it_real_fn(struct hrtimer *timer)return HRTIMER_NORESTART ; } -static inline u32 cputime_sub_ns (cputime_t ct,s64 real_ns) -{ -struct timespec ts; -s64 cpu_ns; - -cputime_to_timespec (ct, &ts); - cpu_ns =timespec_to_ns (&ts); - -return (cpu_ns <= real_ns) ?0 : cpu_ns - real_ns; -} -static void set_cpu_itimer (struct task_struct *tsk,unsigned int clock_id,const struct itimerval *const value,struct itimerval *const ovalue)
kernel/posix-cpu-timers.c +72 -32
157 lines not on this page · raw message
Signature · 1 line
1.6.2.5