serial: pl010 is no longer broken
PATCH 1/1 serial: pl010 is no longer broken
As more ARM platforms are moving into ARCH_MULTIPLATFORM, we can now have integrator and versatile in the same kernel, and first one selects this driver, causing a Kconfig warning:
warning: (ARCH_INTEGRATOR_AP) selects SERIAL_AMBA_PL010 which has unmet direct dependencies (TTY && HAS_IOMEM && ARM_AMBA && (BROKEN || !ARCH_VERSATILE))
It turns out that it has not been broken on versatile for a long time, so we can remove the statement here.
drivers/tty/serial/Kconfig +1 -1
@@ -20,7 +20,7 @@ comment "Non-8250 serial port support" config SERIAL_AMBA_PL010 tristate "ARM AMBA PL010 serial port support" - depends on ARM_AMBA && (BROKEN || !ARCH_VERSATILE) + depends on ARM_AMBA select SERIAL_CORE help This selects the ARM(R) AMBA(R) PrimeCell PL010 UART. If you have
Greg Kroah-Hartman
maintainerPATCH 1/1 serial: pl010 is no longer broken
Quoted 17 lines · Arnd Bergmann
As more ARM platforms are moving into
ARCH_MULTIPLATFORM, we can now have integrator and versatile in the same kernel, and first one selects this driver, causing aKconfigwarning:warning: (
ARCH_INTEGRATOR_AP) selectsSERIAL_AMBA_PL010which has unmet direct dependencies (TTY &&HAS_IOMEM&&ARM_AMBA&& (BROKEN || !ARCH_VERSATILE))It turns out that it has not been broken on versatile for a long time, so we can remove the statement here.
Signed-off-by Arnd Bergmann <[email protected]>drivers/tty/serial/Kconfig +0
-0
drivers/tty/serial/Kconfig comment "Non-8250 serial port support" · line 26
Quoted 8 lines
drivers/tty/serial/Kconfig +1
-1@@ -20,7 +20,7 @@ comment "Non-8250 serial port support" config SERIAL_AMBA_PL010 tristate "ARM AMBA PL010 serial port support" - depends on ARM_AMBA && (BROKEN || !ARCH_VERSATILE) + depends on ARM_AMBA select SERIAL_CORE help This selects the ARM(R) AMBA(R) PrimeCell PL010 UART. If you have
Is it ok if we wait for 4.1-rc1 for this, or do you think it's really ok for 4.0-final?
thanks,
greg k-h
PATCH 1/1 serial: pl010 is no longer broken
Quoted 5 lines · On Wednesday 25 February 2015 08:02:16 Greg Kroah-Hartman wrote:
Quoted 4 lines · Arnd Bergmann
As more ARM platforms are moving into
ARCH_MULTIPLATFORM, we can now have integrator and versatile in the same kernel, and first one selects this driver, causing aKconfigwarning:
Quoted 7 lines
Quoted 4 lines
warning: (
ARCH_INTEGRATOR_AP) selectsSERIAL_AMBA_PL010which has unmet direct dependencies (TTY &&HAS_IOMEM&&ARM_AMBA&& (BROKEN || !ARCH_VERSATILE))It turns out that it has not been broken on versatile for a long time, so we can remove the statement here.
Is it ok if we wait for 4.1-rc1 for this, or do you think it's really ok for 4.0-final?
It's not urgent and should just go into 4.1.
Arnd