Skip to contentSkip to conversation

powerpc: derive COMMAND_LINE_SIZE from asm-generic

PATCH In review Paul Gortmaker 2 participants 3 messages Aug 13, 2009 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: derive COMMAND_LINE_SIZE from asm-generic

The default COMMAND_LINE_SIZE in asm-generic is 512, so the net effect of this change is nil, aside from the cleanup factor. See also commit 2b74b8569.

---
 arch/powerpc/include/asm/setup.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/powerpc/include/asm/setup.h +1 -1
index 817fac0..dae1934 100644
@@ -1,6 +1,6 @@
 #ifndef _ASM_POWERPC_SETUP_H
 #define _ASM_POWERPC_SETUP_H
 
-#define COMMAND_LINE_SIZE	512
+#include <asm-generic/setup.h>
 
 #endif	/* _ASM_POWERPC_SETUP_H */
Signature · 1 line
1.6.3.3
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · On Thursday 13 August 2009 19:37:04 Paul Gortmaker wrote:

The default COMMAND_LINE_SIZE in asm-generic is 512, so the net effect of this change is nil, aside from the cleanup factor. See also commit 2b74b8569.

Just to clarify why this is good: There is a patch from Remis to kbuild that can automatically create the trivial wrappers, so we can remove arch/powerpc/include/asm/setup.h from the kernel once that patch is applied.

I was also planning to submit a series to clean up more powerpc in this way headers where applicable, see
http://git.kernel.org/?p=linux/kernel/git/arnd/asm-generic.git;a=shortlog;h=powerpc

The series needs some forward porting to 2.6.31 as well as testing. If you or someone else wants to help with that, please go ahead!

Thanks,

	Arnd <><
#2 lore raw
Quoted 9 lines · Arnd Bergmann
Quoted 5 lines · On Thursday 13 August 2009 19:37:04 Paul Gortmaker wrote:

The default COMMAND_LINE_SIZE in asm-generic is 512, so the net effect of this change is nil, aside from the cleanup factor. See also commit 2b74b8569.

Quoted 8 lines

Just to clarify why this is good: There is a patch from Remis to kbuild that can automatically create the trivial wrappers, so we can remove arch/powerpc/include/asm/setup.h from the kernel once that patch is applied.

I was also planning to submit a series to clean up more powerpc in this way headers where applicable, see
http://git.kernel.org/?p=linux/kernel/git/arnd/asm-generic.git;a=shortlog;h=powerpc

I'd looked at master and next in your tree; I didn't list all the branches and so I'd not noticed powerpc in there as well.

Quoted 3 lines

The series needs some forward porting to 2.6.31 as well as testing. If you or someone else wants to help with that, please go ahead!

I'll definitely have a look at what is in there.

Paul.

Quoted 4 lines

Thanks,

	Arnd <><