Skip to contentSkip to conversation

Staging: sep: should depend on PCI

PATCH In review Alexander Beregalov 2 participants 4 messages Aug 18, 2009 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 Staging: sep: should depend on PCI

Fix this build error when CONFIG_PCI is not set drivers/staging/sep/sep_driver.c:2548: error: implicit declaration of function 'pci_dev_get'

---
 drivers/staging/sep/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/staging/sep/Kconfig +1 -0
index 6ef59f8..2045809 100644
@@ -2,6 +2,7 @@ config DX_SEP
 	tristate "Discretix SEP driver"
 #	depends on MRST
 	depends on RAR_REGISTER
+	depends on PCI
 	default y
 	help
 	  Discretix SEP driver
Signature · 1 line
1.6.4
#1 lore raw

PATCH 2/2 Staging: sep: fix warnings

Fix this warnings
drivers/staging/sep/sep_driver.c:290: warning: format '%d' expects type 'int', but argument 2 has type 'long unsigned int' drivers/staging/sep/sep_driver.c:382: warning: unused variable 'sep'

---
 drivers/staging/sep/sep_driver.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/sep/sep_driver.c +2 -2
index 531814b..e131c9d 100644
@@ -287,7 +287,7 @@ static int sep_map_and_alloc_shared_area(struct sep_device *sep,
 	sep->shared_area = sep->shared_addr;
 	/* set the physical address of the shared area */
 	sep->shared_area_bus = sep->shared_bus;
-	edbg("sep: shared_area %d bytes @%p (bus %08llx)\n",
+	edbg("sep: shared_area %lu bytes @%p (bus %08llx)\n",
 		size, sep->shared_addr, (unsigned long long)sep->shared_bus);
 	return 0;
 }
@@ -379,7 +379,7 @@ end_function:
 -------------------------------------------------------------*/
 static int sep_release(struct inode *inode_ptr, struct file *filp)
 {
-	struct sep_driver *sep =  filp->private_data;
+/*	struct sep_driver *sep =  filp->private_data; */
 	dbg("----------->SEP Driver: sep_release start\n");
 
 #if 0				/*!SEP_DRIVER_POLLING_MODE */
Signature · 1 line
1.6.4
#2 lore raw

Re: [PATCH 2/2] Staging: sep: fix warnings

Quoted 5 lines · Alexander Beregalov

Fix this warnings
drivers/staging/sep/sep_driver.c:290: warning: format '%d' expects type 'int', but argument 2 has type 'long unsigned int' drivers/staging/sep/sep_driver.c:382: warning: unused variable 'sep'

This doesn't apply due to all of the patches from Alan that went into linux-next yeserday for this driver. Care to respin this tomorrow if it's still an issue?

thanks,

greg k-h

#3 lore raw
In reply to Alexander Beregalov
Quoted 2 lines · Alexander Beregalov

Fix this build error when CONFIG_PCI is not set drivers/staging/sep/sep_driver.c:2548: error: implicit declaration of function 'pci_dev_get'

This is now in linux-next as it came from someone else.

thanks,

greg k-h