Skip to contentSkip to conversation

Add adc and sbb missing decoder flags

PATCH In review Mohammed Gamal 2 participants 3 messages Aug 18, 2009

Subsystems (3)
x86 KVM KVM x86
lore
Share & tools
lore

Mohammed Gamal

author
#0 lore raw

PATCH 1/1 Add adc and sbb missing decoder flags

Add missing decoder flags for adc and sbb instructions (opcodes 0x14-0x15, 0x1c-0x1d)

Signed-off-by Mohammed Gamal <[email protected]>
---
 arch/x86/kvm/emulate.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
arch/x86/kvm/emulate.c +4 -2
index 438d423..af58e54 100644
@@ -101,11 +101,13 @@ static u32 opcode_table[256] = {
 	/* 0x10 - 0x17 */
 	ByteOp | DstMem | SrcReg | ModRM, DstMem | SrcReg | ModRM,
 	ByteOp | DstReg | SrcMem | ModRM, DstReg | SrcMem | ModRM,
-	0, 0, ImplicitOps | Stack, ImplicitOps | Stack,
+	ByteOp | DstAcc | SrcImm, DstAcc | SrcImm, 
+	ImplicitOps | Stack, ImplicitOps | Stack,
 	/* 0x18 - 0x1F */
 	ByteOp | DstMem | SrcReg | ModRM, DstMem | SrcReg | ModRM,
 	ByteOp | DstReg | SrcMem | ModRM, DstReg | SrcMem | ModRM,
-	0, 0, ImplicitOps | Stack, ImplicitOps | Stack,
+	ByteOp | DstAcc | SrcImm, DstAcc | SrcImm,
+	ImplicitOps | Stack, ImplicitOps | Stack,
 	/* 0x20 - 0x27 */
 	ByteOp | DstMem | SrcReg | ModRM, DstMem | SrcReg | ModRM,
 	ByteOp | DstReg | SrcMem | ModRM, DstReg | SrcMem | ModRM,
Signature · 1 line
1.6.0.4
#1 lore raw
Quoted 3 lines · Mohammed Gamal

Add missing decoder flags for adc and sbb instructions (opcodes 0x14-0x15, 0x1c-0x1d)

This depends on the previous patch, so I'll just wait until that is ready.

Signature · 1 line
error compiling committee.c: too many arguments to function
author
#2 lore raw
Quoted 8 lines · Avi Kivity
Quoted 4 lines · Mohammed Gamal

Add missing decoder flags for adc and sbb instructions (opcodes 0x14-0x15, 0x1c-0x1d)

This depends on the previous patch, so I'll just wait until that is ready.

I'll rebase this on the current tree and resend it.

Quoted 4 lines

--
error compiling committee.c: too many arguments to function