ath9k: Fix bug in retrieving average beacon rssi
PATCH v2 1/1 ath9k: Fix bug in retrieving average beacon rssi
Currently the beacon rssi that LPF gives is divided and rounded up by ATH_RSSI_EP_MULTIPLIER twice. This will leave the incorrect rssi in ANI. Having correct rssi in ANI fixes the connection stability at < 30dB rssi range. This patch removes the unncessary computation of average rssi over already valid average rssi. Also removes the redundant macros to find average rssi.
---
Added more description in commit msg, no code change over v1
drivers/net/wireless/ath/ath9k/ani.h | 7 +------ 1 files changed, 1 insertions(+), 6 deletions(-)
drivers/net/wireless/ath/ath9k/ani.h +1 -6
@@ -18,15 +18,10 @@#define ANI_H #define HAL_PROCESS_ANI 0x00000001 -#define ATH9K_RSSI_EP_MULTIPLIER (1<<7)#define DO_ANI (ah) (((ah)->proc_phyerr & HAL_PROCESS_ANI)) -#define HAL_EP_RND (x, mul) \ - ((((x)%(mul)) >= ((mul)/2)) ? ((x) + ((mul) - 1)) / (mul) : (x)/(mul)) -#define BEACON_RSSI (ahp) \ - HAL_EP_RND(ahp->stats.ast_nodestats.ns_avgbrssi, \ - ATH9K_RSSI_EP_MULTIPLIER) +#define BEACON_RSSI (ahp) (ahp->stats.ast_nodestats.ns_avgbrssi)#define ATH9K_ANI_OFDM_TRIG_HIGH 500#define ATH9K_ANI_OFDM_TRIG_LOW 200
Signature · 1 line
1.5.5.1
PATCH v2 1/1 ath9k: Fix bug in retrieving average beacon rssi
Quoted 8 lines · Vasanthakumar Thiagarajan
Currently the beacon rssi that LPF gives is divided and rounded up by
ATH_RSSI_EP_MULTIPLIERtwice. This will leave the incorrect rssi in ANI. Having correct rssi in ANI fixes the connection stability at < 30dB rssi range. This patch removes the unncessary computation of average rssi over already valid average rssi. Also removes the redundant macros to find average rssi.Signed-off-by Vasanthakumar Thiagarajan <[email protected]>
Thanks Vasanth, John, this has a better description, if its not too much trouble can you revert 6b82e95960c858e6babf1def7276847e8da8cc25 in favor for this one?
Luis