em28xx: Don't call em28xx_ir_init when disable_ir is true
PATCH 1/1 em28xx: Don't call em28xx_ir_init when disable_ir is true
I think we should call em28xx_ir_init(dev) when disable_ir is true. Following patch will fix the bug.
Cheers,
Shine
-----------------------------------------------------
drivers/media/video/em28xx/em28xx-cards.c +3 -1
@@ -2367,7 +2367,9 @@ }em28xx_tuner_setup (dev); -em28xx_ir_init (dev); + +if (!disable_ir) +em28xx_ir_init (dev); }
Quoted 6 lines · Shine Liu
I think we should call
em28xx_ir_init(dev)whendisable_iris true. Following patch will fix the bug.Cheers,
Shine
Yeah, this looks reasonable. I must have just accidentally cut the code when I refactored the onboard IR support (as opposed to external i2c IR).
In reality I really should take another pass over how the IR registers are configured since currently we rely on the XCLK field definition in the board configuration to setup the IR, which prevents you from switching remote control modes between NEC/RC5/RC6, etc.
Thanks,
Devin
Signature · 2 lines
Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com