Skip to contentSkip to conversation

b43: LP-PHY: Revert to the original PHY register write routine

PATCH Superseded Gábor Stefanik 1 participant 1 message Aug 26, 2009 Networking drivers (wireless)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Gábor Stefanik

author
#0 lore raw

PATCH v2 1/1 b43: LP-PHY: Revert to the original PHY register write routine

After some discussion on IRC about the PHY register write change, I am not sure anymore if this is the right thing to do.

Signed-off-by Gábor Stefanik <[email protected]>

---
v2: No more "From: root".

 drivers/net/wireless/b43/phy_lp.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/net/wireless/b43/phy_lp.c +2 -1
index 80f245c..a57c40d 100644
@@ -1496,7 +1496,8 @@ static u16 b43_lpphy_op_read(struct b43_wldev *dev, u16 reg)
 
 static void b43_lpphy_op_write(struct b43_wldev *dev, u16 reg, u16 value)
 {
-	b43_write32(dev, B43_MMIO_PHY_CONTROL, ((u32)value << 16) | reg);
+	b43_write32(dev, B43_MMIO_PHY_CONTROL, reg);
+	b43_write32(dev, B43_MMIO_PHY_DATA, value);
 }
 
 static void b43_lpphy_op_maskset(struct b43_wldev *dev, u16 reg, u16 mask,
Signature · 1 line
1.5.6