use common code for Matrix Vision boards
PATCH v6 1/1 use common code for Matrix Vision boards
clean up existing boards (mvBC-P/MPC5200 and mvBL-M7/MPC8343) by using common code.
---
Wolfgang,
hopefully this is the last try - I'm close to nervous breakdown. Applying the changes takes longer than actually doing them. Of course this is due to me, I know.
Thanks for your patience,
Andr?
board/matrix_vision/mvbc_p/mvbc_p.c | 97 +++++--------------------- board/matrix_vision/mvbc_p/mvbc_p.h | 2 +- board/matrix_vision/mvbc_p/mvbc_p_autoscript | 10 ++- board/matrix_vision/mvblm7/mvblm7.c | 54 ++++++-------- board/matrix_vision/mvblm7/mvblm7.h | 3 +- board/matrix_vision/mvblm7/pci.c | 35 ++-------- include/configs/MVBC_P.h | 2 +- include/configs/MVBLM7.h | 49 +++++-------- 8 files changed, 77 insertions(+), 175 deletions(-)
board/matrix_vision/mvbc_p/mvbc_p.c +18 -79
@@ -39,6 +39,7 @@#include <asm/io.h> #include "fpga.h" #include "mvbc_p.h" +#include "../common/mv_common.h" #define SDRAM_MODE 0x00CD0000#define SDRAM_CONTROL 0x504F0000
@@ -134,23 +135,6 @@ void mvbc_init_gpio(void)printf ("sint_gpioe : 0x%08x\n" , gpio->sint_gpioe); } -void reset_environment (void ) -{ -char *s, sernr[64 ]; - -printf ("\n*** RESET ENVIRONMENT ***\n" ); -memset (sernr,0 ,sizeof (sernr)); - s =getenv ("serial#" ); -if (s) { -printf ("found serial# : %s\n" , s); -strncpy (sernr, s,64 ); - } - gd->env_valid =0 ; -env_relocate (); -if (s) -setenv ("serial#" , sernr); -} -int misc_init_r (void ) {char *s =getenv ("reset_env" );
@@ -166,7 +150,7 @@ int misc_init_r(void)return 0 ; }printf (" === FACTORY RESET ===\n" ); -reset_environment (); +mv_reset_environment ();saveenv ();return -1 ;
@@ -206,19 +190,28 @@ void flash_afterinit(ulong size)void pci_mvbc_fixup_irq (struct pci_controller *hose,pci_dev_t dev) {unsigned char line =0xff ; +char *s =getenv ("pci_latency" );u32 base; +u8 val =0 ; + +if (s) + val =simple_strtoul (s,NULL ,16 );if (PCI_BUS (dev) ==0 ) {switch (PCI_DEV (dev)) {case 0xa :/* FPGA */ line =3 ;pci_hose_read_config_dword (hose, dev,PCI_BASE_ADDRESS_0 , &base); -printf ("found FPA - enable arbitration\n" ); +printf ("found FPGA - enable arbitration\n" );writel (0x03 , (u32 *)(base +0x80c0 ));writel (0xf0 , (u32 *)(base +0x8080 )); +if (val) +pci_hose_write_config_byte (hose, dev,PCI_LATENCY_TIMER , val);break ;case 0xb :/* LAN */ line =2 ; +if (val) +pci_hose_write_config_byte (hose, dev,PCI_LATENCY_TIMER , val);break ;case 0x1a :break ;
@@ -234,85 +227,31 @@ struct pci_controller hose = { fixup_irq:pci_mvbc_fixup_irq }; -int mvbc_p_load_fpga (void ) -{ -size_t data_size =0 ; -void *fpga_data =NULL ; -char *datastr =getenv ("fpgadata" ); -char *sizestr =getenv ("fpgadatasize" ); - -if (datastr) - fpga_data = (void *)simple_strtoul (datastr,NULL ,16 ); -if (sizestr) - data_size = (size_t )simple_strtoul (sizestr,NULL ,16 ); - -return fpga_load (0 , fpga_data, data_size); -} -extern void pci_mpc5xxx_init (struct pci_controller *);void pci_init_board (void ) { -char *s; -int load_fpga =1 ; -mvbc_p_init_fpga (); - s =getenv ("skip_fpga" ); -if (s) { -printf ("found 'skip_fpga' -> FPGA _not_ loaded !\n" ); - load_fpga =0 ; - } -if (load_fpga) { -printf ("loading FPGA ... " ); -mvbc_p_load_fpga (); -printf ("done\n" ); - } +mv_load_fpga ();pci_mpc5xxx_init (&hose); } -u8 *dhcp_vendorex_prep (u8 *e) -{ -char *ptr; - -/* DHCP vendor-class-identifier = 60 */ -if ((ptr =getenv ("dhcp_vendor-class-identifier" ))) { - *e++ =60 ; - *e++ =strlen (ptr); -while (*ptr) - *e++ = *ptr++; - } -/* DHCP_CLIENT_IDENTIFIER = 61 */ -if ((ptr =getenv ("dhcp_client_id" ))) { - *e++ =61 ; - *e++ =strlen (ptr); -while (*ptr) - *e++ = *ptr++; - } - -return e; -} - -u8 *dhcp_vendorex_proc (u8 *popt) -{ -return NULL ; -} -void show_boot_progress (int val) {struct mpc5xxx_gpio *gpio = (struct mpc5xxx_gpio *)MPC5XXX_GPIO ;switch (val) {case 0 :/* FPGA ok */ -setbits_be32 (&gpio->simple_dvo,0x80 ); +setbits_be32 (&gpio->simple_dvo,LED_G0 );break ; -case 1 : -setbits_be32 (&gpio->simple_dvo,0x40 ); +case 65 : +setbits_be32 (&gpio->simple_dvo,LED_G1 );break ;case 12 : -setbits_be32 (&gpio->simple_dvo,0x20 ); +setbits_be32 (&gpio->simple_dvo,LED_Y );break ;case 15 : -setbits_be32 (&gpio->simple_dvo,0x10 ); +setbits_be32 (&gpio->simple_dvo,LED_R );break ;default :break ;
board/matrix_vision/mvbc_p/mvbc_p.h +1 -1
@@ -23,7 +23,7 @@#define SIMPLE_DDR (LED_G0 | LED_G1 | LED_Y | LED_R | \ FPGA_DIN | FPGA_CCLK | FPGA_CONFIG | WD_WDI)#define SIMPLE_DVO (FPGA_CONFIG) -#define SIMPLE_ODE (FPGA_CONFIG) +#define SIMPLE_ODE (FPGA_CONFIG | LED_G0 | LED_G1 | LED_Y | LED_R)#define SIMPLE_GPIOEN (LED_G0 | LED_G1 | LED_Y | LED_R | \ FPGA_DIN | FPGA_CCLK | FPGA_CONF_DONE | FPGA_CONFIG |\ WD_WDI | COP_PRESENT)
board/matrix_vision/mvbc_p/mvbc_p_autoscript +7 -3
@@ -5,7 +5,7 @@ setenv bootdtb bootm \${kernel_boot} \${mv_initrd_addr_ram} \${mv_dtb_addr_ram} setenv ramkernel setenv kernel_boot \${loadaddr} setenv flashkernel setenv kernel_boot \${mv_kernel_addr} setenv cpird cp \${mv_initrd_addr} \${mv_initrd_addr_ram} \${mv_initrd_length} -setenv bootfromflash run flashkernel cpird ramparam addcons e1000para bootdtb +setenv bootfromflash run flashkernel cpird ramparam addcons e1000para addprofile bootdtb setenv getdtb tftp \${mv_dtb_addr_ram} \${dtb_name} setenv cpdtb cp \${mv_dtb_addr} \${mv_dtb_addr_ram} 0x2000 setenv rundtb fdt addr \${mv_dtb_addr_ram}\;fdt boardsetup
@@ -16,12 +16,16 @@ setenv addcons setenv bootargs \${bootargs} console=ttyPSC\${console_nr},\${baud else setenv addcons setenv bootargs \${bootargs} console=tty0 fi -setenv e1000para setenv bootargs \${bootargs} e1000.TxDescriptors=1500 e1000.SmartPowerDownEnable=1 +setenv e1000para setenv bootargs \${bootargs} e1000.TxDescriptors=256 e1000.SmartPowerDownEnable=1 setenv set_static_ip setenv ipaddr \${static_ipaddr} setenv set_static_nm setenv netmask \${static_netmask} setenv set_static_gw setenv gatewayip \${static_gateway} setenv set_ip setenv ip \${ipaddr}::\${gatewayip}:\${netmask} setenv ramparam setenv bootargs root=/dev/ram0 ro rootfstype=squashfs +if test ${oprofile} = yes; +then +setenv addprofile setenv bootargs \${bootargs} profile=\${profile} +fi if test ${autoscr_boot} != no; then if test ${netboot} = yes;
@@ -31,7 +35,7 @@ then then echo "=== bootp succeeded -> netboot ===" run set_ip - run getdtb rundtb bootfromnet ramparam addcons e1000para bootdtb + run getdtb rundtb bootfromnet ramparam addcons e1000para addprofile bootdtb else echo "=== netboot failed ===" fi
board/matrix_vision/mvblm7/mvblm7.c +24 -30
86 lines not on this page · raw message
board/matrix_vision/mvblm7/mvblm7.h +1 -2
@@ -8,14 +8,13 @@#define FPGA_DIN 0x20000000#define FPGA_STATUS 0x10000000#define FPGA_CONF_DONE 0x08000000 -#define MMC_CS 0x04000000#define WD_WDI 0x00400000#define WD_TS 0x00200000#define MAN_RST 0x00100000#define MV_GPIO_DAT (WD_TS) -#define MV_GPIO_OUT (FPGA_CONFIG|FPGA_DIN|FPGA_CCLK|WD_TS|WD_WDI|MMC_CS) +#define MV_GPIO_OUT (FPGA_CONFIG|FPGA_DIN|FPGA_CCLK|MVBLM7_MMC_CS)#define MV_GPIO_ODE (FPGA_CONFIG|MAN_RST)#endif
board/matrix_vision/mvblm7/pci.c +5 -30
@@ -32,24 +32,10 @@#include <fpga.h> #include "mvblm7.h" #include "fpga.h" +#include "../common/mv_common.h" DECLARE_GLOBAL_DATA_PTR ; -int mvblm7_load_fpga (void ) -{ -size_t data_size =0 ; -void *fpga_data =NULL ; -char *datastr =getenv ("fpgadata" ); -char *sizestr =getenv ("fpgadatasize" ); - -if (datastr) - fpga_data = (void *)simple_strtoul (datastr,NULL ,16 ); -if (sizestr) - data_size = (size_t )simple_strtoul (sizestr,NULL ,16 ); - -return fpga_load (0 , fpga_data, data_size); -} -static struct pci_region pci_regions[] = { { bus_start:CONFIG_SYS_PCI1_MEM_BASE ,
@@ -73,10 +59,8 @@ static struct pci_region pci_regions[] = {void pci_init_board (void ) { -char *s;int i;int warmboot; -int load_fpga;volatile immap_t *immr;volatile pcictrl83xx_t *pci_ctrl;volatile gpio83xx_t *gpio;
@@ -84,32 +68,23 @@ void pci_init_board(void)volatile law83xx_t *pci_law;struct pci_region *reg[] = { pci_regions }; - load_fpga =1 ; immr = (immap_t *)CONFIG_SYS_IMMR ; clk = (clk83xx_t *) &immr->clk; pci_ctrl = immr->pci_ctrl; pci_law = immr->sysconf.pcilaw; gpio = (volatile gpio83xx_t *)&immr->gpio[0 ]; - s =getenv ("skip_fpga" ); -if (s) { -printf ("found 'skip_fpga' -> FPGA _not_ loaded !\n" ); - load_fpga =0 ; - } - gpio->dat =MV_GPIO_DAT ; gpio->odr =MV_GPIO_ODE ; -if (load_fpga) - gpio->dir =MV_GPIO_OUT ; -else - gpio->dir =MV_GPIO_OUT & ~(FPGA_DIN |FPGA_CCLK ); + gpio->dir =MV_GPIO_OUT ;printf ("SICRH / SICRL : 0x%08x / 0x%08x\n" , immr->sysconf.sicrh, immr->sysconf.sicrl);mvblm7_init_fpga (); -if (load_fpga) -mvblm7_load_fpga (); +mv_load_fpga (); + + gpio->dir =MV_GPIO_OUT & ~(FPGA_DIN |FPGA_CCLK );/* Enable PCI_CLK_OUTPUTs 0 and 1 with 1:1 clocking */ clk->occr =0xc0000000 ;
include/configs/MVBC_P.h +1 -1
@@ -67,7 +67,7 @@#define MV_CI mvBlueCOUGAR-P#define MV_VCI mvBlueCOUGAR-P#define MV_FPGA_DATA 0xff860000 -#define MV_FPGA_SIZE 0x0003c886 +#define MV_FPGA_SIZE 0#define MV_KERNEL_ADDR 0xffd00000#define MV_INITRD_ADDR 0xff900000#define MV_INITRD_LENGTH 0x00400000
include/configs/MVBLM7.h +20 -29
89 lines not on this page · raw message
MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich
Wolfgang Denk
AppliedPATCH v6 1/1 use common code for Matrix Vision boards
Dear =?ISO-8859-1?Q?Andr=E9?= Schwarz,
Quoted 1 line · In message <1251377315.4053.39.camel@swa-m460> you wrote:
clean up existing boards (mvBC-P/MPC5200 and mvBL-M7/MPC8343) by using common code.
Note (for next time): line too long.
Quoted 6 lines
Signed-off-by Andr? Schwarz <[email protected]>---
Wolfgang,
hopefully this is the last try - I'm close to nervous breakdown.
Why? Just because one patch?
Quoted 1 line
Applying the changes takes longer than actually doing them.
Yeah, that's true.
Quoted 3 lines
Of course this is due to me, I know.
Thanks for your patience,
And yours.
Quoted 9 lines
board/matrix_vision/mvbc_p/mvbc_p.c | 97 +++++---------------> ------ board/matrix_vision/mvbc_p/mvbc_p.h | 2 +- board/matrix_vision/mvbc_p/mvbc_p_autoscript | 10 ++- board/matrix_vision/mvblm7/mvblm7.c | 54 ++++++-------- board/matrix_vision/mvblm7/mvblm7.h | 3 +- board/matrix_vision/mvblm7/pci.c | 35 ++-------- include/configs/MVBC_P.h | 2 +- include/configs/MVBLM7.h | 49 +++++-------- 8 files changed, 77 insertions(+), 175 deletions(-)
Applied. Thanks
Best regards,
Wolfgang Denk
Signature · 7 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de If a packet hits a pocket on a socket on a port, And the bus is interrupted as a very last resort, And the address of the memory makes your floppy disk abort, Then the socket packet pocket has an error to report! - Ken Burchill?
PATCH v6 1/1 use common code for Matrix Vision boards
Quoted 14 lines · On Fri, 28 Aug 2009 00:33:04 +0200 Wolfgang Denk <[email protected]> wrote:
Dear =?ISO-8859-1?Q?Andr=E9?= Schwarz,
Quoted 9 lines · In message <1251377315.4053.39.camel@swa-m460> you wrote:
board/matrix_vision/mvbc_p/mvbc_p.c | 97 +++++---------------> ------ board/matrix_vision/mvbc_p/mvbc_p.h | 2 +- board/matrix_vision/mvbc_p/mvbc_p_autoscript | 10 ++- board/matrix_vision/mvblm7/mvblm7.c | 54 ++++++-------- board/matrix_vision/mvblm7/mvblm7.h | 3 +- board/matrix_vision/mvblm7/pci.c | 35 ++-------- include/configs/MVBC_P.h | 2 +- include/configs/MVBLM7.h | 49 +++++-------- 8 files changed, 77 insertions(+), 175 deletions(-)
Quoted 1 line
Applied. Thanks
and we now have breakage:
Configuring for MVBLM7 board...
pci.c:35:33: error: ../common/mv_common.h: No such file or directory pci.c:35:33: error: ../common/mv_common.h: No such file or directory pci.c: In function 'pci_init_board':
pci.c:85: warning: implicit declaration of function 'mv_load_fpga' mvblm7.c: In function 'misc_init_r':
mvblm7.c:108: warning: implicit declaration of function 'mv_reset_environment' make[1]: *** [pci.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [board/matrix_vision/mvblm7/libmvblm7.a] Error 2
powerpc-linux-gnu-size: './u-boot': No such file
where did mv_common.h go? I can't find it.
Kim
PATCH v6 1/1 use common code for Matrix Vision boards
Dear Kim Phillips,
Quoted 2 lines · In message <[email protected]> you wrote:
and we now have breakage:
Ah. Situation is normal again :-)
Quoted 3 lines
Configuring for MVBLM7 board...
pci.c:35:33: error:../common/mv_common.h: No such file or directory pci.c:35:33: error:../common/mv_common.h: No such file or directory
...
Quoted 2 lines
where did
mv_common.hgo? I can't find it.
Probably a new file that is missing in the patch.
Andr? ???
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de I am a computer. I am dumber than any human and smarter than any ad- ministrator.
PATCH v6 1/1 use common code for Matrix Vision boards
Wolfgang, Kim,
Quoted 7 lines · Wolfgang Denk
Dear Kim Phillips,
Quoted 2 lines · In message <[email protected]> you wrote:
and we now have breakage:
Ah. Situation is normal again :-)
hmpf - it's me again.
Quoted 9 lines
Quoted 4 lines
Configuring for MVBLM7 board...
pci.c:35:33: error:../common/mv_common.h: No such file or directory pci.c:35:33: error:../common/mv_common.h: No such file or directory...
Quoted 2 lines
where did
mv_common.hgo? I can't find it.Probably a new file that is missing in the patch.
board/matrix_vision/common dir is missing completely :-( Something's wrong with my local repo ... branched and merged too often. Looks like I'm missing some (or most) git capabilities.
I'll send a patch against current master in a few minutes.
Regards,
Andr?
Quoted 7 lines
Andr? ???
Best regards,
Wolfgang Denk
MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich