fsl: add register read-back to set_law()
PATCH 2/2 fsl: add register read-back to set_law()
After programming a new LAW, we should read-back the LAWAR register so that we sync the writes. Otherwise, code that attempts to use the new LAW-mapped memory might fail.
--- drivers/misc/fsl_law.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/misc/fsl_law.c +2 -1
@@ -58,7 +58,8 @@ void set_law(u8 idx, phys_addr_t addr, enum law_size sz, enum law_trgt_if id)out_be32 (lawbar, addr >>12 );out_be32 (lawar,LAWAR_EN | ((u32 )id <<20 ) | (u32 )sz); -return ; +/* Read back so that we sync the writes */ +in_be32 (lawar); }int set_next_law (phys_addr_t addr,enum law_size sz,enum law_trgt_if id)
Signature · 1 line
1.6.0.6
PATCH 2/2 fsl: add register read-back to set_law()
Quoted 5 lines · Timur Tabi
After programming a new LAW, we should read-back the LAWAR register so that we sync the writes. ?Otherwise, code that attempts to use the new LAW-mapped memory might fail.
Signed-off-by Timur Tabi <[email protected]>
Just FYI, there is no [PATCH 1/2].
Kumar, this changed appears to fix a real problem on the P4080.
Signature · 2 lines
Timur Tabi Linux kernel developer at Freescale
PATCH 2/2 fsl: add register read-back to set_law()
In reply to Timur TabiQuoted 3 lines · Timur Tabi
After programming a new LAW, we should read-back the LAWAR register so that we sync the writes. ?Otherwise, code that attempts to use the new LAW-mapped memory might fail.
This should say, "code that attempts to use the new LAW-mapped memory right away might fail."
Signature · 2 lines
Timur Tabi Linux kernel developer at Freescale
Kumar Gala
AppliedPATCH 2/2 fsl: add register read-back to set_law()
In reply to Timur TabiQuoted 10 lines · Timur Tabi
After programming a new LAW, we should read-back the LAWAR register so that
we sync the writes. Otherwise, code that attempts to use the new LAW-mapped
memory might fail.Signed-off-by Timur Tabi <[email protected]>---
drivers/misc/fsl_law.c| 3 ++-1 files changed, 2 insertions(+), 1 deletions(-)
Fixed commit wording.
applied to 85xx
- k