Skip to contentSkip to conversation

s3c6410: sdhci: Enable ADMA feature in 6410 sdhci controller.

PATCH New thomas.ab at samsung.com 2 participants 2 messages Sep 8, 2009 – Sep 16, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 4/8 s3c6410: sdhci: Enable ADMA feature in 6410 sdhci controller.

From: Thomas Abraham <[email protected]>

This patch enables ADMA feature in 6410 SDHCI controller driver.

---
 drivers/mmc/host/sdhci-s3c.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)
drivers/mmc/host/sdhci-s3c.c +1 -6
index db1bb93..7f5b64e 100644
@@ -329,12 +329,7 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)
 	host->irq = irq;
 
 	/* Setup quirks for the controller */
-
-	/* Currently with ADMA enabled we are getting some length
-	 * interrupts that are not being dealt with, do disable
-	 * ADMA until this is sorted out. */
-	host->quirks |= SDHCI_QUIRK_BROKEN_ADMA;
-	host->quirks |= SDHCI_QUIRK_32BIT_ADMA_SIZE;
+	host->quirks |= SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC;
 
 #ifndef CONFIG_MMC_SDHCI_S3C_DMA
 
Signature · 1 line
1.5.3.4
maintainer
#1 lore raw

PATCH 4/8 s3c6410: sdhci: Enable ADMA feature in 6410 sdhci controller.

Quoted 4 lines · On Tue, Sep 08, 2009 at 03:52:49PM +0900, [email protected] wrote:

From: Thomas Abraham <[email protected]>

This patch enables ADMA feature in 6410 SDHCI controller driver.

Hmm, surely this wouldn't have wrapped and could have goine onto one line?

Also no signoff.

Quoted 30 lines
---
 drivers/mmc/host/sdhci-s3c.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)
drivers/mmc/host/sdhci-s3c.c +1 -6
index db1bb93..7f5b64e 100644
@@ -329,12 +329,7 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)
 	host->irq = irq;
 
 	/* Setup quirks for the controller */
-
-	/* Currently with ADMA enabled we are getting some length
-	 * interrupts that are not being dealt with, do disable
-	 * ADMA until this is sorted out. */
-	host->quirks |= SDHCI_QUIRK_BROKEN_ADMA;
-	host->quirks |= SDHCI_QUIRK_32BIT_ADMA_SIZE;
+	host->quirks |= SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC;
 
 #ifndef CONFIG_MMC_SDHCI_S3C_DMA
 
Signature · 7 lines
1.5.3.4


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 5 lines
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.