Skip to contentSkip to conversation

X86: pci quirks, fix pci refcounting

PATCH Applied Jiri Slaby 2 participants 2 messages Sep 8, 2009 – Sep 9, 2009

Subsystems (2)
lore
Share & tools
lore

Jiri Slaby

author
#0 lore raw

PATCH 1/1 X86: pci quirks, fix pci refcounting

Stanse found a pci reference leak in quirk_amd_nb_node. Instead of putting nb_ht, there is a put of dev passed as an argument.

http://stanse.fi.muni.cz/

---
 arch/x86/kernel/quirks.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/quirks.c +1 -1
index af71d06..6c3b2c6 100644
@@ -508,7 +508,7 @@ static void __init quirk_amd_nb_node(struct pci_dev *dev)
 
 	pci_read_config_dword(nb_ht, 0x60, &val);
 	set_dev_node(&dev->dev, val & 7);
-	pci_dev_put(dev);
+	pci_dev_put(nb_ht);
 }
 
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_K8_NB,
Signature · 1 line
1.6.3.3
Applied
#1 lore raw
Quoted 5 lines · On Tue, 8 Sep 2009 12:16:18 +0200 Jiri Slaby <[email protected]> wrote:

Stanse found a pci reference leak in quirk_amd_nb_node. Instead of putting nb_ht, there is a put of dev passed as an argument.

http://stanse.fi.muni.cz/

Applied to linux-next, thanks.

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center