Skip to contentSkip to conversation

muas3001: remove BRG clock node fixup to use common mpc8260 code.

PATCH Superseded Marcel Ziswiler 3 participants 4 messages Sep 8, 2009 – Sep 10, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 muas3001: remove BRG clock node fixup to use common mpc8260 code.

---
 board/muas3001/muas3001.c |   16 ----------------
 1 files changed, 0 insertions(+), 16 deletions(-)
board/muas3001/muas3001.c +0 -16
index 8f83dd9..bf4ccb6 100644
@@ -310,7 +310,6 @@ void ft_blob_update (void *blob, bd_t *bd)
 	int ret, nodeoffset = 0;
 	ulong memory_data[2] = {0};
 	ulong flash_data[4] = {0};
-	ulong freq = 0;
 	ulong	speed = 0;
 
 	memory_data[0] = cpu_to_be32 (bd->bi_memstart);
@@ -359,21 +358,6 @@ void ft_blob_update (void *blob, bd_t *bd)
 			"err:%s\n", fdt_strerror (nodeoffset));
 	}
 
-	/* brg clock */
-	nodeoffset = fdt_path_offset (blob, "/soc/cpm/brg");
-	if (nodeoffset >= 0) {
-		freq = cpu_to_be32 (bd->bi_brgfreq);
-		ret = fdt_setprop (blob, nodeoffset, "clock-frequency", &freq,
-					sizeof (unsigned long));
-	if (ret < 0)
-		printf ("ft_blob_update): cannot set /soc/cpm/brg/clock-frequency "
-			"property err:%s\n", fdt_strerror (ret));
-	} else {
-		/* memory node is required in dts */
-		printf ("ft_blob_update(): cannot find /soc/cpm/brg/clock-frequency node "
-			"err:%s\n", fdt_strerror (nodeoffset));
-	}
-
 	/* baudrate */
 	nodeoffset = fdt_path_offset (blob, "/soc/cpm/serial");
 	if (nodeoffset >= 0) {
Signature · 1 line
1.6.0.4
#1 lore raw

PATCH 1/1 muas3001: remove BRG clock node fixup to use common mpc8260 code.

Hello Marcel,

Quoted 4 lines · Marcel Ziswiler
---
 board/muas3001/muas3001.c |   16 ----------------
 1 files changed, 0 insertions(+), 16 deletions(-)

Unfortunately, I don;t have anymore access to this board, but your patch looks good to me, so:

bye
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#2 lore raw

PATCH v2 1/1 muas3001: remove BRG clock node fixup to use common mpc8260 code.

In reply to Marcel Ziswiler

---
Changes since v1:
- Added Heiko's ack

 board/muas3001/muas3001.c |   16 ----------------
 1 files changed, 0 insertions(+), 16 deletions(-)
board/muas3001/muas3001.c +0 -16
index 8f83dd9..bf4ccb6 100644
@@ -310,7 +310,6 @@ void ft_blob_update (void *blob, bd_t *bd)
 	int ret, nodeoffset = 0;
 	ulong memory_data[2] = {0};
 	ulong flash_data[4] = {0};
-	ulong freq = 0;
 	ulong	speed = 0;
 
 	memory_data[0] = cpu_to_be32 (bd->bi_memstart);
@@ -359,21 +358,6 @@ void ft_blob_update (void *blob, bd_t *bd)
 			"err:%s\n", fdt_strerror (nodeoffset));
 	}
 
-	/* brg clock */
-	nodeoffset = fdt_path_offset (blob, "/soc/cpm/brg");
-	if (nodeoffset >= 0) {
-		freq = cpu_to_be32 (bd->bi_brgfreq);
-		ret = fdt_setprop (blob, nodeoffset, "clock-frequency", &freq,
-					sizeof (unsigned long));
-	if (ret < 0)
-		printf ("ft_blob_update): cannot set /soc/cpm/brg/clock-frequency "
-			"property err:%s\n", fdt_strerror (ret));
-	} else {
-		/* memory node is required in dts */
-		printf ("ft_blob_update(): cannot find /soc/cpm/brg/clock-frequency node "
-			"err:%s\n", fdt_strerror (nodeoffset));
-	}
-
 	/* baudrate */
 	nodeoffset = fdt_path_offset (blob, "/soc/cpm/serial");
 	if (nodeoffset >= 0) {
Signature · 1 line
1.6.4.2
#3 lore raw

PATCH v2 1/1 muas3001: remove BRG clock node fixup to use common mpc8260 code.

Dear Marcel Ziswiler,

Quoted 8 lines · In message <1252523478.3643.4.camel@com-21> you wrote:

---
Changes since v1:
- Added Heiko's ack

 board/muas3001/muas3001.c |   16 ----------------
 1 files changed, 0 insertions(+), 16 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Stupidity, like virtue, is its own reward"     - William E. Davidsen