drm/radeon/kms: Don't try to process irq when we are unloading
Subsystems (2)
PATCH 1/1 drm/radeon/kms: Don't try to process irq when we are unloading
If module is being unloaded we should not try to handle irq especialy we should not call into drm helper or we could hard hang the computer free_irq will call the irq handler to make sure we behave properly.
Signed-off-by Jerome Glisse <[email protected]>
--- drivers/gpu/drm/radeon/r100.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/gpu/drm/radeon/r100.c +3 -0
@@ -319,6 +319,9 @@ int r100_irq_process(struct radeon_device *rdev)if (!status) {return IRQ_NONE ; } +if (rdev->shutdown) { +return IRQ_NONE ; + }while (status) {/* SW interrupt */ if (status &RADEON_SW_INT_TEST ) {
Signature · 1 line
1.6.4.1
Quoted 3 lines · Jerome Glisse
If module is being unloaded we should not try to handle irq especialy we should not call into drm helper or we could hard hang the computer
free_irqwill call the irq handler to make sure we behave properly.
Should you not just ack all irqs here before returning, else we'll just get called again.
Dave.
Quoted 21 lines
Signed-off-by Jerome Glisse <[email protected]>--- drivers/gpu/drm/radeon/r100.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)drivers/gpu/drm/radeon/r100.c +3
-0@@ -319,6 +319,9 @@ int r100_irq_process(struct radeon_device *rdev)if (!status) {return IRQ_NONE ; } +if (rdev->shutdown) { +return IRQ_NONE ; + }while (status) {/* SW interrupt */ if (status &RADEON_SW_INT_TEST ) {