UWB Kconfig: cannot set UWB to N in gconfig
I sometimes use 'make gconfig' and I noticed that I cannot disable the UWB option -- it just won't let me set it to N.
AFAICT this is because the CONFIG USB_WUSB selects UWB which forces it on.
applying this patch fixes the issue but I'm not sure if this is the right way to go about it.
any thoughts?
regards
Richard
This is against 2.6.31
drivers/usb/wusbcore/Kconfig +1 -1
@@ -5,7 +5,7 @@ config USB_WUSB tristate "Enable Wireless USB extensions (EXPERIMENTAL)" depends on EXPERIMENTAL depends on USB - select UWB + depends on UWB select CRYPTO select CRYPTO_BLKCIPHER select CRYPTO_CBC
Quoted 2 lines · On Thu, 10 Sep 2009 11:05:54 +0100 Richard Kennedy wrote:
I sometimes use 'make gconfig' and I noticed that I cannot disable the UWB option -- it just won't let me set it to N.
Not specific to 'gconfig'.
Quoted 2 lines
AFAICT this is because the CONFIG
USB_WUSBselects UWB which forces it on.
Yes.
Quoted 4 lines
applying this patch fixes the issue but I'm not sure if this is the right way to go about it.
any thoughts?
UWB can be disabled by disabling both of these options that are several entries below it in the same menu:
USB_WHCI_HCD and USB_HWA_HCD
and then returning to UWB and disabling it.
Should users have to figure that out? no.
Quoted 8 lines
This is against 2.6.31
drivers/usb/wusbcore/Kconfig +0
-0
drivers/usb/wusbcore/Kconfig config USB_WUSB · line 11
Quoted 8 lines
drivers/usb/wusbcore/Kconfig +1
-1@@ -5,7 +5,7 @@ config USB_WUSB tristate "Enable Wireless USB extensions (EXPERIMENTAL)" depends on EXPERIMENTAL depends on USB - select UWB + depends on UWB select CRYPTO select CRYPTO_BLKCIPHER select CRYPTO_CBC
use tabs, not spaces.
---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
Quoted 17 lines · Randy Dunlap
Quoted 2 lines · On Thu, 10 Sep 2009 11:05:54 +0100 Richard Kennedy wrote:
I sometimes use 'make gconfig' and I noticed that I cannot disable the UWB option -- it just won't let me set it to N.
Not specific to 'gconfig'.
Quoted 2 lines
AFAICT this is because the CONFIG
USB_WUSBselects UWB which forces it on.Yes.
Quoted 4 lines
applying this patch fixes the issue but I'm not sure if this is the right way to go about it.
any thoughts?
Quoted 9 lines
UWB can be disabled by disabling both of these options that are several entries below it in the same menu:
USB_WHCI_HCDandUSB_HWA_HCDand then returning to UWB and disabling it.
Should users have to figure that out? no.
thanks,
although it's not easy to figure out how to disable this in gconfig. USB_WHCI_HCD & USB_HWA_HCD end up under a different menu (drivers/usb/host).
If you don't know that they exist, all you see is the options under UWB set to M and gconfig doesn't let you turn them off.
Here's another version of the patch that changes them all to 'depends on'. This lets gconfig do the right thing :)
regards
Richard
drivers/usb/host/Kconfig +4 -4
@@ -347,8 +347,8 @@ config USB_WHCI_HCD tristate "Wireless USB Host Controller Interface (WHCI) driver (EXPERIMENTAL)" depends on EXPERIMENTAL depends on PCI && USB - select USB_WUSB - select UWB_WHCI + depends on USB_WUSB + depends on UWB_WHCI help A driver for PCI-based Wireless USB Host Controllers that are compliant with the WHCI specification.
@@ -360,8 +360,8 @@ config USB_HWA_HCD tristate "Host Wire Adapter (HWA) driver (EXPERIMENTAL)" depends on EXPERIMENTAL depends on USB - select USB_WUSB - select UWB_HWA + depends on USB_WUSB + depends on UWB_HWA help This driver enables you to connect Wireless USB devices to your system using a Host Wire Adaptor USB dongle. This is an
drivers/usb/wusbcore/Kconfig +1 -1
@@ -5,7 +5,7 @@ config USB_WUSB tristate "Enable Wireless USB extensions (EXPERIMENTAL)" depends on EXPERIMENTAL depends on USB - select UWB + depends on UWB select CRYPTO select CRYPTO_BLKCIPHER select CRYPTO_CBC
Quoted 21 lines · Richard Kennedy
I sometimes use 'make gconfig' and I noticed that I cannot disable the UWB option -- it just won't let me set it to N.
AFAICT this is because the CONFIG
USB_WUSBselects UWB which forces it on.
applying this patch fixes the issue but I'm not sure if this is the right way to go about it.any thoughts?
regards
RichardThis is against 2.6.31
drivers/usb/wusbcore/Kconfig +0
-0
drivers/usb/wusbcore/Kconfig config USB_WUSB · line 8
Quoted 5 lines
drivers/usb/wusbcore/Kconfig +1
-1@@ -5,7 +5,7 @@ config USB_WUSB tristate "Enable Wireless USB extensions (EXPERIMENTAL)" depends on EXPERIMENTAL depends on USB - select UWB + depends on UWB
NAK. It's not sufficiently obvious to a user that Wireless USB support requires UWB.
This is really an issue with the configuration application. Consider improving them to allow switching off select'ed options and popping up a dialog that says "switching off UWB will also switch off WUSB" etc.
David
Signature · 6 lines
David Vrabel, Senior Software Engineer, Drivers CSR, Churchill House, Cambridge Business Park, Tel: +44 (0)1223 692562 Cowley Road, Cambridge, CB4 0WZ http://www.csr.com/ Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom