Skip to contentSkip to conversation

bluez-gnome: Fix crash on pairing request of known rfcomm device

PATCH In review Stanislav Brabec 2 participants 2 messages Sep 10, 2009 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bluez-gnome: Fix crash on pairing request of known rfcomm device

Attached patch fixes crash after access attempt to the device configured in rfcomm.conf, but not yet paired.

How to reproduce:

1. Configure an unknown RFCOMM device that requires authentication in rfcomm.conf (e. g. mobile phone).
2. run pppd on /dev/rfcomm1

Behavior:
- Pairing request on mobile phone
- Crash of bluetooth-applet on desktop

The patch fixes only the crash, not the error completely (at least in version 1.8). Behavior after the fix:
- Pairing request on mobile phone, then ask for PIN
- No reaction on desktop

common/bluetooth-client.c +1 -1
Index: bluez-gnome-1.8/common/bluetooth-client.c
===================================================================
@@ -330,7 +330,7 @@ static void add_device(DBusGProxy *adapt
 		name = value ? g_value_get_string(value) : NULL;
 
 		value = g_hash_table_lookup(hash, "Class");
-		type = class_to_type(g_value_get_uint(value));
+		type = value ? class_to_type(g_value_get_uint(value)) : BLUETOOTH_TYPE_ANY;
 
 		value = g_hash_table_lookup(hash, "Icon");
 		icon = value ? g_value_get_string(value) : "bluetooth";
Signature · 9 lines
Best Regards / S pozdravem,

Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o.                          e-mail: [email protected]
Lihovarská 1060/12           tel: +420 284 028 966, +49 911 740538747
190 00 Praha 9                                  fax: +420 284 028 951
Czech Republic                                    http://www.suse.cz/
#1 lore raw
Quoted 9 lines · Stanislav Brabec

Attached patch fixes crash after access attempt to the device configured in rfcomm.conf, but not yet paired.

How to reproduce:

1. Configure an unknown RFCOMM device that requires authentication in rfcomm.conf (e. g. mobile phone).
2. run pppd on /dev/rfcomm1

Quoted 8 lines

Behavior:
- Pairing request on mobile phone
- Crash of bluetooth-applet on desktop

The patch fixes only the crash, not the error completely (at least in version 1.8). Behavior after the fix:
- Pairing request on mobile phone, then ask for PIN
- No reaction on desktop

Fixed the same bug in gnome-bluetooth.

Cheers