Skip to contentSkip to conversation

ppp: ppp_generic.c initialize flen before it get used

PATCH In review Jaswinder Singh Rajput 2 participants 2 messages Sep 12, 2009 – Sep 13, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ppp: ppp_generic.c initialize flen before it get used

When while loop runs first time flen is used uninitialized for nfree <= 0

This also fixed compilation warning :
CC [M] drivers/net/ppp_generic.o
drivers/net/ppp_generic.c: In function ‘ppp_mp_explode’:
drivers/net/ppp_generic.c:1314: warning: ‘flen’ may be used uninitialized in this function

---
 drivers/net/ppp_generic.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/ppp_generic.c +1 -1
index cd37d73..b1a1a06 100644
@@ -1311,7 +1311,7 @@ static int ppp_mp_explode(struct ppp *ppp, struct sk_buff *skb)
 {
 	int	len, totlen;
 	int	i, bits, hdrlen, mtu;
-	int	flen;
+	int	flen = 0;
 	int	navail,	nfree, nzero;
 	int	nbigger;
 	int	totspeed;
Signature · 1 line
1.6.4.2
maintainer
#1 lore raw

Already dealt with in net-next-2.6, please act against the active networking development trees when fixing warnings and doing cleanups.

Thank you.

commit 886f9fe68310168358f55028a03553ae154dfeb6

Author: David S. Miller <[email protected]>
Date:   Wed Aug 19 13:55:55 2009 -0700

ppp_generic: Help GCC see that 'flen' is always initialized.

It's too stupid to see that we always set flen to something before we use it in ppp_mp_explode():

drivers/net/ppp_generic.c: In function 'ppp_push':
drivers/net/ppp_generic.c:1314: warning: 'flen' may be used uninitialized in this function drivers/net/ppp_generic.c:1314: note: 'flen' was declared here

This started warning after commit a53a8b56827cc429c6d9f861ad558beeb5f6103f ("ppp: fix lost fragments in ppp_mp_explode() (resubmit)")

So just put an explicit unconditional initialization there to hush it up.