Skip to contentSkip to conversation

perf_counter: fix buffer overflow in perf_copy_attr()

PATCH In review Xiao Guangrong 3 participants 4 messages Sep 15, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf_counter: fix buffer overflow in perf_copy_attr()

If we pass a big size data over perf_counter_open syscall, the kernel will copy this data to a small buffer, It will cause kernel crash.

This bug make kernel unsafe and no-root user can trigger it.

---
 kernel/perf_counter.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
kernel/perf_counter.c +1 -0
index 667ab25..75c46c0 100644
@@ -4216,6 +4216,7 @@ static int perf_copy_attr(struct perf_counter_attr __user *uattr,
 			if (val)
 				goto err_size;
 		}
+		size = sizeof(*attr);
 	}
 
 	ret = copy_from_user(attr, uattr, size);
Signature · 1 line
1.6.1.2
Acked-by on v1 1/1
#1 lore raw
Quoted 15 lines · Xiao Guangrong

If we pass a big size data over perf_counter_open syscall, the kernel will copy this data to a small buffer, It will cause kernel crash.

This bug make kernel unsafe and no-root user can trigger it.

---
 kernel/perf_counter.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
kernel/perf_counter.c +0 -0
index 667ab25..75c46c0 100644

kernel/perf_counter.c static int perf_copy_attr(struct perf_counter_attr __user *uattr, · line 4219

Quoted 4 lines
kernel/perf_counter.c +1 -0
@@ -4216,6 +4216,7 @@ static int perf_copy_attr(struct perf_counter_attr __user *uattr,
 			if (val)
 				goto err_size;
 		}
+		size = sizeof(*attr);

Looks right to me.

Acked-by on v1 1/1
#2 lore raw
In reply to Xiao Guangrong
Quoted 4 lines · Xiao Guangrong

If we pass a big size data over perf_counter_open syscall, the kernel will copy this data to a small buffer, It will cause kernel crash.

This bug make kernel unsafe and no-root user can trigger it.

Ah, indeed. Thanks!

Quoted 17 lines
---
 kernel/perf_counter.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
kernel/perf_counter.c +1 -0
index 667ab25..75c46c0 100644
@@ -4216,6 +4216,7 @@ static int perf_copy_attr(struct perf_counter_attr __user *uattr,
 			if (val)
 				goto err_size;
 		}
+		size = sizeof(*attr);
 	}
 
 	ret = copy_from_user(attr, uattr, size);
#3 lore raw

[tip:perfcounters/urgent] perf_counter: Fix buffer overflow in perf_copy_attr()

In reply to Xiao Guangrong
Commit-ID:  b3e62e35058fc744ac794611f4e79bcd1c5a4b83
Gitweb:     http://git.kernel.org/tip/b3e62e35058fc744ac794611f4e79bcd1c5a4b83
Author:     Xiao Guangrong <[email protected]>
AuthorDate: Tue, 15 Sep 2009 14:44:36 +0800
Committer:  Ingo Molnar <[email protected]>
CommitDate: Tue, 15 Sep 2009 09:53:31 +0200

perf_counter: Fix buffer overflow in perf_copy_attr()

If we pass a big size data over perf_counter_open() syscall, the kernel will copy this data to a small buffer, it will cause kernel crash.

This bug makes the kernel unsafe and non-root local user can trigger it.

LKML-Reference: <[email protected]>

---
 kernel/perf_counter.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
kernel/perf_counter.c +1 -0
index d7cbc57..a67a1dc 100644
@@ -4171,6 +4171,7 @@ static int perf_copy_attr(struct perf_counter_attr __user *uattr,
 			if (val)
 				goto err_size;
 		}
+		size = sizeof(*attr);
 	}
 
 	ret = copy_from_user(attr, uattr, size);