Skip to contentSkip to conversation

S3C64XX I2S: S3C64XX_PA_IISV4 defined

PATCH New Jassi 4 participants 5 messages Sep 15, 2009 – Sep 16, 2009

Subsystems (2)
lore
Share & tools
lore

Jassi

author
#0 lore raw

PATCH 1/10 S3C64XX I2S: S3C64XX_PA_IISV4 defined

Defined the missing S3C64XX_PA_IISV4 conditionally for 6410 as it's not avaialble for 6400

---
 arch/arm/mach-s3c6400/include/mach/map.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/mach-s3c6400/include/mach/map.h +3 -0
index 5057d99..775577a 100644
@@ -44,6 +44,9 @@
 #define S3C64XX_PA_SYSCON	(0x7E00F000)
 #define S3C64XX_PA_IIS0		(0x7F002000)
 #define S3C64XX_PA_IIS1		(0x7F003000)
+#ifdef CONFIG_CPU_S3C6410
+#define S3C64XX_PA_IISV4	(0x7F00D000)
+#endif
 #define S3C64XX_PA_TIMER	(0x7F006000)
 #define S3C64XX_PA_IIC0		(0x7F004000)
 #define S3C64XX_PA_IIC1		(0x7F00F000)
Signature · 1 line
1.6.2.5
#1 lore raw

PATCH 1/10 S3C64XX I2S: S3C64XX_PA_IISV4 defined

arch/arm/mach-s3c6400/include/mach/map.h line 49

Quoted 9 lines · Jassi

Defined the missing S3C64XX_PA_IISV4 conditionally for 6410 as it's not avaialble for 6400

#define S3C64XX_PA_IIS1 (0x7F003000)

arch/arm/mach-s3c6400/include/mach/map.h +3 -0
+#ifdef CONFIG_CPU_S3C6410
+#define S3C64XX_PA_IISV4	(0x7F00D000)
+#endif

I'm not sure what the roadmap for future CPUs looks like but might this better done with the inverse test so we don't have to add every single new CPU to the ifdefs. TBH I'm not sure if the ifdefs are worth it.

#2 lore raw

PATCH 1/10 S3C64XX I2S: S3C64XX_PA_IISV4 defined

In reply to Jassi
Quoted 13 lines · Jassi

Defined the missing S3C64XX_PA_IISV4 conditionally for 6410 as it's not avaialble for 6400

---
 arch/arm/mach-s3c6400/include/mach/map.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/mach-s3c6400/include/mach/map.h +0 -0
index 5057d99..775577a 100644

arch/arm/mach-s3c6400/include/mach/map.h line 49

Quoted 6 lines
arch/arm/mach-s3c6400/include/mach/map.h +3 -0
@@ -44,6 +44,9 @@
 #define S3C64XX_PA_SYSCON	(0x7E00F000)
 #define S3C64XX_PA_IIS0		(0x7F002000)
 #define S3C64XX_PA_IIS1		(0x7F003000)
+#ifdef CONFIG_CPU_S3C6410
+#define S3C64XX_PA_IISV4	(0x7F00D000)
+#endif

Does this really need to be #ifdef'd out? You might want to avoid building the device setup code, or similar if it is only for a s3c6400 but this should be done by the machine Kconfig chosing to build the support in for the machines that do need it.

I see no good reason for this to be applied.

Quoted 3 lines
arch/arm/mach-s3c6400/include/mach/map.h +0 -0
 #define S3C64XX_PA_TIMER	(0x7F006000)
 #define S3C64XX_PA_IIC0		(0x7F004000)
 #define S3C64XX_PA_IIC1		(0x7F00F000)
Signature · 4 lines
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.
#3 lore raw

PATCH 1/10 S3C64XX I2S: S3C64XX_PA_IISV4 defined

Quoted 26 lines · Ben Dooks
Quoted 13 lines · Jassi

Defined the missing S3C64XX_PA_IISV4 conditionally for 6410 as it's not avaialble for 6400

---
?arch/arm/mach-s3c6400/include/mach/map.h | ? ?3 +++ ?1 files changed, 3 insertions(+), 0 deletions(-)

arch/arm/mach-s3c6400/include/mach/map.h +0 -0
index 5057d99..775577a 100644

arch/arm/mach-s3c6400/include/mach/map.h line 49

Quoted 6 lines
arch/arm/mach-s3c6400/include/mach/map.h +3 -0
@@ -44,6 +44,9 @@
 ?#define S3C64XX_PA_SYSCON ? ?(0x7E00F000)
 ?#define S3C64XX_PA_IIS0 ? ? ? ? ? ? ?(0x7F002000)
 ?#define S3C64XX_PA_IIS1 ? ? ? ? ? ? ?(0x7F003000)
+#ifdef CONFIG_CPU_S3C6410
+#define S3C64XX_PA_IISV4 ? ? (0x7F00D000)
+#endif

Does this really need to be #ifdef'd out? You might want to avoid building the device setup code, or similar if it is only for a s3c6400 but this should be done by the machine Kconfig chosing to build the support in for the machines that do need it.

Quoted 1 line

I see no good reason for this to be applied.

In my second post in this thread, i already said the ifdef had better be dropped.
So, you want me to resend patch without the ifdef?

#4 lore raw

PATCH 1/10 S3C64XX I2S: S3C64XX_PA_IISV4 defined

Quoted 27 lines · jassi brar
Quoted 26 lines · Ben Dooks
Quoted 13 lines · Jassi

Defined the missing S3C64XX_PA_IISV4 conditionally for 6410 as it's not avaialble for 6400

---
?arch/arm/mach-s3c6400/include/mach/map.h | ? ?3 +++ ?1 files changed, 3 insertions(+), 0 deletions(-)

arch/arm/mach-s3c6400/include/mach/map.h +0 -0
index 5057d99..775577a 100644

arch/arm/mach-s3c6400/include/mach/map.h line 49

Quoted 6 lines
arch/arm/mach-s3c6400/include/mach/map.h +3 -0
@@ -44,6 +44,9 @@
 ?#define S3C64XX_PA_SYSCON ? ?(0x7E00F000)
 ?#define S3C64XX_PA_IIS0 ? ? ? ? ? ? ?(0x7F002000)
 ?#define S3C64XX_PA_IIS1 ? ? ? ? ? ? ?(0x7F003000)
+#ifdef CONFIG_CPU_S3C6410
+#define S3C64XX_PA_IISV4 ? ? (0x7F00D000)
+#endif

Does this really need to be #ifdef'd out? You might want to avoid building the device setup code, or similar if it is only for a s3c6400 but this should be done by the machine Kconfig chosing to build the support in for the machines that do need it.

Quoted 4 lines
Quoted 1 line

I see no good reason for this to be applied.

In my second post in this thread, i already said the ifdef had better be dropped.
So, you want me to resend patch without the ifdef?

Yes. remove #ifdef.

Signature · 4 lines
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.