md: set the md raid 4,5,6 thead name by its level
PATCH 1/1 md: set the md raid 4,5,6 thead name by its level
the current edition, if you create a md raid 4,5,6 the name of md thread is mdx_raid5. If you create a raid 4,6 the name mdx_raid4, mdx_raid6 are better than mdx_raid5.
--- drivers/md/raid5.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-)
drivers/md/raid5.c +5 -2
@@ -4334,6 +4334,7 @@ static raid5_conf_t *setup_conf(mddev_t *mddev)int raid_disk, memory;mdk_rdev_t *rdev;struct disk_info *disk; +char thread_name[64 ];if (mddev->new_level !=5 && mddev->new_level != 4
@@ -4447,10 +4448,12 @@ static raid5_conf_t *setup_conf(mddev_t *mddev)printk (KERN_INFO "raid5: allocated %dkB for %s\n" , memory,mdname (mddev)); - conf->thread =md_register_thread (raid5d, mddev,"%s_raid5" ); +sprintf (thread_name,"%%s_raid%d" , conf->level); + conf->thread =md_register_thread (raid5d, mddev, thread_name); +if (!conf->thread) {printk (KERN_ERR -"raid5: couldn't allocate thread for %s\n" , +"raid%d: couldn't allocate thread for %s\n" , conf->level,mdname (mddev)); goto abort; }
Signature · 1 line
1.6.1.3
Quoted 3 lines · On Wednesday September 16, [email protected] wrote:
the current edition, if you create a md raid 4,5,6 the name of md thread is
mdx_raid5. If you create a raid 4,6 the namemdx_raid4,mdx_raid6are better thanmdx_raid5.
Thanks for the suggestion and the patch.
I would like to achieve the same thing a little differently. Primarily I am using the personality name rather than combining the level number with "raid". The result is the same.
See below.
Thanks,
NeilBrown
From: NeilBrown <[email protected]>
Date: Thu, 17 Sep 2009 11:34:57 +1000
Subject: [PATCH] md: Improve name of threads created by md_register_thread
The management thread for raid4,5,6 arrays are all called mdX_raid5, independent of the actual raid level, which is wrong and can be confusion.
So change md_register_thread to use the name from the personality unless no alternate name (like 'resync' or 'reshape') is given.
This is simpler and more correct.
--- drivers/md/md.c | 9 ++++++--- drivers/md/multipath.c | 2 +- drivers/md/raid1.c | 2 +- drivers/md/raid10.c | 2 +- drivers/md/raid5.c | 6 +++--- 5 files changed, 12 insertions(+), 9 deletions(-)
drivers/md/md.c +6 -3
@@ -4371,7 +4371,7 @@ static int do_md_run(mddev_t * mddev)set_bit (MD_RECOVERY_RUNNING , &mddev->recovery); mddev->sync_thread =md_register_thread (md_do_sync, mddev, -"%s_resync" ); +"resync" );if (!mddev->sync_thread) { printk(KERN_ERR "%s: could not start resync" " thread...\n",
@@ -5784,7 +5784,10 @@ mdk_thread_t *md_register_thread(void (*run) (mddev_t *), mddev_t *mddev, thread->run = run; thread->mddev = mddev; thread->timeout =MAX_SCHEDULE_TIMEOUT ; - thread->tsk =kthread_run (md_thread, thread, name,mdname (thread->mddev)); + thread->tsk =kthread_run (md_thread, thread, +"%s_%s" , +mdname (thread->mddev), + name ?: mddev->pers->name);if (IS_ERR (thread->tsk)) {kfree (thread);return NULL ;
@@ -6898,7 +6901,7 @@ void md_check_recovery(mddev_t *mddev) } mddev->sync_thread =md_register_thread (md_do_sync, mddev, -"%s_resync" ); +"resync" );if (!mddev->sync_thread) { printk(KERN_ERR "%s: could not start resync" " thread...\n",
drivers/md/multipath.c +1 -1
@@ -503,7 +503,7 @@ static int multipath_run (mddev_t *mddev) } { - mddev->thread =md_register_thread (multipathd, mddev,"%s_multipath" ); + mddev->thread =md_register_thread (multipathd, mddev,NULL );if (!mddev->thread) {printk (KERN_ERR "multipath: couldn't allocate thread" " for %s\n" ,mdname (mddev));
drivers/md/raid1.c +1 -1
@@ -2045,7 +2045,7 @@ static int run(mddev_t *mddev) conf->last_used = j; - mddev->thread =md_register_thread (raid1d, mddev,"%s_raid1" ); + mddev->thread =md_register_thread (raid1d, mddev,NULL );if (!mddev->thread) { printk(KERN_ERR "raid1: couldn't allocate thread for %s\n",
drivers/md/raid10.c +1 -1
@@ -2188,7 +2188,7 @@ static int run(mddev_t *mddev) } - mddev->thread =md_register_thread (raid10d, mddev,"%s_raid10" ); + mddev->thread =md_register_thread (raid10d, mddev,NULL );if (!mddev->thread) { printk(KERN_ERR "raid10: couldn't allocate thread for %s\n",
drivers/md/raid5.c +3 -3
@@ -4448,7 +4448,7 @@ static raid5_conf_t *setup_conf(mddev_t *mddev)printk (KERN_INFO "raid5: allocated %dkB for %s\n" , memory,mdname (mddev)); - conf->thread =md_register_thread (raid5d, mddev,"%s_raid5" ); + conf->thread =md_register_thread (raid5d, mddev,NULL );if (!conf->thread) { printk(KERN_ERR "raid5: couldn't allocate thread for %s\n",
@@ -4614,7 +4614,7 @@ static int run(mddev_t *mddev)set_bit (MD_RECOVERY_RESHAPE , &mddev->recovery);set_bit (MD_RECOVERY_RUNNING , &mddev->recovery); mddev->sync_thread =md_register_thread (md_do_sync, mddev, -"%s_reshape" ); +"reshape" ); }/* read-ahead size must cover two whole stripes, which is
@@ -5032,7 +5032,7 @@ static int raid5_start_reshape(mddev_t *mddev)set_bit (MD_RECOVERY_RESHAPE , &mddev->recovery);set_bit (MD_RECOVERY_RUNNING , &mddev->recovery); mddev->sync_thread =md_register_thread (md_do_sync, mddev, -"%s_reshape" ); +"reshape" );if (!mddev->sync_thread) { mddev->recovery =0 ;spin_lock_irq (&conf->device_lock);
Signature · 1 line
1.6.3.3