AMD64_EDAC: simple fix to allow better report on ECE CE errors
Subsystems (2)
PATCH 1/1 AMD64_EDAC: simple fix to allow better report on ECE CE errors
I tested 2.6.31 and the mainline amd64_edac driver. This is was the first simple fix.
This allows the errors to be further decoded and mapped to csrows. Tested with ECC debug dimms and an Rev F cpu based system.
---
drivers/edac/amd64_edac.c +1 -1
@@ -1136,7 +1138,7 @@* different from the node that detected the error. */ src_mci =find_mc_by_sys_addr (mci, SystemAddress); -if (src_mci) { +if (!src_mci) {amd64_mc_printk (mci,KERN_ERR ,"failed to map error address 0x%lx to a node\n" , (unsigned long )SystemAddress);
Hi Keith,
Quoted 7 lines · Keith Mannthey
I tested 2.6.31 and the mainline
amd64_edacdriver. This is was the first simple fix.This allows the errors to be further decoded and mapped to csrows. Tested with ECC debug dimms and an Rev F cpu based system.
Submitted-by Keith Mannthey<[email protected]>
Thanks, applied. By the way, the tagging is not 'Submitted-by' but 'Signed-off-by' - I've corrected it accordingly. Please consult <Documentation/SubmittingPatches> for more details on how to prepare your patches.
Quoted 3 lines
---
diff -urN
linux-2.6.31/drivers/edac/amd64_edac.clinux-2.6.31-fixed/drivers/edac/amd64_edac.c
Add the -p option when creating the diffs so that it is visible which function you're editing.
Quoted 14 lines
drivers/edac/amd64_edac.c +1
-1@@ -1136,7 +1138,7 @@* different from the node that detected the error. */ src_mci =find_mc_by_sys_addr (mci, SystemAddress); -if (src_mci) { +if (!src_mci) {amd64_mc_printk (mci,KERN_ERR ,"failed to map error address 0x%lx to a node\n" , (unsigned long )SystemAddress);
Signature · 8 lines
Regards/Gruss, Boris. Operating | Advanced Micro Devices GmbH System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany Research | Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München (OSRC) | Registergericht München, HRB Nr. 43632