Skip to contentSkip to conversation

interrupt remapping: Disallow interrupt remapping if not all ioapic under interrupt remapping

PATCH In review Youquan Song 4 participants 6 messages Sep 7, 2009 – Sep 19, 2009 PCI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 interrupt remapping: Disallow interrupt remapping if not all ioapic under interrupt remapping

Current kernel enable interrupt remapping only when all the vt-d unit support interrupt remapping. So it is reasonable we should also disallow enabling intr-remapping if there any io-apics that are not listed under vt-d units. Otherwise we can run into issues.

---

drivers/pci/dmar.c +0 -3
index 7b287cb..a8a4383 100644
@@ -570,9 +570,6 @@ int __init dmar_table_init(void)
 		printk(KERN_INFO PREFIX "No ATSR found\n");
 #endif
 
-#ifdef CONFIG_INTR_REMAP
-	parse_ioapics_under_ir();
-#endif
 	return 0;
 }
 
drivers/pci/intr_remapping.c +5 -0
index 4f5b871..ebfa47b 100644
@@ -626,6 +626,11 @@ int __init enable_intr_remapping(int eim)
 	struct dmar_drhd_unit *drhd;
 	int setup = 0;
 
+	if (parse_ioapics_under_ir() != 1) {
+		printk(KERN_INFO "Not enable interrupt remapping\n");
+		return -1;
+	}
+
 	for_each_drhd_unit(drhd) {
 		struct intel_iommu *iommu = drhd->iommu;
 
#1 lore raw
Quoted 29 lines · Youquan

Current kernel enable interrupt remapping only when all the vt-d unit support interrupt remapping. So it is reasonable we should also disallow enabling intr-remapping if there any io-apics that are not listed under vt-d units. Otherwise we can run into issues.

---

drivers/pci/dmar.c +0 -3
index 7b287cb..a8a4383 100644
@@ -570,9 +570,6 @@ int __init dmar_table_init(void)
 		printk(KERN_INFO PREFIX "No ATSR found\n");
 #endif
 
-#ifdef CONFIG_INTR_REMAP
-	parse_ioapics_under_ir();
-#endif
 	return 0;
 }
 
drivers/pci/intr_remapping.c +0 -0
index 4f5b871..ebfa47b 100644
@@ -626,6 +626,11 @@ int __init enable_intr_remapping(int eim)
 	struct dmar_drhd_unit *drhd;

drivers/pci/intr_remapping.c int __init enable_intr_remapping(int eim) · line 636

Quoted 10 lines
drivers/pci/intr_remapping.c +5 -0
 	int setup = 0;
 
+	if (parse_ioapics_under_ir() != 1) {
+		printk(KERN_INFO "Not enable interrupt remapping\n");
+		return -1;
+	}
+
 	for_each_drhd_unit(drhd) {
 		struct intel_iommu *iommu = drhd->iommu;
 

David, Can you also pick this up please?

thanks,
suresh

#2 lore raw

This patch also is promising to go to 2.6.32.

Thanks & Regards,
Song Youquan
Intel SSG/SSD/OTC
MOB: 13681289076
TEL: 010-82171326
INET: 8-758-1326
LOC: Raycom 5W027

Quoted 60 lines

-----Original Message-----
From: Siddha, Suresh B
Sent: 2009年9月10日 5:43
To: Song, Youquan
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH] interrupt remapping: Disallow interrupt remapping if not all ioapic under interrupt remapping

Quoted 1 line · Youquan

Current kernel enable interrupt remapping only when all the

vt-d unit support

Quoted 1 line

interrupt remapping. So it is reasonable we should also

disallow enabling

Quoted 1 line

intr-remapping if there any io-apics that are not listed

under vt-d units.

Review

Quoted 21 lines

Otherwise we can run into issues.

---

drivers/pci/dmar.c +0 -3
index 7b287cb..a8a4383 100644
@@ -570,9 +570,6 @@ int __init dmar_table_init(void)
 		printk(KERN_INFO PREFIX "No ATSR found\n");
 #endif
 
-#ifdef CONFIG_INTR_REMAP
-	parse_ioapics_under_ir();
-#endif
 	return 0;
 }
 
(quoted diff) +0 -0

b/drivers/pci/intr_remapping.c

Quoted 5 lines

index 4f5b871..ebfa47b 100644

drivers/pci/intr_remapping.c +0 -0
@@ -626,6 +626,11 @@ int __init enable_intr_remapping(int eim)
 	struct dmar_drhd_unit *drhd;

drivers/pci/intr_remapping.c int __init enable_intr_remapping(int eim) · line 636

Quoted 10 lines
drivers/pci/intr_remapping.c +5 -0
 	int setup = 0;
 
+	if (parse_ioapics_under_ir() != 1) {
+		printk(KERN_INFO "Not enable interrupt remapping\n");
+		return -1;
+	}
+
 	for_each_drhd_unit(drhd) {
 		struct intel_iommu *iommu = drhd->iommu;
 

David, Can you also pick this up please?

thanks,
suresh

�翳簕.n�+壏煯壄�+%娝�遍荻w�簕.n�+壏{炳G珴�妠ay�蕠跈�,jf"穐殢飦�戧鐉_璁(殠娸"濟�m���G珴�⒏?櫒璀�&x忈秈O曟瑉窔v豝�m��� �鹅�⒏?朓�

#3 lore raw

Re: [PATCH] IR: Disallow interrupt remapping if not all ioapic under interrupt remapping

In reply to Suresh Siddha
Quoted 43 lines · Suresh Siddha
Quoted 29 lines · Youquan

Current kernel enable interrupt remapping only when all the vt-d unit support interrupt remapping. So it is reasonable we should also disallow enabling intr-remapping if there any io-apics that are not listed under vt-d units. Otherwise we can run into issues.

---

drivers/pci/dmar.c +0 -3
index 7b287cb..a8a4383 100644
@@ -570,9 +570,6 @@ int __init dmar_table_init(void)
 		printk(KERN_INFO PREFIX "No ATSR found\n");
 #endif
 
-#ifdef CONFIG_INTR_REMAP
-	parse_ioapics_under_ir();
-#endif
 	return 0;
 }
 
drivers/pci/intr_remapping.c +0 -0
index 4f5b871..ebfa47b 100644
@@ -626,6 +626,11 @@ int __init enable_intr_remapping(int eim)
 	struct dmar_drhd_unit *drhd;

drivers/pci/intr_remapping.c int __init enable_intr_remapping(int eim) · line 636

Quoted 10 lines
drivers/pci/intr_remapping.c +5 -0
 	int setup = 0;
 
+	if (parse_ioapics_under_ir() != 1) {
+		printk(KERN_INFO "Not enable interrupt remapping\n");
+		return -1;
+	}
+
 	for_each_drhd_unit(drhd) {
 		struct intel_iommu *iommu = drhd->iommu;
 

David, Can you also pick this up please?

Quoted 2 lines

thanks,
suresh

Change the patch title to short one.
David, Couly you please also pick this up? Sorry, if you have done.

Thanks.

Quoted 7 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#5 lore raw

Re: [PATCH] IR: Disallow interrupt remapping if not all ioapic under interrupt remapping

Quoted 8 lines · David Woodhouse
Quoted 2 lines · Youquan,Song

Change the patch title to short one.
David, Couly you please also pick this up? Sorry, if you have done.

http://git.infradead.org/iommu-2.6.git?commit=e936d0773df

I changed the title when I committed it.

Fine, your title is better than mine. Thanks.