Skip to contentSkip to conversation

trace: export trace_profile_buf symbols

PATCH In review Peter Zijlstra 3 participants 4 messages Sep 20, 2009 – Sep 21, 2009 Tracing

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 trace: export trace_profile_buf symbols

ERROR: "trace_profile_buf_nmi" [fs/jbd2/jbd2.ko] undefined!
ERROR: "trace_profile_buf" [fs/jbd2/jbd2.ko] undefined!
ERROR: "trace_profile_buf_nmi" [fs/ext4/ext4.ko] undefined!
ERROR: "trace_profile_buf" [fs/ext4/ext4.ko] undefined!
ERROR: "trace_profile_buf_nmi" [arch/x86/kvm/kvm.ko] undefined!
ERROR: "trace_profile_buf" [arch/x86/kvm/kvm.ko] undefined!

---
 kernel/trace/trace_event_profile.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
kernel/trace/trace_event_profile.c +3 -0
index 3aaa77c..f65e966 100644
@@ -17,6 +17,9 @@ typedef struct {char buf[FTRACE_MAX_PROFILE_SIZE];} profile_buf_t;
 char		*trace_profile_buf;
 char 		*trace_profile_buf_nmi;
 
+EXPORT_SYMBOL_GPL(trace_profile_buf);
+EXPORT_SYMBOL_GPL(trace_profile_buf_nmi);
+
 /* Count the events in use (per event id, not per instance) */
 static int	total_profile_count;
 
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Peter Zijlstra

ERROR: "trace_profile_buf_nmi" [fs/jbd2/jbd2.ko] undefined!
ERROR: "trace_profile_buf" [fs/jbd2/jbd2.ko] undefined!
ERROR: "trace_profile_buf_nmi" [fs/ext4/ext4.ko] undefined!
ERROR: "trace_profile_buf" [fs/ext4/ext4.ko] undefined!
ERROR: "trace_profile_buf_nmi" [arch/x86/kvm/kvm.ko] undefined!
ERROR: "trace_profile_buf" [arch/x86/kvm/kvm.ko] undefined!

Peter, I thought you never use modules.

Quoted 1 line

-- Steve

Quoted 20 lines
---
 kernel/trace/trace_event_profile.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
kernel/trace/trace_event_profile.c +3 -0
index 3aaa77c..f65e966 100644
@@ -17,6 +17,9 @@ typedef struct {char buf[FTRACE_MAX_PROFILE_SIZE];} profile_buf_t;
 char		*trace_profile_buf;
 char 		*trace_profile_buf_nmi;
 
+EXPORT_SYMBOL_GPL(trace_profile_buf);
+EXPORT_SYMBOL_GPL(trace_profile_buf_nmi);
+
 /* Count the events in use (per event id, not per instance) */
 static int	total_profile_count;
 
#2 lore raw
Quoted 10 lines · Steven Rostedt
Quoted 7 lines · Peter Zijlstra

ERROR: "trace_profile_buf_nmi" [fs/jbd2/jbd2.ko] undefined!
ERROR: "trace_profile_buf" [fs/jbd2/jbd2.ko] undefined!
ERROR: "trace_profile_buf_nmi" [fs/ext4/ext4.ko] undefined!
ERROR: "trace_profile_buf" [fs/ext4/ext4.ko] undefined!
ERROR: "trace_profile_buf_nmi" [arch/x86/kvm/kvm.ko] undefined!
ERROR: "trace_profile_buf" [arch/x86/kvm/kvm.ko] undefined!

Peter, I thought you never use modules.

And I forgot to think about them :-/

Quoted 3 lines
Quoted 1 line
Quoted 25 lines

-- Steve

Quoted 20 lines

---
 kernel/trace/trace_event_profile.c |    3 +++

 1 files changed, 3 insertions(+), 0 deletions(-)
kernel/trace/trace_event_profile.c +3 -0
index 3aaa77c..f65e966 100644
@@ -17,6 +17,9 @@ typedef struct {char buf[FTRACE_MAX_PROFILE_SIZE];} profile_buf_t;
  char         *trace_profile_buf;
  char                 *trace_profile_buf_nmi;
 
+EXPORT_SYMBOL_GPL(trace_profile_buf);
+EXPORT_SYMBOL_GPL(trace_profile_buf_nmi);
+
  /* Count the events in use (per event id, not per instance) */
  static int   total_profile_count;
 
#3 lore raw

[tip:tracing/urgent] tracing: Export trace_profile_buf symbols

In reply to Peter Zijlstra
Commit-ID:  05bafda856092de0705de239c846777bddb94974
Gitweb:     http://git.kernel.org/tip/05bafda856092de0705de239c846777bddb94974
Author:     Peter Zijlstra <[email protected]>
AuthorDate: Sun, 20 Sep 2009 12:34:38 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Sun, 20 Sep 2009 19:15:57 +0200

tracing: Export trace_profile_buf symbols

ERROR: "trace_profile_buf_nmi" [fs/jbd2/jbd2.ko] undefined!
ERROR: "trace_profile_buf" [fs/jbd2/jbd2.ko] undefined!
ERROR: "trace_profile_buf_nmi" [fs/ext4/ext4.ko] undefined!
ERROR: "trace_profile_buf" [fs/ext4/ext4.ko] undefined!
ERROR: "trace_profile_buf_nmi" [arch/x86/kvm/kvm.ko] undefined!
ERROR: "trace_profile_buf" [arch/x86/kvm/kvm.ko] undefined!

LKML-Reference: <1253442878.7542.3.camel@laptop>

[ fixed whitespace noise and checkpatch complaint ]
---
 kernel/trace/trace_event_profile.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
kernel/trace/trace_event_profile.c +4 -1
index 3aaa77c..dd44b87 100644
@@ -15,7 +15,10 @@
 typedef struct {char buf[FTRACE_MAX_PROFILE_SIZE];} profile_buf_t;
 
 char		*trace_profile_buf;
-char 		*trace_profile_buf_nmi;
+EXPORT_SYMBOL_GPL(trace_profile_buf);
+
+char		*trace_profile_buf_nmi;
+EXPORT_SYMBOL_GPL(trace_profile_buf_nmi);
 
 /* Count the events in use (per event id, not per instance) */
 static int	total_profile_count;