Skip to contentSkip to conversation

Fix comment in drivers/ata/pata_hpt37x.c.

PATCH Applied Krzysztof Halasa 3 participants 4 messages Sep 20, 2009 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix comment in drivers/ata/pata_hpt37x.c.

A comment fix in drivers/ata/pata_hpt37x.c.

drivers/ata/pata_hpt37x.c +1 -1
index 122c786..d0a7df2 100644
@@ -624,7 +624,7 @@ static struct ata_port_operations hpt374_fn1_port_ops = {
 };
 
 /**
- *	htp37x_clock_slot	-	Turn timing to PC clock entry
+ *	hpt37x_clock_slot	-	Turn timing to PC clock entry
  *	@freq: Reported frequency timing
  *	@base: Base timing
  *
#1 lore raw
Quoted 4 lines · Krzysztof Halasa

A comment fix in drivers/ata/pata_hpt37x.c.

checkpatch has some trouble with your name ..

ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8 #42:

                           ^

I've seen this warning a few times, and I wasn't sure to exactly what to do with it.. However, it does seem like a lot of people have trouble with the encodings ..

I did a little research and I think I was able to produce your name in utf8 (checkpatch doesn't error any longer..)

Are you aware that your name isn't in utf8? Does the above name look right to you? To me my version looks identical to your version ..

Daniel

#2 lore raw
Quoted 7 lines · Daniel Walker

I did a little research and I think I was able to produce your name in utf8 (checkpatch doesn't error any longer..)

Are you aware that your name isn't in utf8? Does the above name look right to you? To me my version looks identical to your version ..

Well, it looks like at some point I instructed my Gnus to send in ISO 8859-* encoding if possible. Probably you used the raw "mail spool" file, instead of converting to UTF-8. Not much surprise, though. There is no reason for me to use 8859 encodings anymore, I've just switched that to UTF-8.

Thanks for noticing.

Signature · 1 line
Krzysztof Hałasa
Applied
#3 lore raw
In reply to Krzysztof Halasa
Quoted 9 lines · Krzysztof Halasa

A comment fix in drivers/ata/pata_hpt37x.c.

drivers/ata/pata_hpt37x.c +0 -0
index 122c786..d0a7df2 100644

drivers/ata/pata_hpt37x.c static struct ata_port_operations hpt374_fn1_port_ops = { · line 630

Quoted 8 lines
drivers/ata/pata_hpt37x.c +1 -1
@@ -624,7 +624,7 @@ static struct ata_port_operations hpt374_fn1_port_ops = {
 };
 
 /**
- *	htp37x_clock_slot	-	Turn timing to PC clock entry
+ *	hpt37x_clock_slot	-	Turn timing to PC clock entry
  *	@freq: Reported frequency timing
  *	@base: Base timing
  *

Applied to trivial queue, thanks Krzysztof.

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.