Skip to contentSkip to conversation

sbc85x0: tidy up Makefile to use new configuration script.

PATCH New Paul Gortmaker 2 participants 2 messages Sep 21, 2009 – Sep 22, 2009 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sbc85x0: tidy up Makefile to use new configuration script.

Commit 804d83a5 allows us to move all the configuration variation tweaks out of the top level Makefile and down into the boards config header. This takes advantage of that for the sbc8540/sbc8560 boards.

There were a couple of cheezy comments pointing at incorrect files, or files that don't exist, so I've cleaned those up too.

---

For 85xx tree; since it contains sbc8548 commits which this diff has context of one of those commit changes to Makefile

 Makefile                  |   18 ++----------------
 include/configs/SBC8540.h |   19 +++++++++++--------
 include/configs/sbc8560.h |   17 ++++++++++++-----
 3 files changed, 25 insertions(+), 29 deletions(-)
Makefile +2 -16
index 55ee25d..9c5b2a5 100644
@@ -2535,14 +2535,7 @@ PM856_config:	unconfig
 sbc8540_config \
 sbc8540_33_config \
 sbc8540_66_config:	unconfig
-	@mkdir -p $(obj)include
-	@if [ "$(findstring _66_,$@)" ] ; then \
-		echo "#define CONFIG_PCI_66"	>>$(obj)include/config.h ; \
-		$(XECHO) "... 66 MHz PCI" ; \
-	else \
-		$(XECHO) "... 33 MHz PCI" ; \
-	fi
-	@$(MKCONFIG) -a SBC8540 ppc mpc85xx sbc8560
+	@$(MKCONFIG) -t $(@:_config=) SBC8540 ppc mpc85xx sbc8560
 
 sbc8548_config \
 sbc8548_PCI_33_config \
@@ -2554,14 +2547,7 @@ sbc8548_PCI_66_PCIE_config: unconfig
 sbc8560_config \
 sbc8560_33_config \
 sbc8560_66_config:	unconfig
-	@mkdir -p $(obj)include
-	@if [ "$(findstring _66_,$@)" ] ; then \
-		echo "#define CONFIG_PCI_66"	>>$(obj)include/config.h ; \
-		$(XECHO) "... 66 MHz PCI" ; \
-	else \
-		$(XECHO) "... 33 MHz PCI" ; \
-	fi
-	@$(MKCONFIG) -a sbc8560 ppc mpc85xx sbc8560
+	@$(MKCONFIG) -t $(@:_config=) sbc8560 ppc mpc85xx sbc8560
 
 socrates_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) ppc mpc85xx socrates
include/configs/SBC8540.h +11 -8
index 7239f84..198dece 100644
@@ -24,22 +24,25 @@
  * MA 02111-1307 USA
  */
 
-/* mpc8560ads board configuration file */
-/* please refer to doc/README.mpc85xx for more info */
-/* make sure you change the MAC address and other network params first,
- * search for CONFIG_ETHADDR,CONFIG_SERVERIP,etc in this file
+/*
+ * sbc8540 board configuration file.
  */
 
 #ifndef __CONFIG_H
 #define __CONFIG_H
 
-#if XXX
-#define DEBUG		      /* General debug */
-#define ET_DEBUG
+/*
+ * Top level Makefile configuration choices
+ */
+#ifdef CONFIG_MK_66
+#define CONFIG_PCI_66
 #endif
+
 #define TSEC_DEBUG
 
-/* High Level Configuration Options */
+/*
+ * High Level Configuration Options
+ */
 #define CONFIG_BOOKE		1	/* BOOKE			*/
 #define CONFIG_E500		1	/* BOOKE e500 family		*/
 #define CONFIG_MPC85xx		1	/* MPC8540/MPC8560		*/
include/configs/sbc8560.h +12 -5
index 4fa501d..7c1d7a6 100644
@@ -24,16 +24,23 @@
  * MA 02111-1307 USA
  */
 
-/* sbc8560 board configuration file */
-/* please refer to doc/README.sbc8560 for more info */
-/* make sure you change the MAC address and other network params first,
- * search for CONFIG_ETHADDR,CONFIG_SERVERIP,etc in this file
+/*
+ * sbc8560 board configuration file.
  */
 
 #ifndef __CONFIG_H
 #define __CONFIG_H
 
-/* High Level Configuration Options */
+/*
+ * Top level Makefile configuration choices
+ */
+#ifdef CONFIG_MK_66
+#define CONFIG_PCI_66
+#endif
+
+/*
+ * High Level Configuration Options
+ */
 #define CONFIG_BOOKE		1	/* BOOKE			*/
 #define CONFIG_E500		1	/* BOOKE e500 family		*/
 #define CONFIG_MPC85xx		1	/* MPC8540/MPC8560		*/
Signature · 1 line
1.6.4.1
Applied
#1 lore raw

PATCH 1/1 sbc85x0: tidy up Makefile to use new configuration script.

Quoted 11 lines · Paul Gortmaker

Commit 804d83a5 allows us to move all the configuration variation tweaks out of the top level Makefile and down into the boards config header. This takes advantage of that for the sbc8540/sbc8560 boards.

There were a couple of cheezy comments pointing at incorrect files, or files that don't exist, so I've cleaned those up too.

---

Quoted 7 lines

For 85xx tree; since it contains sbc8548 commits which this diff has context of one of those commit changes to Makefile

Makefile                  |   18 ++----------------
include/configs/SBC8540.h |   19 +++++++++++--------
include/configs/sbc8560.h |   17 ++++++++++++-----
3 files changed, 25 insertions(+), 29 deletions(-)

applied to 85xx

- k