Skip to contentSkip to conversation

fix use after free

PATCH New Glauber Costa 1 participant 1 message Sep 25, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix use after free

We are using the vs structure when it was just freed. Classic use after free, fix it.

---
 vnc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
vnc.c +1 -1
index 5eaef6a..592c9b3 100644
@@ -918,8 +918,8 @@ static void vnc_disconnect_finish(VncState *vs)
     if (!vs->vd->clients)
         dcl->idle = 1;
 
-    qemu_free(vs);
     vnc_remove_timer(vs->vd);
+    qemu_free(vs);
 }
 
 int vnc_client_io_error(VncState *vs, int ret, int last_errno)
Signature · 1 line
1.6.2.2