Skip to contentSkip to conversation

ARM: Remove unused CONFIG reference DEBUG_S3C_PORT

PATCH In review Jaswinder Singh Rajput 2 participants 3 messages Sep 26, 2009 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: Remove unused CONFIG reference DEBUG_S3C_PORT

Remove unused CONFIG reference DEBUG_S3C_PORT from defconfig

---
 arch/arm/configs/s5pc100_defconfig |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/configs/s5pc100_defconfig +0 -1
index b0d7d3d..94edde5 100644
@@ -859,7 +859,6 @@ CONFIG_DEBUG_ERRORS=y
 # CONFIG_DEBUG_STACK_USAGE is not set
 CONFIG_DEBUG_LL=y
 # CONFIG_DEBUG_ICEDCC is not set
-CONFIG_DEBUG_S3C_PORT=y
 CONFIG_DEBUG_S3C_UART=0
 
 #
Signature · 1 line
1.6.0.6
#1 lore raw
Quoted 17 lines · Jaswinder Singh Rajput

Remove unused CONFIG reference DEBUG_S3C_PORT from defconfig

---
 arch/arm/configs/s5pc100_defconfig |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/configs/s5pc100_defconfig +0 -0
index b0d7d3d..94edde5 100644

arch/arm/configs/s5pc100_defconfig CONFIG_DEBUG_ERRORS=y · line 862

Quoted 5 lines
arch/arm/configs/s5pc100_defconfig +0 -1
@@ -859,7 +859,6 @@ CONFIG_DEBUG_ERRORS=y
 # CONFIG_DEBUG_STACK_USAGE is not set
 CONFIG_DEBUG_LL=y
 # CONFIG_DEBUG_ICEDCC is not set
-CONFIG_DEBUG_S3C_PORT=y
 CONFIG_DEBUG_S3C_UART=0

no, there is no point removing redundant entries from any of the
defconfig files -- those files will eventually be rebuilt automatically at some point.

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Annoying Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================

#2 lore raw

Hello Robert,

Quoted 14 lines · Robert P. J. Day
Quoted 12 lines · Jaswinder Singh Rajput

Remove unused CONFIG reference DEBUG_S3C_PORT from defconfig

---
 arch/arm/configs/s5pc100_defconfig |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Quoted 15 lines

arch/arm/configs/s5pc100_defconfig CONFIG_DEBUG_ERRORS=y · line 862

Quoted 10 lines
arch/arm/configs/s5pc100_defconfig +0 -1
index b0d7d3d..94edde5 100644
@@ -859,7 +859,6 @@ CONFIG_DEBUG_ERRORS=y
 # CONFIG_DEBUG_STACK_USAGE is not set
 CONFIG_DEBUG_LL=y
 # CONFIG_DEBUG_ICEDCC is not set
-CONFIG_DEBUG_S3C_PORT=y
 CONFIG_DEBUG_S3C_UART=0

no, there is no point removing redundant entries from any of the
defconfig files -- those files will eventually be rebuilt automatically at some point.

Who will build defconfig for old architectures like h3600_defconfig and others.

If we are removing unused CONFIG from Kconfig then there is no point of leaving those entries in defconfigs after all git grep keep those entries and lead to confusions sooner or later. Yeah, for this case where we have only entry in defconfig you sounds good but let maintainers will decide it :-)

Thanks,
--
JSR