Skip to contentSkip to conversation

ARM: OMAP: Remove unused CONFIG MACH_OMAP_HTCWIZARD

PATCH In review Jaswinder Singh Rajput 4 participants 4 messages Sep 26, 2009 – Sep 27, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: OMAP: Remove unused CONFIG MACH_OMAP_HTCWIZARD

Remove unused CONFIG MACH_OMAP_HTCWIZARD from Kconfig

Cc Zebediah C. McClure <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Russell King <[email protected]>
---
 arch/arm/mach-omap1/Kconfig |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)
arch/arm/mach-omap1/Kconfig +0 -6
index 55ecc01..c25038e 100644
@@ -50,12 +50,6 @@ config MACH_OMAP_H3
 	  TI OMAP 1710 H3 board support. Say Y here if you have such
 	  a board.
 
-config MACH_OMAP_HTCWIZARD
-	bool "HTC Wizard"
-	depends on ARCH_OMAP850
-	help
-	  HTC Wizard smartphone support (AKA QTEK 9100, ...)
-
 config MACH_OMAP_OSK
 	bool "TI OSK Support"
 	depends on ARCH_OMAP1 && ARCH_OMAP16XX
Signature · 1 line
1.6.0.6
#1 lore raw

2009/9/26 Jaswinder Singh Rajput <[email protected]>:

Quoted 2 lines

Remove unused CONFIG MACH_OMAP_HTCWIZARD from Kconfig

Don't do it please! We're working on it.... board file is coming very soon.

Signature · 2 lines
Alistair Buxton
a.j.buxton at gmail.com
#2 lore raw
Quoted 6 lines · Alistair Buxton

2009/9/26 Jaswinder Singh Rajput <[email protected]>:

Quoted 2 lines

Remove unused CONFIG MACH_OMAP_HTCWIZARD from Kconfig

Don't do it please! We're working on it.... board file is coming very soon.

i've noticed that happening fairly often -- feature infrastructure
is added before the feature itself. at the risk of sounding all preachy and everything, that sort of thing should be avoided in order to keep the history cleaner. and because that's *exactly* the sort of thing that, occasionally, produces the kind of historical cruft that leaves unused CONFIG variables lying around when a feature is abandoned in midstream.

ok, i'll stop preaching now.

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Annoying Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================

#3 lore raw

PATCH 1/1 ARM: OMAP: Remove unused CONFIG MACH_OMAP_HTCWIZARD

In reply to Jaswinder Singh Rajput

This is not unused, this is under current development. (linwizard.sourceforge.net) there is another patch series waiting for rc1 to be cut, tony has already replied to the pull request.

Best regards,
ZMC

Quoted 30 lines · Jaswinder Singh Rajput

Remove unused CONFIG MACH_OMAP_HTCWIZARD from Kconfig

Cc Zebediah C. McClure <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Russell King <[email protected]>
---
 arch/arm/mach-omap1/Kconfig |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)
arch/arm/mach-omap1/Kconfig +0 -6
index 55ecc01..c25038e 100644
@@ -50,12 +50,6 @@ config MACH_OMAP_H3
 	  TI OMAP 1710 H3 board support. Say Y here if you have such
 	  a board.
 
-config MACH_OMAP_HTCWIZARD
-	bool "HTC Wizard"
-	depends on ARCH_OMAP850
-	help
-	  HTC Wizard smartphone support (AKA QTEK 9100, ...)
-
 config MACH_OMAP_OSK
 	bool "TI OSK Support"
 	depends on ARCH_OMAP1 && ARCH_OMAP16XX