Skip to contentSkip to conversation

Add quirks for Vaio VGN

PATCH In review Pascal Terjan 2 participants 8 messages Sep 28, 2009 Sound

lore
Share & tools
lore
#0 lore raw

cover Add quirks for Vaio VGN

Here are some quirks for 3 Vaio VGN model reported on launchpad to need model=vaio

Pascal Terjan (3):
[ALSA] Add quirk for Sony Vaio VGN-SZ650N
[ALSA] Add quirk for Sony Vaio VGN-AR51M
[ALSA] Add quirk for Sony Vaio VGN-FZ15G

 sound/pci/hda/patch_sigmatel.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
#1 lore raw

PATCH 1/3 Add quirk for Sony Vaio VGN-SZ650N

From
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/195605/comments/25

---
 sound/pci/hda/patch_sigmatel.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
sound/pci/hda/patch_sigmatel.c +2 -0
index 826137e..cd91d95 100644
@@ -5815,6 +5815,8 @@ static unsigned int *stac9872_brd_tbl[STAC_9872_MODELS] = {
 static struct snd_pci_quirk stac9872_cfg_tbl[] = {
 	SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x81e0,
 			   "Sony VAIO F/S", STAC_9872_VAIO),
+	SND_PCI_QUIRK(0x104d, 0x9008,
+			   "Sony Vaio VGN-SZ650N", STAC_9872_VAIO),
 	{} /* terminator */
 };
 
Signature · 1 line
1.6.4.2
#2 lore raw

PATCH 2/3 Add quirk for Sony Vaio VGN-AR51M

From
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/195605/comments/35

---
 sound/pci/hda/patch_sigmatel.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
sound/pci/hda/patch_sigmatel.c +2 -0
index cd91d95..9d73311 100644
@@ -5817,6 +5817,8 @@ static struct snd_pci_quirk stac9872_cfg_tbl[] = {
 			   "Sony VAIO F/S", STAC_9872_VAIO),
 	SND_PCI_QUIRK(0x104d, 0x9008,
 			   "Sony Vaio VGN-SZ650N", STAC_9872_VAIO),
+	SND_PCI_QUIRK(0x104d, 0x9016,
+			   "Sony Vaio VGN-AR51M", STAC_9872_VAIO),
 	{} /* terminator */
 };
 
Signature · 1 line
1.6.4.2
#3 lore raw

PATCH 3/3 Add quirk for Sony Vaio VGN-FZ15G

From
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/195605/comments/36

---
 sound/pci/hda/patch_sigmatel.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
sound/pci/hda/patch_sigmatel.c +2 -0
index 9d73311..c4310ee 100644
@@ -5815,6 +5815,8 @@ static unsigned int *stac9872_brd_tbl[STAC_9872_MODELS] = {
 static struct snd_pci_quirk stac9872_cfg_tbl[] = {
 	SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x81e0,
 			   "Sony VAIO F/S", STAC_9872_VAIO),
+	SND_PCI_QUIRK(0x104d, 0x9005,
+			   "Sony Vaio VGN-FZ15G", STAC_9872_VAIO),
 	SND_PCI_QUIRK(0x104d, 0x9008,
 			   "Sony Vaio VGN-SZ650N", STAC_9872_VAIO),
 	SND_PCI_QUIRK(0x104d, 0x9016,
Signature · 1 line
1.6.4.2
#4 lore raw

Re: [PATCH 1/3] [ALSA] Add quirk for Sony Vaio VGN-SZ650N

In reply to Pascal Terjan

At Mon, 28 Sep 2009 11:43:11 +0200,

Quoted 5 lines · Pascal Terjan

From
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/195605/comments/25

Thanks for the patch.
I think we can merge all three using SND_PCI_QUIRK_MASK(), e.g. SND_PCI_QUIRK_MASK(0x104d, 0xff00, 0x9000, "Sony VAIO", STAC_9872_VAIO)

Or, a bit safer like
SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x9000, "Sony VAIO", STAC_9872_VAIO) SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x9010, "Sony VAIO", STAC_9872_VAIO)

Could you check whether it's OK?

Also, please make sure that this change is really needed for the latest alsa-driver. The recent version probes the BIOS setup, and it should work as is unless BIOS is broken. The quirk entries like the above override the BIOS setup, thus should be used only when really needed.

thanks,

Takashi

Quoted 20 lines
---
 sound/pci/hda/patch_sigmatel.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
sound/pci/hda/patch_sigmatel.c +2 -0
index 826137e..cd91d95 100644
@@ -5815,6 +5815,8 @@ static unsigned int *stac9872_brd_tbl[STAC_9872_MODELS] = {
 static struct snd_pci_quirk stac9872_cfg_tbl[] = {
 	SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x81e0,
 			   "Sony VAIO F/S", STAC_9872_VAIO),
+	SND_PCI_QUIRK(0x104d, 0x9008,
+			   "Sony Vaio VGN-SZ650N", STAC_9872_VAIO),
 	{} /* terminator */
 };
 
Signature · 1 line
1.6.4.2
#5 lore raw

Re: [PATCH 1/3] [ALSA] Add quirk for Sony Vaio VGN-SZ650N

Quoted 12 lines · Takashi Iwai

At Mon, 28 Sep 2009 11:43:11 +0200,

Quoted 5 lines · Pascal Terjan

From
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/195605/comments/25

Thanks for the patch.
I think we can merge all three using SND_PCI_QUIRK_MASK(), e.g. SND_PCI_QUIRK_MASK(0x104d, 0xff00, 0x9000, "Sony VAIO", STAC_9872_VAIO)

Quoted 5 lines

Or, a bit safer like
SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x9000, "Sony VAIO", STAC_9872_VAIO) SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x9010, "Sony VAIO", STAC_9872_VAIO)

Could you check whether it's OK?

I think so, but I can't be sure of how Sony distributed the ids

SZ61 was reported to need model=vaio to have headphones working but I could not find the ids anyway

Some commenter also reported FZ11S needed model=vaio without giving any info and without id

Given that other model seem to need it too I think that the mask would make sense

Quoted 5 lines

Also, please make sure that this change is really needed for the latest alsa-driver. The recent version probes the BIOS setup, and it should work as is unless BIOS is broken. The quirk entries like the above override the BIOS setup, thus should be used only when really needed.

Unfortunately we only have this for a paying customer using 2.6.29 on stable version, and who is happy with adding model=vaio. I found that other had reported on launchpad, but I don't have the hardware myself to test with kernel after July commits

#6 lore raw

Re: [PATCH 1/3] [ALSA] Add quirk for Sony Vaio VGN-SZ650N

At Mon, 28 Sep 2009 12:03:45 +0200,

Quoted 22 lines · Pascal Terjan
Quoted 12 lines · Takashi Iwai

At Mon, 28 Sep 2009 11:43:11 +0200,

Quoted 5 lines · Pascal Terjan

From
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/195605/comments/25

Thanks for the patch.
I think we can merge all three using SND_PCI_QUIRK_MASK(), e.g. SND_PCI_QUIRK_MASK(0x104d, 0xff00, 0x9000, "Sony VAIO", STAC_9872_VAIO)

Quoted 5 lines

Or, a bit safer like
SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x9000, "Sony VAIO", STAC_9872_VAIO) SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x9010, "Sony VAIO", STAC_9872_VAIO)

Could you check whether it's OK?

I think so, but I can't be sure of how Sony distributed the ids

Quoted 8 lines

SZ61 was reported to need model=vaio to have headphones working but I could not find the ids anyway

Some commenter also reported FZ11S needed model=vaio without giving any info and without id

Given that other model seem to need it too I think that the mask would make sense

Yep.

Quoted 10 lines
Quoted 5 lines

Also, please make sure that this change is really needed for the latest alsa-driver. The recent version probes the BIOS setup, and it should work as is unless BIOS is broken. The quirk entries like the above override the BIOS setup, thus should be used only when really needed.

Unfortunately we only have this for a paying customer using 2.6.29 on stable version, and who is happy with adding model=vaio. I found that other had reported on launchpad, but I don't have the hardware myself to test with kernel after July commits

Is the sound driver also based on 2.6.29 kernel, or built externally from the later version of alsa-driver? The HD-audio driver on 2.6.29 requires model=vaio explicitly while the later version of alsa-driver should work without model option as long as BIOS is correct.

So, I'm a bit worried about adding the quirks blindly.

Takashi
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#7 lore raw

Re: [PATCH 1/3] [ALSA] Add quirk for Sony Vaio VGN-SZ650N

Quoted 46 lines · Takashi Iwai

At Mon, 28 Sep 2009 12:03:45 +0200,

Quoted 22 lines · Pascal Terjan
Quoted 12 lines · Takashi Iwai

At Mon, 28 Sep 2009 11:43:11 +0200,

Quoted 5 lines · Pascal Terjan

From
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/195605/comments/25

Thanks for the patch.
I think we can merge all three using SND_PCI_QUIRK_MASK(), e.g. SND_PCI_QUIRK_MASK(0x104d, 0xff00, 0x9000, "Sony VAIO", STAC_9872_VAIO)

Quoted 5 lines

Or, a bit safer like
SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x9000, "Sony VAIO", STAC_9872_VAIO) SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x9010, "Sony VAIO", STAC_9872_VAIO)

Could you check whether it's OK?

I think so, but I can't be sure of how Sony distributed the ids

Quoted 8 lines

SZ61 was reported to need model=vaio to have headphones working but I could not find the ids anyway

Some commenter also reported FZ11S needed model=vaio without giving any info and without id

Given that other model seem to need it too I think that the mask would make sense

Yep.

Quoted 10 lines
Quoted 5 lines

Also, please make sure that this change is really needed for the latest alsa-driver. The recent version probes the BIOS setup, and it should work as is unless BIOS is broken. The quirk entries like the above override the BIOS setup, thus should be used only when really needed.

Unfortunately we only have this for a paying customer using 2.6.29 on stable version, and who is happy with adding model=vaio. I found that other had reported on launchpad, but I don't have the hardware myself to test with kernel after July commits

Quoted 4 lines

Is the sound driver also based on 2.6.29 kernel, or built externally from the later version of alsa-driver? The HD-audio driver on 2.6.29 requires model=vaio explicitly while the later version of alsa-driver should work without model option as long as BIOS is correct.

They are using 2.6.29 audio

Quoted 1 line

So, I'm a bit worried about adding the quirks blindly.

Yes better to not add them then, hopefuly they will work