Skip to contentSkip to conversation

powerpc/5200: add LocalPlus bus FIFO device driver

PATCH In review John Bonesio 3 participants 5 messages Sep 29, 2009 – Oct 1, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/5200: add LocalPlus bus FIFO device driver

This is a driver for the FIFO device on the LocalPlus bus on an mpc5200 system. The driver supports programmed I/O through the FIFO as well as setting up DMA via the BestComm engine through the FIFO.

---
This driver was originally written by Grant Likely. I have updated it so that transmitting data (as opposed to receiving data) works better. The driver has been tested for all 6 transfer modes:
PIO mode (rx and tx)
DMA polled mode (rx and tx)
DMA interrupt mode (rx and tx)

- John

 arch/powerpc/include/asm/mpc52xx.h            |   39 ++
 arch/powerpc/platforms/52xx/Kconfig           |    5 
 arch/powerpc/platforms/52xx/Makefile          |    1 
 arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c |  560 +++++++++++++++++++++++++
 4 files changed, 605 insertions(+), 0 deletions(-)
 create mode 100644 arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c
arch/powerpc/include/asm/mpc52xx.h +39 -0
index 8273357..819a0be 100644
@@ -282,6 +282,45 @@ extern int mpc52xx_gpt_start_timer(struct mpc52xx_gpt_priv *gpt, int period,
                             int continuous);
 extern void mpc52xx_gpt_stop_timer(struct mpc52xx_gpt_priv *gpt);
 
+/* mpc52xx_lpbfifo.c */
+#define MPC52XX_LPBFIFO_FLAG_READ		(0)
+#define MPC52XX_LPBFIFO_FLAG_WRITE		(1<<0)
+#define MPC52XX_LPBFIFO_FLAG_NO_INCREMENT	(1<<1)
+#define MPC52XX_LPBFIFO_FLAG_NO_DMA		(1<<2)
+#define MPC52XX_LPBFIFO_FLAG_POLL_DMA		(1<<3)
+
+struct mpc52xx_lpbfifo_request {
+	struct list_head list;
+
+	/* localplus bus address */
+	unsigned int cs;
+	size_t offset;
+
+	/* Memory address */
+	void *data;
+	phys_addr_t data_phys;
+
+	/* Details of transfer */
+	size_t size;
+	size_t pos;	/* current position of transfer */
+	int flags;
+
+	/* What to do when finished */
+	void (*callback)(struct mpc52xx_lpbfifo_request *);
+
+	void *priv;		/* Driver private data */
+
+	/* statistics */
+	int irq_count;
+	int irq_ticks;
+	u8 last_byte;
+	int buffer_not_done_cnt;
+};
+
+extern int mpc52xx_lpbfifo_submit(struct mpc52xx_lpbfifo_request *req);
+extern void mpc52xx_lpbfifo_abort(struct mpc52xx_lpbfifo_request *req);
+extern void mpc52xx_lpbfifo_poll(void);
+
 /* mpc52xx_pic.c */
 extern void mpc52xx_init_irq(void);
 extern unsigned int mpc52xx_get_irq(void);
arch/powerpc/platforms/52xx/Kconfig +5 -0
index 696a5ee..ea00b3d 100644
@@ -51,3 +51,8 @@ config PPC_MPC5200_GPIO
 	select GENERIC_GPIO
 	help
 	  Enable gpiolib support for mpc5200 based boards
+
+config PPC_MPC5200_LPBFIFO
+	tristate "MPC5200 LocalPlus bus FIFO driver"
+	depends on PPC_MPC52xx
+	select PPC_BESTCOMM_GEN_BD
arch/powerpc/platforms/52xx/Makefile +1 -0
index d6ade3d..8df23af 100644
@@ -14,3 +14,4 @@ ifeq ($(CONFIG_PPC_LITE5200),y)
 endif
 
 obj-$(CONFIG_PPC_MPC5200_GPIO)	+= mpc52xx_gpio.o
+obj-$(CONFIG_PPC_MPC5200_LPBFIFO)	+= mpc52xx_lpbfifo.o
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +560 -0

560 lines not on this page · raw message

#1 lore raw
Quoted 1 line · John Bonesio

This is a driver for the FIFO device on the LocalPlus bus on an mpc5200 s=

ystem.

Quoted 1 line

The driver supports programmed I/O through the FIFO as well as setting up=

DMA

Quoted 4 lines

via the BestComm engine through the FIFO.

Let me know if anyone has comments on this. Since it is a new driver, I'll probably try to merge it for 2.6.32 in the next week or so even though the merge window has closed.

Cheers,
g.

Quoted 2 lines

---
This driver was originally written by Grant Likely. I have updated it so =

that

Quoted 1 line

transmitting data (as opposed to receiving data) works better. The driver=

has

Quoted 11 lines

been tested for all 6 transfer modes:
=A0 =A0 =A0 =A0PIO mode (rx and tx)
=A0 =A0 =A0 =A0DMA polled mode (rx and tx)
=A0 =A0 =A0 =A0DMA interrupt mode (rx and tx)

- John

=A0arch/powerpc/include/asm/mpc52xx.h =A0 =A0 =A0 =A0 =A0 =A0| =A0 39 ++ =A0arch/powerpc/platforms/52xx/Kconfig =A0 =A0 =A0 =A0 =A0 | =A0 =A05 =A0arch/powerpc/platforms/52xx/Makefile =A0 =A0 =A0 =A0 =A0| =A0 =A01 =A0arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c | =A0560 +++++++++++++++=

++++++++++

arch/powerpc/include/as=

Quoted 4 lines

=A04 files changed, 605 insertions(+), 0 deletions(-) =A0create mode 100644 arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c

arch/powerpc/include/as= renamed from arch/powerpc/include/asm/mpc52xx.h +0 -0

m/mpc52xx.h

arch/powerpc/include/asm/mpc52xx.h extern int mpc52xx_gpt_start_timer(struct mpc52xx_gp=

Quoted 4 lines

index 8273357..819a0be 100644

arch/powerpc/include/asm/mpc52xx.h +0 -0
@@ -282,6 +282,45 @@ extern int mpc52xx_gpt_start_timer(struct mpc52xx_gp=

t_priv *gpt, int period,

Quoted 20 lines
arch/powerpc/include/asm/mpc52xx.h +17 -0
 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 int continuous);
 =A0extern void mpc52xx_gpt_stop_timer(struct mpc52xx_gpt_priv *gpt);
 
+/* mpc52xx_lpbfifo.c */
+#define MPC52XX_LPBFIFO_FLAG_READ =A0 =A0 =A0 =A0 =A0 =A0 =A0(0)
+#define MPC52XX_LPBFIFO_FLAG_WRITE =A0 =A0 =A0 =A0 =A0 =A0 (1<<0)
+#define MPC52XX_LPBFIFO_FLAG_NO_INCREMENT =A0 =A0 =A0(1<<1)
+#define MPC52XX_LPBFIFO_FLAG_NO_DMA =A0 =A0 =A0 =A0 =A0 =A0(1<<2)
+#define MPC52XX_LPBFIFO_FLAG_POLL_DMA =A0 =A0 =A0 =A0 =A0(1<<3)
+
+struct mpc52xx_lpbfifo_request {
+ =A0 =A0 =A0 struct list_head list;
+
+ =A0 =A0 =A0 /* localplus bus address */
+ =A0 =A0 =A0 unsigned int cs;
+ =A0 =A0 =A0 size_t offset;
+
+ =A0 =A0 =A0 /* Memory address */
+ =A0 =A0 =A0 void *data;
+ =A0 =A0 =A0 phys_addr_t data_phys;

arch/powerpc/include/asm/mpc52xx.h extern int mpc52xx_gpt_start_timer(struct mpc52xx_gp= · line 311

Quoted 10 lines
arch/powerpc/include/asm/mpc52xx.h +10 -0
+
+ =A0 =A0 =A0 /* Details of transfer */
+ =A0 =A0 =A0 size_t size;
+ =A0 =A0 =A0 size_t pos; =A0 =A0 /* current position of transfer */
+ =A0 =A0 =A0 int flags;
+
+ =A0 =A0 =A0 /* What to do when finished */
+ =A0 =A0 =A0 void (*callback)(struct mpc52xx_lpbfifo_request *);
+
+ =A0 =A0 =A0 void *priv; =A0 =A0 =A0 =A0 =A0 =A0 /* Driver private data =

*/

arch/powerpc/platforms=

Quoted 16 lines
arch/powerpc/include/asm/mpc52xx.h +12 -0
+
+ =A0 =A0 =A0 /* statistics */
+ =A0 =A0 =A0 int irq_count;
+ =A0 =A0 =A0 int irq_ticks;
+ =A0 =A0 =A0 u8 last_byte;
+ =A0 =A0 =A0 int buffer_not_done_cnt;
+};
+
+extern int mpc52xx_lpbfifo_submit(struct mpc52xx_lpbfifo_request *req);
+extern void mpc52xx_lpbfifo_abort(struct mpc52xx_lpbfifo_request *req);
+extern void mpc52xx_lpbfifo_poll(void);
+

=A0/* mpc52xx_pic.c */
=A0extern void mpc52xx_init_irq(void);
=A0extern unsigned int mpc52xx_get_irq(void);

arch/powerpc/platforms= renamed from arch/powerpc/platforms/52xx/Kconfig +0 -0

/52xx/Kconfig

arch/powerpc/platform=

Quoted 13 lines

index 696a5ee..ea00b3d 100644

arch/powerpc/platforms/52xx/Kconfig +0 -0
@@ -51,3 +51,8 @@ config PPC_MPC5200_GPIO

=A0 =A0 =A0 =A0select GENERIC_GPIO
=A0 =A0 =A0 =A0help
=A0 =A0 =A0 =A0 =A0Enable gpiolib support for mpc5200 based boards

arch/powerpc/platforms/52xx/Kconfig +5 -0
+
+config PPC_MPC5200_LPBFIFO
+ =A0 =A0 =A0 tristate "MPC5200 LocalPlus bus FIFO driver"
+ =A0 =A0 =A0 depends on PPC_MPC52xx
+ =A0 =A0 =A0 select PPC_BESTCOMM_GEN_BD
arch/powerpc/platform= renamed from arch/powerpc/platforms/52xx/Makefile +0 -0

s/52xx/Makefile

arch/powerpc=

Quoted 9 lines

index d6ade3d..8df23af 100644

arch/powerpc/platforms/52xx/Makefile +0 -0
@@ -14,3 +14,4 @@ ifeq ($(CONFIG_PPC_LITE5200),y)

=A0endif

=A0obj-$(CONFIG_PPC_MPC5200_GPIO) +=3D mpc52xx_gpio.o

arch/powerpc/platforms/52xx/Makefile +1 -0
+obj-$(CONFIG_PPC_MPC5200_LPBFIFO) =A0 =A0 =A0+=3D mpc52xx_lpbfifo.o
arch/powerpc= renamed from arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c +0 -0

/platforms/52xx/mpc52xx_lpbfifo.c

Quoted 55 lines

new file mode 100644
index 0000000..929d017

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +50 -0
@@ -0,0 +1,560 @@
+/*
+ * LocalPlus Bus FIFO driver for the Freescale MPC52xx.
+ *
+ * Copyright (C) 2009 Secret Lab Technologies Ltd.
+ *
+ * This file is released under the GPLv2
+ *
+ * Todo:
+ * - Add support for multiple requests to be queued.
+ */
+
+#include <linux/interrupt.h>
+#include <linux/kernel.h>
+#include <linux/of.h>
+#include <linux/of_platform.h>
+#include <linux/spinlock.h>
+#include <asm/io.h>
+#include <asm/prom.h>
+#include <asm/mpc52xx.h>
+#include <asm/time.h>
+
+#include <sysdev/bestcomm/bestcomm.h>
+#include <sysdev/bestcomm/bestcomm_priv.h>
+#include <sysdev/bestcomm/gen_bd.h>
+
+MODULE_AUTHOR("Grant Likely <[email protected]>");
+MODULE_DESCRIPTION("MPC5200 LocalPlus FIFO device driver");
+MODULE_LICENSE("GPL");
+
+#define LPBFIFO_REG_PACKET_SIZE =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(0x00)
+#define LPBFIFO_REG_START_ADDRESS =A0 =A0 =A0(0x04)
+#define LPBFIFO_REG_CONTROL =A0 =A0 =A0 =A0 =A0 =A0(0x08)
+#define LPBFIFO_REG_ENABLE =A0 =A0 =A0 =A0 =A0 =A0 (0x0C)
+#define LPBFIFO_REG_BYTES_DONE_STATUS =A0(0x14)
+#define LPBFIFO_REG_FIFO_DATA =A0 =A0 =A0 =A0 =A0(0x40)
+#define LPBFIFO_REG_FIFO_STATUS =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(0x44)
+#define LPBFIFO_REG_FIFO_CONTROL =A0 =A0 =A0 (0x48)
+#define LPBFIFO_REG_FIFO_ALARM =A0 =A0 =A0 =A0 (0x4C)
+
+struct mpc52xx_lpbfifo {
+ =A0 =A0 =A0 struct device *dev;
+ =A0 =A0 =A0 phys_addr_t regs_phys;
+ =A0 =A0 =A0 void __iomem *regs;
+ =A0 =A0 =A0 int irq;
+ =A0 =A0 =A0 spinlock_t lock;
+
+ =A0 =A0 =A0 struct bcom_task *bcom_tx_task;
+ =A0 =A0 =A0 struct bcom_task *bcom_rx_task;
+ =A0 =A0 =A0 struct bcom_task *bcom_cur_task;
+

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 60

Quoted 10 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +10 -0
+ =A0 =A0 =A0 /* Current state data */
+ =A0 =A0 =A0 struct mpc52xx_lpbfifo_request *req;
+ =A0 =A0 =A0 int dma_irqs_enabled;
+};
+
+/* The MPC5200 has only one fifo, so only need one instance structure */
+static struct mpc52xx_lpbfifo lpbfifo;
+
+/**
+ * mpc52xx_lpbfifo_kick - Trigger the next block of data to be transfere=

d

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 72

Quoted 12 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +12 -0
+ */
+static void mpc52xx_lpbfifo_kick(struct mpc52xx_lpbfifo_request *req)
+{
+ =A0 =A0 =A0 size_t transfer_size =3D req->size - req->pos;
+ =A0 =A0 =A0 struct bcom_bd *bd;
+ =A0 =A0 =A0 void __iomem *reg;
+ =A0 =A0 =A0 u32 *data;
+ =A0 =A0 =A0 int i;
+ =A0 =A0 =A0 int bit_fields;
+ =A0 =A0 =A0 int dma =3D !(req->flags & MPC52XX_LPBFIFO_FLAG_NO_DMA);
+ =A0 =A0 =A0 int write =3D req->flags & MPC52XX_LPBFIFO_FLAG_WRITE;
+ =A0 =A0 =A0 int poll_dma =3D req->flags & MPC52XX_LPBFIFO_FLAG_POLL_DMA=

;

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 74

Quoted 2 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +2 -0
+
+ =A0 =A0 =A0 /* Set and clear the reset bits; is good practice in User M=

anual */

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 80

Quoted 6 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +6 -0
+ =A0 =A0 =A0 out_be32(lpbfifo.regs + LPBFIFO_REG_ENABLE, 0x01010000);
+
+ =A0 =A0 =A0 /* set master enable bit */
+ =A0 =A0 =A0 out_be32(lpbfifo.regs + LPBFIFO_REG_ENABLE, 0x00000001);
+ =A0 =A0 =A0 if (!dma) {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* While the FIFO can be setup for transfer=

sizes as large as

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 81

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* 16M-1, the FIFO itself is only 512 byt=

es deep and it does

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 82

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* not generate interrupts for FIFO full =

events (only transfer

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 83

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* complete will raise an IRQ). =A0Theref=

ore when not using

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 84

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* Bestcomm to drive the FIFO it needs to=

either be polled, or

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 85

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* transfers need to constrained to the s=

ize of the fifo.

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 87

Quoted 2 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +2 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0*
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* This driver restricts the size of the =

transfer

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 94

Quoted 7 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +7 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0*/
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (transfer_size > 512)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 transfer_size =3D 512;
+
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* Load the FIFO with data */
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (write) {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D lpbfifo.regs + LPBF=

IFO_REG_FIFO_DATA;

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 95

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 data =3D req->data + req->p=

os;

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 96

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 for (i =3D 0; i < transfer_=

size; i +=3D 4)

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 97

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 out_be32(re=

g, *data++);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 101

Quoted 4 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +4 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 }
+
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* Unmask both error and completion irqs */
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 out_be32(lpbfifo.regs + LPBFIFO_REG_ENABLE,=

0x00000301);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 105

Quoted 4 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +4 -0
+ =A0 =A0 =A0 } else {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* Choose the correct direction
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0*
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* Configure the watermarks so DMA will a=

lways complete correctly.

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 106

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* It may be worth experimenting with the=

ALARM value to see if

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 107

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* there is a performance impacit. =A0How=

ever, if it is wrong there

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 108

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* is a risk of DMA not transferring the =

last chunk of data

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 111

Quoted 3 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +3 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0*/
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (write) {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 out_be32(lpbfifo.regs + LPB=

FIFO_REG_FIFO_ALARM, 0x1e4);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 112

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 out_8(lpbfifo.regs + LPBFIF=

O_REG_FIFO_CONTROL, 7);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 113

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 lpbfifo.bcom_cur_task =3D l=

pbfifo.bcom_tx_task;

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 115

Quoted 2 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +2 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 } else {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 out_be32(lpbfifo.regs + LPB=

FIFO_REG_FIFO_ALARM, 0x1ff);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 116

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 out_8(lpbfifo.regs + LPBFIF=

O_REG_FIFO_CONTROL, 0);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 117

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 lpbfifo.bcom_cur_task =3D l=

pbfifo.bcom_rx_task;

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 120

Quoted 3 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +3 -0
+
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (poll_dma) {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (lpbfifo=

.dma_irqs_enabled) {

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 121

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=

=A0 disable_irq(bcom_get_task_irq(lpbfifo.bcom_rx_task));

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 122

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=

=A0 lpbfifo.dma_irqs_enabled =3D 0;

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 125

Quoted 3 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +3 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 }
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 } else {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (!lpbfif=

o.dma_irqs_enabled) {

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 126

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=

=A0 enable_irq(bcom_get_task_irq(lpbfifo.bcom_rx_task));

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 127

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=

=A0 lpbfifo.dma_irqs_enabled =3D 1;

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 132

Quoted 5 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +5 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 }
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 }
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 }
+
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 bd =3D bcom_prepare_next_buffer(lpbfifo.bco=

m_cur_task);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 136

Quoted 4 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +4 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 bd->status =3D transfer_size;
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (!write) {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 /*
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* In the DMA read case, =

the DMA doesn't complete,

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 137

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* possibly due to incorr=

ect watermarks in the ALARM

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 138

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* and CONTROL regs. For =

now instead of trying to

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 139

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* determine the right wa=

termarks that will make this

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 140

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* work, just increase th=

e number of bytes the FIFO is

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 143

Quoted 3 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +3 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* expecting.
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0*
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* When submitting anothe=

r operation, the FIFO will get

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 144

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* reset, so the conditio=

n of the FIFO waiting for a

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 145

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* non-existent 4 bytes w=

ill get cleared.

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 147

Quoted 2 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +2 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0*/
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 transfer_size +=3D 4; /* BL=

ECH! */

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 150

Quoted 3 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +3 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 }
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 bd->data[0] =3D req->data_phys + req->pos;
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 bcom_submit_next_buffer(lpbfifo.bcom_cur_ta=

sk, NULL);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 157

Quoted 7 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +7 -0
+
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* error irq & master enabled bit */
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 bit_fields =3D 0x00000201;
+
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* Unmask irqs */
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (write && (!poll_dma))
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 bit_fields |=3D 0x00000100;=

/* completion irq too */

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 158

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 out_be32(lpbfifo.regs + LPBFIFO_REG_ENABLE,=

bit_fields);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 164

Quoted 6 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +6 -0
+ =A0 =A0 =A0 }
+
+ =A0 =A0 =A0 /* Set transfer size, width, chip select and READ mode */
+ =A0 =A0 =A0 out_be32(lpbfifo.regs + LPBFIFO_REG_START_ADDRESS,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0req->offset + req->pos);
+ =A0 =A0 =A0 out_be32(lpbfifo.regs + LPBFIFO_REG_PACKET_SIZE, transfer_s=

ize);

Quoted 6 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +6 -0
+
+ =A0 =A0 =A0 bit_fields =3D req->cs << 24 | 0x000008;
+ =A0 =A0 =A0 if (!write)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 bit_fields |=3D 0x010000; /* read mode */
+ =A0 =A0 =A0 out_be32(lpbfifo.regs + LPBFIFO_REG_CONTROL, bit_fields);
+

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 180

Quoted 10 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +10 -0
+ =A0 =A0 =A0 /* Kick it off */
+ =A0 =A0 =A0 out_8(lpbfifo.regs + LPBFIFO_REG_PACKET_SIZE, 0x01);
+ =A0 =A0 =A0 if (dma)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 bcom_enable(lpbfifo.bcom_cur_task);
+}
+
+/**
+ * mpc52xx_lpbfifo_irq - IRQ handler for LPB FIFO
+ *
+ * On transmit, the dma completion irq triggers before the fifo completi=

on

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 181

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ * triggers. =A0Handle the dma completion here instead of the LPB FIFO B=

estcomm

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 182

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ * task completion irq becuase everyting is not really done until the LP=

B FIFO

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c

Quoted 5 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +5 -0
+ * completion irq triggers.
+ *
+ * In other words:
+ * For DMA, on receive, the "Fat Lady" is the bestcom completion irq. on
+ * transmit, the fifo completion irq is the "Fat Lady". The opera (or in=

this

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 188

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ * case the DMA/FIFO operation) is not finished until the "Fat Lady" sin=

gs.

Quoted 11 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +11 -0
+ *
+ * Reasons for entering this routine:
+ * 1) PIO mode rx and tx completion irq
+ * 2) DMA interrupt mode tx completion irq
+ * 3) DMA polled mode tx
+ *
+ * Exit conditions:
+ * 1) Transfer aborted
+ * 2) FIFO complete without DMA; more data to do
+ * 3) FIFO complete without DMA; all data transfered
+ * 4) FIFO complete using DMA

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c

Quoted 10 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +10 -0
+ *
+ * Condition 1 can occur regardless of whether or not DMA is used.
+ * It requires executing the callback to report the error and exiting
+ * immediately.
+ *
+ * Condition 2 requires programming the FIFO with the next block of data
+ *
+ * Condition 3 requires executing the callback to report completion
+ *
+ * Condition 4 means the same as 3, except that we also retrieve the bco=

m

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c

Quoted 12 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +12 -0
+ * buffer so DMA doesn't get clogged up.
+ *
+ * To make things trickier, the spinlock must be dropped before
+ * executing the callback, otherwise we could end up with a deadlock
+ * or nested spinlock condition. =A0The out path is non-trivial, so
+ * extra fiddling is done to make sure all paths lead to the same
+ * outbound code.
+ */
+static irqreturn_t mpc52xx_lpbfifo_irq(int irq, void *dev_id)
+{
+ =A0 =A0 =A0 struct mpc52xx_lpbfifo_request *req;
+ =A0 =A0 =A0 u32 status =3D in_8(lpbfifo.regs + LPBFIFO_REG_BYTES_DONE_S=

TATUS);

Quoted 4 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +4 -0
+ =A0 =A0 =A0 void __iomem *reg;
+ =A0 =A0 =A0 u32 *data;
+ =A0 =A0 =A0 int count, i;
+ =A0 =A0 =A0 int do_callback =3D 0;

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 235

Quoted 10 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +10 -0
+ =A0 =A0 =A0 u32 ts;
+ =A0 =A0 =A0 unsigned long flags;
+ =A0 =A0 =A0 int dma, write, poll_dma;
+
+ =A0 =A0 =A0 spin_lock_irqsave(&lpbfifo.lock, flags);
+ =A0 =A0 =A0 ts =3D get_tbl();
+
+ =A0 =A0 =A0 req =3D lpbfifo.req;
+ =A0 =A0 =A0 if (!req) {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 spin_unlock_irqrestore(&lpbfifo.lock, flags=

);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 245

Quoted 10 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +10 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 pr_err("bogus LPBFIFO IRQ\n");
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 return IRQ_HANDLED;
+ =A0 =A0 =A0 }
+
+ =A0 =A0 =A0 dma =3D !(req->flags & MPC52XX_LPBFIFO_FLAG_NO_DMA);
+ =A0 =A0 =A0 write =3D req->flags & MPC52XX_LPBFIFO_FLAG_WRITE;
+ =A0 =A0 =A0 poll_dma =3D req->flags & MPC52XX_LPBFIFO_FLAG_POLL_DMA;
+
+ =A0 =A0 =A0 if (dma && !write) {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 spin_unlock_irqrestore(&lpbfifo.lock, flags=

);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 246

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 pr_err("bogus LPBFIFO IRQ (dma and not writ=

ting)\n");

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 256

Quoted 10 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +10 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 return IRQ_HANDLED;
+ =A0 =A0 =A0 }
+
+ =A0 =A0 =A0 if ((status & 0x01) =3D=3D 0) {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 goto out;
+ =A0 =A0 =A0 }
+
+ =A0 =A0 =A0 /* check abort bit */
+ =A0 =A0 =A0 if (status & 0x10) {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 out_be32(lpbfifo.regs + LPBFIFO_REG_ENABLE,=

0x01010000);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 262

Quoted 6 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +6 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 do_callback =3D 1;
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 goto out;
+ =A0 =A0 =A0 }
+
+ =A0 =A0 =A0 /* Read result from hardware */
+ =A0 =A0 =A0 count =3D in_be32(lpbfifo.regs + LPBFIFO_REG_BYTES_DONE_STA=

TUS);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 267

Quoted 5 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +5 -0
+ =A0 =A0 =A0 count &=3D 0x00ffffff;
+
+ =A0 =A0 =A0 if (!dma && !write) {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* copy the data out of the FIFO */
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D lpbfifo.regs + LPBFIFO_REG_FIFO_DAT=

A;

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 278

Quoted 11 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +11 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 data =3D req->data + req->pos;
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 for (i =3D 0; i < count; i +=3D 4)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 *data++ =3D in_be32(reg);
+ =A0 =A0 =A0 }
+
+ =A0 =A0 =A0 /* Update transfer position and count */
+ =A0 =A0 =A0 req->pos +=3D count;
+
+ =A0 =A0 =A0 /* Decide what to do next */
+ =A0 =A0 =A0 if (req->size - req->pos)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 mpc52xx_lpbfifo_kick(req); /* more work to =

do */

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 288

Quoted 10 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +10 -0
+ =A0 =A0 =A0 else
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 do_callback =3D 1;
+
+ out:
+ =A0 =A0 =A0 /* Clear the IRQ */
+ =A0 =A0 =A0 out_8(lpbfifo.regs + LPBFIFO_REG_BYTES_DONE_STATUS, 0x01);
+
+ =A0 =A0 =A0 if (dma && (status & 0x11)) {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 /*
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* Count the DMA as complete only when th=

e FIFO completion

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 291

Quoted 3 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +3 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* status or abort bits are set.
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0*
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* (status & 0x01) should always be the c=

ase except sometimes

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 294

Quoted 3 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +3 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* when using polled DMA.
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0*
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* (status & 0x10) {transfer aborted}: Th=

is case needs more

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 297

Quoted 3 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +3 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* testing.
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0*/
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 bcom_retrieve_buffer(lpbfifo.bcom_cur_task,=

&status, NULL);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 301

Quoted 4 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +4 -0
+ =A0 =A0 =A0 }
+ =A0 =A0 =A0 req->last_byte =3D ((u8 *)req->data)[req->size - 1];
+
+ =A0 =A0 =A0 /* When the do_callback flag is set; it means the transfer =

is finished

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 312

Quoted 11 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +11 -0
+ =A0 =A0 =A0 =A0* so set the FIFO as idle */
+ =A0 =A0 =A0 if (do_callback)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 lpbfifo.req =3D NULL;
+
+ =A0 =A0 =A0 if (irq !=3D 0) /* don't increment on polled case */
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 req->irq_count++;
+
+ =A0 =A0 =A0 req->irq_ticks +=3D get_tbl() - ts;
+ =A0 =A0 =A0 spin_unlock_irqrestore(&lpbfifo.lock, flags);
+
+ =A0 =A0 =A0 /* Spinlock is released; it is now safe to call the callbac=

k */

Quoted 14 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +14 -0
+ =A0 =A0 =A0 if (do_callback && req->callback)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 req->callback(req);
+
+ =A0 =A0 =A0 return IRQ_HANDLED;
+}
+
+/**
+ * mpc52xx_lpbfifo_bcom_irq - IRQ handler for LPB FIFO Bestcomm task
+ *
+ * Only used when receiving data.
+ */
+static irqreturn_t mpc52xx_lpbfifo_bcom_irq(int irq, void *dev_id)
+{
+ =A0 =A0 =A0 struct mpc52xx_lpbfifo_request *req;

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c

Quoted 10 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +10 -0
+ =A0 =A0 =A0 unsigned long flags;
+ =A0 =A0 =A0 u32 status;
+ =A0 =A0 =A0 u32 ts;
+
+ =A0 =A0 =A0 spin_lock_irqsave(&lpbfifo.lock, flags);
+ =A0 =A0 =A0 ts =3D get_tbl();
+
+ =A0 =A0 =A0 req =3D lpbfifo.req;
+ =A0 =A0 =A0 if (!req || (req->flags & MPC52XX_LPBFIFO_FLAG_NO_DMA)) {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 spin_unlock_irqrestore(&lpbfifo.lock, flags=

);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 344

Quoted 8 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +8 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 return IRQ_HANDLED;
+ =A0 =A0 =A0 }
+
+ =A0 =A0 =A0 if (irq !=3D 0) /* don't increment on polled case */
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 req->irq_count++;
+
+ =A0 =A0 =A0 if (!bcom_buffer_done(lpbfifo.bcom_cur_task)) {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 spin_unlock_irqrestore(&lpbfifo.lock, flags=

);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 347

Quoted 3 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +3 -0
+
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 req->buffer_not_done_cnt++;
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 if ((req->buffer_not_done_cnt % 1000) =3D=

=3D 0)

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 348

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 pr_err("transfer stalled\n"=

);

Quoted 46 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +46 -0
+
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 return IRQ_HANDLED;
+ =A0 =A0 =A0 }
+
+ =A0 =A0 =A0 bcom_retrieve_buffer(lpbfifo.bcom_cur_task, &status, NULL);
+
+ =A0 =A0 =A0 req->last_byte =3D ((u8 *)req->data)[req->size - 1];
+
+ =A0 =A0 =A0 req->pos =3D status & 0x00ffffff;
+
+ =A0 =A0 =A0 /* Mark the FIFO as idle */
+ =A0 =A0 =A0 lpbfifo.req =3D NULL;
+
+ =A0 =A0 =A0 /* Release the lock before calling out to the callback. */
+ =A0 =A0 =A0 req->irq_ticks +=3D get_tbl() - ts;
+ =A0 =A0 =A0 spin_unlock_irqrestore(&lpbfifo.lock, flags);
+
+ =A0 =A0 =A0 if (req->callback)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 req->callback(req);
+
+ =A0 =A0 =A0 return IRQ_HANDLED;
+}
+
+/**
+ * mpc52xx_lpbfifo_bcom_poll - Poll for DMA completion
+ */
+void mpc52xx_lpbfifo_poll(void)
+{
+ =A0 =A0 =A0 struct mpc52xx_lpbfifo_request *req =3D lpbfifo.req;
+ =A0 =A0 =A0 int dma =3D !(req->flags & MPC52XX_LPBFIFO_FLAG_NO_DMA);
+ =A0 =A0 =A0 int write =3D req->flags & MPC52XX_LPBFIFO_FLAG_WRITE;
+
+ =A0 =A0 =A0 /*
+ =A0 =A0 =A0 =A0* For more information, see comments on the "Fat Lady"
+ =A0 =A0 =A0 =A0*/
+ =A0 =A0 =A0 if (dma && write)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 mpc52xx_lpbfifo_irq(0, NULL);
+ =A0 =A0 =A0 else
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 mpc52xx_lpbfifo_bcom_irq(0, NULL);
+}
+EXPORT_SYMBOL(mpc52xx_lpbfifo_poll);
+
+/**
+ * mpc52xx_lpbfifo_submit - Submit an LPB FIFO transfer request.
+ * @req: Pointer to request structure
+ */

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c

Quoted 10 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +10 -0
+int mpc52xx_lpbfifo_submit(struct mpc52xx_lpbfifo_request *req)
+{
+ =A0 =A0 =A0 unsigned long flags;
+
+ =A0 =A0 =A0 if (!lpbfifo.regs)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 return -ENODEV;
+
+ =A0 =A0 =A0 spin_lock_irqsave(&lpbfifo.lock, flags);
+
+ =A0 =A0 =A0 /* If the req pointer is already set, then a transfer is in=

progress */

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 406

Quoted 2 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +2 -0
+ =A0 =A0 =A0 if (lpbfifo.req) {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 spin_unlock_irqrestore(&lpbfifo.lock, flags=

);

Quoted 16 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +16 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 return -EBUSY;
+ =A0 =A0 =A0 }
+
+ =A0 =A0 =A0 /* Setup the transfer */
+ =A0 =A0 =A0 lpbfifo.req =3D req;
+ =A0 =A0 =A0 req->irq_count =3D 0;
+ =A0 =A0 =A0 req->irq_ticks =3D 0;
+ =A0 =A0 =A0 req->buffer_not_done_cnt =3D 0;
+ =A0 =A0 =A0 req->pos =3D 0;
+
+ =A0 =A0 =A0 mpc52xx_lpbfifo_kick(req);
+ =A0 =A0 =A0 spin_unlock_irqrestore(&lpbfifo.lock, flags);
+ =A0 =A0 =A0 return 0;
+}
+EXPORT_SYMBOL(mpc52xx_lpbfifo_submit);
+

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 432

Quoted 10 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +10 -0
+void mpc52xx_lpbfifo_abort(struct mpc52xx_lpbfifo_request *req)
+{
+ =A0 =A0 =A0 unsigned long flags;
+
+ =A0 =A0 =A0 spin_lock_irqsave(&lpbfifo.lock, flags);
+ =A0 =A0 =A0 if (lpbfifo.req =3D=3D req) {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* Put it into reset and clear the state */
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 bcom_gen_bd_rx_reset(lpbfifo.bcom_rx_task);
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 bcom_gen_bd_tx_reset(lpbfifo.bcom_tx_task);
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 out_be32(lpbfifo.regs + LPBFIFO_REG_ENABLE,=

0x01010000);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c

Quoted 8 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +8 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 lpbfifo.req =3D NULL;
+ =A0 =A0 =A0 }
+ =A0 =A0 =A0 spin_unlock_irqrestore(&lpbfifo.lock, flags);
+}
+EXPORT_SYMBOL(mpc52xx_lpbfifo_abort);
+
+static int __devinit
+mpc52xx_lpbfifo_probe(struct of_device *op, const struct of_device_id *m=

atch)

Quoted 16 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +16 -0
+{
+ =A0 =A0 =A0 struct resource res;
+ =A0 =A0 =A0 int rc =3D -ENOMEM;
+
+ =A0 =A0 =A0 if (lpbfifo.dev !=3D NULL)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 return -ENOSPC;
+
+ =A0 =A0 =A0 lpbfifo.irq =3D irq_of_parse_and_map(op->node, 0);
+ =A0 =A0 =A0 if (!lpbfifo.irq)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 return -ENODEV;
+
+ =A0 =A0 =A0 if (of_address_to_resource(op->node, 0, &res))
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 return -ENODEV;
+ =A0 =A0 =A0 lpbfifo.regs_phys =3D res.start;
+ =A0 =A0 =A0 lpbfifo.regs =3D of_iomap(op->node, 0);
+ =A0 =A0 =A0 if (!lpbfifo.regs)

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 466

Quoted 10 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +10 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 return -ENOMEM;
+
+ =A0 =A0 =A0 spin_lock_init(&lpbfifo.lock);
+
+ =A0 =A0 =A0 /* Put FIFO into reset */
+ =A0 =A0 =A0 out_be32(lpbfifo.regs + LPBFIFO_REG_ENABLE, 0x01010000);
+
+ =A0 =A0 =A0 /* Register the interrupt handler */
+ =A0 =A0 =A0 rc =3D request_irq(lpbfifo.irq, mpc52xx_lpbfifo_irq, 0,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"mpc52xx-lpbfifo", &lpbf=

ifo);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 470

Quoted 4 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +4 -0
+ =A0 =A0 =A0 if (rc)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 goto err_irq;
+
+ =A0 =A0 =A0 /* Request the Bestcomm receive (fifo --> memory) task and =

IRQ */

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 472

Quoted 2 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +2 -0
+ =A0 =A0 =A0 lpbfifo.bcom_rx_task =3D
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 bcom_gen_bd_rx_init(2, res.start + LPBFIFO_=

REG_FIFO_DATA,

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 473

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 BCO=

M_INITIATOR_SCLPC, BCOM_IPR_SCLPC,

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 474

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 16*=

1024*1024);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 479

Quoted 5 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +5 -0
+ =A0 =A0 =A0 if (!lpbfifo.bcom_rx_task)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 goto err_bcom_rx;
+
+ =A0 =A0 =A0 rc =3D request_irq(bcom_get_task_irq(lpbfifo.bcom_rx_task),
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0mpc52xx_lpbfifo_bcom_irq=

, 0,

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 480

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"mpc52xx-lpbfifo-rx", &l=

pbfifo);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 484

Quoted 4 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +4 -0
+ =A0 =A0 =A0 if (rc)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 goto err_bcom_rx_irq;
+
+ =A0 =A0 =A0 /* Request the Bestcomm transmit (memory --> fifo) task and=

IRQ */

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 486

Quoted 2 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +2 -0
+ =A0 =A0 =A0 lpbfifo.bcom_tx_task =3D
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 bcom_gen_bd_tx_init(2, res.start + LPBFIFO_=

REG_FIFO_DATA,

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 487

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 BCO=

M_INITIATOR_SCLPC, BCOM_IPR_SCLPC);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 495

Quoted 8 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +8 -0
+ =A0 =A0 =A0 if (!lpbfifo.bcom_tx_task)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 goto err_bcom_tx;
+
+ =A0 =A0 =A0 lpbfifo.dev =3D &op->dev;
+ =A0 =A0 =A0 return 0;
+
+ err_bcom_tx:
+ =A0 =A0 =A0 free_irq(bcom_get_task_irq(lpbfifo.bcom_rx_task), &lpbfifo)=

;

Quoted 12 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +12 -0
+ err_bcom_rx_irq:
+ =A0 =A0 =A0 bcom_gen_bd_rx_release(lpbfifo.bcom_rx_task);
+ err_bcom_rx:
+ err_irq:
+ =A0 =A0 =A0 iounmap(lpbfifo.regs);
+ =A0 =A0 =A0 lpbfifo.regs =3D NULL;
+
+ =A0 =A0 =A0 dev_err(&op->dev, "mpc52xx_lpbfifo_probe() failed\n");
+ =A0 =A0 =A0 return -ENODEV;
+}
+
+

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c

Quoted 10 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +10 -0
+static int __devexit mpc52xx_lpbfifo_remove(struct of_device *op)
+{
+ =A0 =A0 =A0 if (lpbfifo.dev !=3D &op->dev)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 return 0;
+
+ =A0 =A0 =A0 /* Put FIFO in reset */
+ =A0 =A0 =A0 out_be32(lpbfifo.regs + LPBFIFO_REG_ENABLE, 0x01010000);
+
+ =A0 =A0 =A0 /* Release the bestcomm transmit task */
+ =A0 =A0 =A0 free_irq(bcom_get_task_irq(lpbfifo.bcom_tx_task), &lpbfifo)=

;

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 521

Quoted 4 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +4 -0
+ =A0 =A0 =A0 bcom_gen_bd_tx_release(lpbfifo.bcom_tx_task);
+
+ =A0 =A0 =A0 /* Release the bestcomm receive task */
+ =A0 =A0 =A0 free_irq(bcom_get_task_irq(lpbfifo.bcom_rx_task), &lpbfifo)=

;

Quoted 20 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +20 -0
+ =A0 =A0 =A0 bcom_gen_bd_rx_release(lpbfifo.bcom_rx_task);
+
+ =A0 =A0 =A0 free_irq(lpbfifo.irq, &lpbfifo);
+ =A0 =A0 =A0 iounmap(lpbfifo.regs);
+ =A0 =A0 =A0 lpbfifo.regs =3D NULL;
+ =A0 =A0 =A0 lpbfifo.dev =3D NULL;
+
+ =A0 =A0 =A0 return 0;
+}
+
+static struct of_device_id mpc52xx_lpbfifo_match[] __devinitconst =3D {
+ =A0 =A0 =A0 { .compatible =3D "fsl,mpc5200-lpbfifo", },
+ =A0 =A0 =A0 {},
+};
+
+static struct of_platform_driver mpc52xx_lpbfifo_driver =3D {
+ =A0 =A0 =A0 .owner =3D THIS_MODULE,
+ =A0 =A0 =A0 .name =3D "mpc52xx-lpbfifo",
+ =A0 =A0 =A0 .match_table =3D mpc52xx_lpbfifo_match,
+ =A0 =A0 =A0 .probe =3D mpc52xx_lpbfifo_probe,

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 551

Quoted 10 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +10 -0
+ =A0 =A0 =A0 .remove =3D __devexit_p(mpc52xx_lpbfifo_remove),
+};
+
+/***********************************************************************
+ * Module init/exit
+ */
+static int __init mpc52xx_lpbfifo_init(void)
+{
+ =A0 =A0 =A0 pr_debug("Registering LocalPlus bus FIFO driver\n");
+ =A0 =A0 =A0 return of_register_platform_driver(&mpc52xx_lpbfifo_driver)=

;

Quoted 10 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +9 -0
+}
+module_init(mpc52xx_lpbfifo_init);
+
+static void __exit mpc52xx_lpbfifo_exit(void)
+{
+ =A0 =A0 =A0 pr_debug("Unregistering LocalPlus bus FIFO driver\n");
+ =A0 =A0 =A0 of_unregister_platform_driver(&mpc52xx_lpbfifo_driver);
+}
+module_exit(mpc52xx_lpbfifo_exit);
Quoted 5 lines

_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev

--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

#2 lore raw
In reply to John Bonesio

Hi John:

Cool stuff - Grant's original one also helped me a lot to get Bestcomm running for me (I use it only for read dma)!

Am 29.09.09 22:43 schrieb(en) John Bonesio:
[snip]

Quoted 18 lines
(quoted diff) +1 -0
+		 * It may be worth experimenting with the ALARM value  

to see if

(quoted diff) +1 -0
+		 * there is a performance impacit.  However, if it is  

wrong there

(quoted diff) +1 -0
+		 * is a risk of DMA not transferring the last chunk of  

data

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +3 -0
+		 */
+		if (write) {
+			out_be32(lpbfifo.regs + LPBFIFO_REG_FIFO_ALARM,  

0x1e4);

(quoted diff) +1 -0
+			out_8(lpbfifo.regs + LPBFIFO_REG_FIFO_CONTROL,  

7);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +3 -0
+			lpbfifo.bcom_cur_task = lpbfifo.bcom_tx_task;
+		} else {
+			out_be32(lpbfifo.regs + LPBFIFO_REG_FIFO_ALARM,  

0x1ff);

(quoted diff) +1 -0
+			out_8(lpbfifo.regs + LPBFIFO_REG_FIFO_CONTROL,  

0);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 117

Quoted 1 line
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+			lpbfifo.bcom_cur_task = lpbfifo.bcom_rx_task;

Hmmm, the MPC5200B User's manual, sect. 9.7.3.3 LPC Rx/Tx FIFO Control Register (pg. 323) seems to imply that only 0 or 1 are valid settings here. Where does the 7 come from?

[snip]

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 141

Quoted 11 lines
(quoted diff) +1 -0
+			 * In the DMA read case, the DMA doesn't  

complete,

(quoted diff) +1 -0
+			 * possibly due to incorrect watermarks in the  

ALARM

(quoted diff) +1 -0
+			 * and CONTROL regs. For now instead of trying  

to

(quoted diff) +1 -0
+			 * determine the right watermarks that will  

make this

(quoted diff) +1 -0
+			 * work, just increase the number of bytes the  

FIFO is

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+			 * expecting.

My experience is that for reads I have to set a granularity of 0 (as you already do) *and* set the 'flush' bit in the SCLPC Control Register. See the remarks for that bit in the MPC5200B User's manual, pg. 318. With these settings and my driver, I made several tests reading blocks (in one Bestcomm operation) between 16 bytes and 2 MBytes, and *never* had any problem, so your remark here makes me somewhat nervous!

In my dma read tests, the watermark (LPC Rx/Tx FIFO Alarm Register) seems to have only a (small) performance impact. If I set the watermark to 0 (i.e. fill the fifo completely), I *never* saw any under- or overruns. My assumption is that the fifo would stop reading the peripheral when it is full, and only resume when Bestcomm emptied it at least partly. You you know if that is really the case?

[snip]

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 168

Quoted 4 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +4 -0
+
+	bit_fields = req->cs << 24 | 0x000008;
+	if (!write)
+		bit_fields |= 0x010000; /* read mode */

See above - should be "bit_fields |= 0x030000" IMHO...

[snip]

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 474

Quoted 8 lines
(quoted diff) +1 -0
+	/* Request the Bestcomm receive (fifo --> memory) task and IRQ  

*/

(quoted diff) +2 -0
+	lpbfifo.bcom_rx_task =
+		bcom_gen_bd_rx_init(2, res.start +  

LPBFIFO_REG_FIFO_DATA,

(quoted diff) +1 -0
+				    BCOM_INITIATOR_SCLPC,  

BCOM_IPR_SCLPC,

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+				    16*1024*1024);

Is the limit really correct? The manual (sect. 9.7.2.1 SCLPC Packet Size Register, pg. 316) says the maximum packet size is 16 M - 1 byte.

Cheers,
Albrecht.

#3 lore raw

Hi Albrecht,

Thanks for the comments. My replies are below.

- John

Quoted 22 lines · Albrecht Dreß

Hi John:

Cool stuff - Grant's original one also helped me a lot to get Bestcomm running for me (I use it only for read dma)!

Am 29.09.09 22:43 schrieb(en) John Bonesio:
[snip]

Quoted 15 lines
(quoted diff) +1 -0
+		 * It may be worth experimenting with the ALARM value  

to see if

(quoted diff) +1 -0
+		 * there is a performance impacit.  However, if it is  

wrong there

(quoted diff) +1 -0
+		 * is a risk of DMA not transferring the last chunk of  

data

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +3 -0
+		 */
+		if (write) {
+			out_be32(lpbfifo.regs + LPBFIFO_REG_FIFO_ALARM,  

0x1e4);

(quoted diff) +1 -0
+			out_8(lpbfifo.regs + LPBFIFO_REG_FIFO_CONTROL,  

7);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +3 -0
+			lpbfifo.bcom_cur_task = lpbfifo.bcom_tx_task;
+		} else {
+			out_be32(lpbfifo.regs + LPBFIFO_REG_FIFO_ALARM,  
Quoted 8 lines

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 117

Quoted 4 lines

0x1ff);

(quoted diff) +1 -0
+			out_8(lpbfifo.regs + LPBFIFO_REG_FIFO_CONTROL,  

0);

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+			lpbfifo.bcom_cur_task = lpbfifo.bcom_rx_task;

Hmmm, the MPC5200B User's manual, sect. 9.7.3.3 LPC Rx/Tx FIFO Control Register (pg. 323) seems to imply that only 0 or 1 are valid settings here. Where does the 7 come from?

When I read that section, I read that GR is a 3 bit field for high water mark (the number of free bytes * 4). I didn't read that 0 and 1 are the only possible values, but that those are two example values to help the reader understand the meaning of the field.

Nowhere in the text does it say 0 and 1 are the only possible values. And since GR is a 3 bit field instead of a 1 bit field, that implied that to me that other values are allowed.

I can see how one could read the text as saying 0 and 1 are the only values allowed. However, empirical the testing I've done, seems to indicate that the '7' is a valid value, as it produced different behavior than 1.

Quoted 14 lines

[snip]

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 141

Quoted 11 lines
(quoted diff) +1 -0
+			 * In the DMA read case, the DMA doesn't  

complete,

(quoted diff) +1 -0
+			 * possibly due to incorrect watermarks in the  

ALARM

(quoted diff) +1 -0
+			 * and CONTROL regs. For now instead of trying  

to

(quoted diff) +1 -0
+			 * determine the right watermarks that will  

make this

(quoted diff) +1 -0
+			 * work, just increase the number of bytes the  

FIFO is

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+			 * expecting.
Quoted 7 lines

My experience is that for reads I have to set a granularity of 0 (as you already do) *and* set the 'flush' bit in the SCLPC Control Register. See the remarks for that bit in the MPC5200B User's manual, pg. 318. With these settings and my driver, I made several tests reading blocks (in one Bestcomm operation) between 16 bytes and 2 MBytes, and *never* had any problem, so your remark here makes me somewhat nervous!

I've put in the suggested change to set the 'flush' bit. It didn't seem to help. I'm not sure what else might be different between my system and yours.

I agree that this solution feels "hacky" and is probably not a good long term solution. I think this solution may need to stay in temporarily until we can discover a better one.

Quoted 7 lines

In my dma read tests, the watermark (LPC Rx/Tx FIFO Alarm Register) seems to have only a (small) performance impact. If I set the watermark to 0 (i.e. fill the fifo completely), I *never* saw any under- or overruns. My assumption is that the fifo would stop reading the peripheral when it is full, and only resume when Bestcomm emptied it at least partly. You you know if that is really the case?

We were testing using the Bestcomm on a framebuffer to refresh the display. Without the watermarks, the DMA was getting clogged.

Quoted 10 lines

[snip]

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 168

Quoted 4 lines
arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +4 -0
+
+	bit_fields = req->cs << 24 | 0x000008;
+	if (!write)
+		bit_fields |= 0x010000; /* read mode */

See above - should be "bit_fields |= 0x030000" IMHO...

[snip]

Quoted 11 lines

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c line 474

Quoted 8 lines
(quoted diff) +1 -0
+	/* Request the Bestcomm receive (fifo --> memory) task and IRQ  

*/

(quoted diff) +2 -0
+	lpbfifo.bcom_rx_task =
+		bcom_gen_bd_rx_init(2, res.start +  

LPBFIFO_REG_FIFO_DATA,

(quoted diff) +1 -0
+				    BCOM_INITIATOR_SCLPC,  

BCOM_IPR_SCLPC,

arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c new file +1 -0
+				    16*1024*1024);

Is the limit really correct? The manual (sect. 9.7.2.1 SCLPC Packet Size Register, pg. 316) says the maximum packet size is 16 M - 1 byte.

You are right. I've made the fix. A new patch will go out soon.

Quoted 7 lines

Cheers,
Albrecht.
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev

#4 lore raw

Hi John:

Am 01.10.09 20:45 schrieb(en) John Bonesio:

Quoted 3 lines

Nowhere in the text does it say 0 and 1 are the only possible values. And since GR is a 3 bit field instead of a 1 bit field, that implied that to me that other values are allowed.

I can see how one could read the text as saying 0 and 1 are the only values allowed. However, empirical the testing I've done, seems to indicate that the '7' is a valid value, as it produced different behavior than 1.

Thanks for the clarification!

Quoted 1 line

I've put in the suggested change to set the 'flush' bit. It didn't seem to help. I'm not sure what else might be different between my system and yours.

My board is a self-designed one, roughly Icecube-based, with a 5200B. The peripheral (actually a second processor) is attached in 16-bit mode to the LPB. The main data flow goes to the 5200, so I have only a task for reading data. As the block transfer is only one part (but with a huge block size) in a transaction, I allocate only one block for the task, i.e. I call bcom_gen_bd_rx_init(1, ...).

The transaction size is always a multiple of 4 bytes, and I use the same value for the FIFO packet size and struct bcom_bd::status. In the Control reg, I set CS, BPT=4, DAI, RWb and Flush. I can isolate the code launching Bestcomm if you're interested.

I ran some further tests today, which are a little confusing...

When a Bestcomm IRQ arrives, the call to bcom_buffer_done() (in the isr) will always return 0. If I just ignore that, and call bcom_retrieve_buffer() anyway, the status value will also be 0. However, the data block is transferred completely, and it is correct (I separately transmit a crc32, which matches, and the data block itself looks fine). Actually, I'm not really sure what this means...

BTW, I noticed that the Bestcomm IRQ arrives *before* the FIFO IRQ, which IMHO is a little unlogical. It may be a result of setting the granularity to 0 and the FIFO Alarm level to 4 (which should trigger Bestcomm only if one u32 is free in the FIFO - is that correct? At least the drawing on Pg. 11 in Freescale's AN2604 implies that.).

Quoted 1 line

We were testing using the Bestcomm on a framebuffer to refresh the display. Without the watermarks, the DMA was getting clogged.

I see. In my case, only the /overall/ time and cpu load for the transaction are critical, and there I didn't notice significant differences.

Cheers,
Albrecht.