Skip to contentSkip to conversation

Zoom2 Fix serial setup

U-Boot New Tom Rix 3 participants 5 messages Oct 5, 2009 – Oct 12, 2009

lore
Share & tools
lore

Tom Rix

author
#0 lore raw

This patch is against u-boot-ti/master

I run tested this on Zoom2.

Tom

author
#1 lore raw

PATCH 1/1 Zoom2 Fix serial gpmc setup

The offset to the chip select is incorrect.

The change 187af954cf7958c24efcf0fd62289bbdb4f1f24e,

omap3: embedd gpmc_cs into gpmc config struct

introduced a problem with the serial gpmc setup.

This patch reverts the chip select to its previous value.

The symptoms of this problem are that the Zoom2
currently hangs.

This was run tested on Zoom2.

---
 board/logicpd/zoom2/zoom2.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
board/logicpd/zoom2/zoom2.c +1 -1
index d9e2ae5..cd8c9fe 100644
@@ -129,7 +129,7 @@ int board_init (void)
 
 	/* Configure console support on zoom2 */
 	gpmc_config = gpmc_serial_TL16CP754C;
-	enable_gpmc_cs_config(gpmc_config, &gpmc_cfg->cs[4],
+	enable_gpmc_cs_config(gpmc_config, &gpmc_cfg->cs[3],
 			SERIAL_TL16CP754C_BASE, GPMC_SIZE_16M);
 
 	/* board id for Linux */
Signature · 1 line
1.6.0.6
#2 lore raw

PATCH 1/1 Zoom2 Fix serial gpmc setup

Quoted 35 lines

The offset to the chip select is incorrect.

The change 187af954cf7958c24efcf0fd62289bbdb4f1f24e,

omap3: embedd gpmc_cs into gpmc config struct

introduced a problem with the serial gpmc setup.

This patch reverts the chip select to its previous value.

The symptoms of this problem are that the Zoom2
currently hangs.

This was run tested on Zoom2.

---
 board/logicpd/zoom2/zoom2.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
board/logicpd/zoom2/zoom2.c +1 -2
index d9e2ae5..cd8c9fe 100644
@@ -129,7 +129,7 @@ int board_init (void)
 
 	/* Configure console support on zoom2 */
 	gpmc_config = gpmc_serial_TL16CP754C;
-	enable_gpmc_cs_config(gpmc_config, &gpmc_cfg->cs[4],
+	enable_gpmc_cs_config(gpmc_config, &gpmc_cfg->cs[3],
 			SERIAL_TL16CP754C_BASE, GPMC_SIZE_16M);
 
 	/* board id for Linux */
--
Quoted 1 line

1.6.0.6

Tom,

I'll push this the moment we resolves some of our OMAP3 issues.

Thanks,
Sandeep

#3 lore raw

PATCH 1/1 Zoom2 Fix serial gpmc setup

Quoted 32 lines · Sandeep
Quoted 32 lines

The offset to the chip select is incorrect.

The change 187af954cf7958c24efcf0fd62289bbdb4f1f24e,

omap3: embedd gpmc_cs into gpmc config struct

introduced a problem with the serial gpmc setup.

This patch reverts the chip select to its previous value.

The symptoms of this problem are that the Zoom2
currently hangs.

This was run tested on Zoom2.

---
 board/logicpd/zoom2/zoom2.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
board/logicpd/zoom2/zoom2.c +1 -1
index d9e2ae5..cd8c9fe 100644
@@ -129,7 +129,7 @@ int board_init (void)
 
 	/* Configure console support on zoom2 */
 	gpmc_config = gpmc_serial_TL16CP754C;
-	enable_gpmc_cs_config(gpmc_config, &gpmc_cfg->cs[4],
+	enable_gpmc_cs_config(gpmc_config, &gpmc_cfg->cs[3],
 			SERIAL_TL16CP754C_BASE, GPMC_SIZE_16M);
 
Quoted 9 lines
Quoted 3 lines
board/logicpd/zoom2/zoom2.c +0 -1
 	/* board id for Linux */
--

1.6.0.6

Tom,

I'll push this the moment we resolves some of our OMAP3 issues.

Thanks!
Tom

Quoted 4 lines

Thanks,
Sandeep

#4 lore raw

PATCH 1/1 Zoom2 Fix serial gpmc setup

Quoted 28 lines
Quoted 26 lines · Sandeep
Quoted 26 lines

The offset to the chip select is incorrect.

The change 187af954cf7958c24efcf0fd62289bbdb4f1f24e,

omap3: embedd gpmc_cs into gpmc config struct

introduced a problem with the serial gpmc setup.

This patch reverts the chip select to its previous value.

The symptoms of this problem are that the Zoom2
currently hangs.

This was run tested on Zoom2.

---
 board/logicpd/zoom2/zoom2.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
board/logicpd/zoom2/zoom2.c +0 -0
index d9e2ae5..cd8c9fe 100644
@@ -129,7 +129,7 @@ int board_init (void)
 
Quoted 7 lines
Quoted 7 lines

board/logicpd/zoom2/zoom2.c int board_init (void) · line 135

Quoted 7 lines
board/logicpd/zoom2/zoom2.c +1 -1
 	/* Configure console support on zoom2 */
 	gpmc_config = gpmc_serial_TL16CP754C;
-	enable_gpmc_cs_config(gpmc_config, &gpmc_cfg->cs[4],
+	enable_gpmc_cs_config(gpmc_config, &gpmc_cfg->cs[3],
 			SERIAL_TL16CP754C_BASE, GPMC_SIZE_16M);
 
 	/* board id for Linux */

Pushed to u-boot-ti master

http://git.denx.de/?p=u-boot/u-boot-ti.git;a=commitdiff;h=277651e76c7af164bca7e721ec6cb4ef0b508225

Once we resolve some of our OMAP3 issues I will push the appropriate patches to u-boot-ti master. Those patches are currently in u-boot-ti next

Thanks,
Sandeep