cfg80211: fix netns error unwinding bug
Johannes Berg
maintainerPATCH 1/1 cfg80211: fix netns error unwinding bug
The error unwinding code in set_netns has a bug that will make it run into a BUG_ON if passed a bad wiphy index, fix by not trying to unlock a wiphy that doesn't exist.
Signed-off-by Johannes Berg <[email protected]>
--- net/wireless/nl80211.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
net/wireless/nl80211.c +2 -1
@@ -4031,7 +4031,7 @@ static int nl80211_wiphy_netns(struct sk rdev =cfg80211_get_dev_from_info (info);if (IS_ERR (rdev)) { err =PTR_ERR (rdev); - goto out; + goto out_rtnl; } net =get_net_ns_by_pid (pid);
@@ -4051,6 +4051,7 @@ static int nl80211_wiphy_netns(struct skput_net (net); out:cfg80211_unlock_rdev (rdev); + out_rtnl:rtnl_unlock ();return err; }