code clean up for dio fallocate handling
PATCH v2 3/4 code clean up for dio fallocate handling
ext4: code clean up for dio fallocate handling
The ext4_debug() call in ext4_end_io_dio() (inode.c) has a
should be moved after checking the io_end structure to be not a NULL pointer.
The comment above ext4_get_block_dio_write() ("Maximum number of blocks...") is a duplicate; the original and correct comment is above the #define DIO_MAX_BLOCKS up above.
The check for allocated > max_blocks in ext4_split_unwritten_extents() can be removed, since the code returns immediately once allocated blocks is less or equals to the requested blocks to convert.
Based on review comments from Curt Wohlgemuth.
--- fs/ext4/extents.c | 96 +++++++++++++++++++++++++----------------------------- fs/ext4/inode.c | 9 ++--- 2 files changed, 50 insertions(+), 55 deletions(-)
fs/ext4/inode.c +0 -1
@@ -3367,8 +3367,6 @@ out:return ret; } -/* Maximum number of blocks we map for direct IO at once. */
Theodore Tso
maintainerQuoted 9 lines · Mingming
ext4: code clean up for dio fallocate handling
The
ext4_debug()call inext4_end_io_dio()(inode.c) has a
should be moved after checking theio_endstructure to be not a NULL pointer.The comment above
ext4_get_block_dio_write()("Maximum number of blocks...") is a duplicate; the original and correct comment is above the #defineDIO_MAX_BLOCKSup above.
Quoted 7 lines
The check for allocated >
max_blocksinext4_split_unwritten_extents()can be removed, since the code returns immediately once allocated blocks is less or equals to the requested blocks to convert.Based on review comments from Curt Wohlgemuth.
Signed-off-by Mingming Cao <[email protected]>
The changes described last paragraph wasn't in the patch. I assume it was because patch #4 in this series changed:
if (allocated <= max_blocks)
to:
if (iblock == ee_block && allocated <= max_blocks)
I replaced the commit description with the following:
ext4: code clean up for dio fallocate handling
From: Mingming <[email protected]>
The ext4_debug() call in ext4_end_io_dio() should be moved after the check to make sure that io_end is non-NULL.
The comment above ext4_get_block_dio_write() ("Maximum number of blocks...") is a duplicate; the original and correct comment is above the #define DIO_MAX_BLOCKS up above.
Based on review comments from Curt Wohlgemuth.
Added to the patch queue
- Ted