Skip to contentSkip to conversation

USB: usblcd, fix memory leak

PATCH In review Jiri Slaby 2 participants 2 messages Oct 9, 2009 USB

lore
Share & tools
lore

Jiri Slaby

author
#0 lore raw

PATCH 1/1 USB: usblcd, fix memory leak

Stanse found a memory leak in lcd_probe. Instead of returning without releasing the memory, jump to the error label which frees it.

http://stanse.fi.muni.cz/

Cc Greg Kroah-Hartman <[email protected]>
---
 drivers/usb/misc/usblcd.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/usb/misc/usblcd.c +2 -1
index 29092b8..4fb1203 100644
@@ -313,7 +313,8 @@ static int lcd_probe(struct usb_interface *interface, const struct usb_device_id
 
 	if (le16_to_cpu(dev->udev->descriptor.idProduct) != 0x0001) {
 		dev_warn(&interface->dev, "USBLCD model not supported.\n");
-		return -ENODEV;
+		retval = -ENODEV;
+		goto error;
 	}
 	
 	/* set up the endpoint information */
Signature · 1 line
1.6.4.2