Skip to contentSkip to conversation

tracing - enabling "__cold" functions

PATCH In review [email protected] 3 participants 5 messages Oct 9, 2009 – Oct 12, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tracing - enabling "__cold" functions

Based on the commit:

a586df06 "x86: Support __attribute__((__cold__)) in gcc 4.3"

some of the functions goes to the ".text.unlikely" section.

Looks like there's not many of them (I found printk, panic, __ssb_dma_not_implemented, fat_fs_error), but still worth to include I think.

wbr,
jirka

---
 scripts/recordmcount.pl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
scripts/recordmcount.pl +1 -0
index 090d300..bfb8b2c 100755
@@ -119,6 +119,7 @@ my %text_sections = (
      ".sched.text" => 1,
      ".spinlock.text" => 1,
      ".irqentry.text" => 1,
+     ".text.unlikely" => 1,
 );
 
 $objdump = "objdump" if ((length $objdump) == 0);
author
#1 lore raw

any feedback on this one?

thanks,
jirka

Quoted 36 lines · On Fri, Oct 09, 2009 at 06:14:59PM +0200, [email protected] wrote:

Based on the commit:

a586df06 "x86: Support __attribute__((__cold__)) in gcc 4.3"

some of the functions goes to the ".text.unlikely" section.

Looks like there's not many of them (I found printk, panic, __ssb_dma_not_implemented, fat_fs_error), but still worth to include I think.

wbr,
jirka

---
 scripts/recordmcount.pl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
scripts/recordmcount.pl +1 -1
index 090d300..bfb8b2c 100755
@@ -119,6 +119,7 @@ my %text_sections = (
      ".sched.text" => 1,
      ".spinlock.text" => 1,
      ".irqentry.text" => 1,
+     ".text.unlikely" => 1,
 );
 
 $objdump = "objdump" if ((length $objdump) == 0);
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#2 lore raw
Quoted 1 line · Jiri Olsa

any feedback on this one?

Steve said he's queueing it up. (But 3 days of delay, especially if it's over the weekend and if it's not an urgent fix is to be expected so please be patient.)

Ingo

author
#3 lore raw
Quoted 10 lines · Ingo Molnar
Quoted 1 line · Jiri Olsa

any feedback on this one?

Steve said he's queueing it up. (But 3 days of delay, especially if it's over the weekend and if it's not an urgent fix is to be expected so please be patient.)

Ingo

no rush :) it's just I usually get reply like "looking on this" or smth.. so I thought it might get lost, sry for noise

jirka

#4 lore raw
Quoted 6 lines · Jiri Olsa
Quoted 5 lines · Ingo Molnar
Quoted 1 line · Jiri Olsa

any feedback on this one?

Quoted 8 lines
Quoted 5 lines

Steve said he's queueing it up. (But 3 days of delay, especially if it's over the weekend and if it's not an urgent fix is to be expected so please be patient.)

Ingo

no rush :) it's just I usually get reply like "looking on this" or smth.. so I thought it might get lost, sry for noise

No prob. Yes I'm looking at this ;-)

-- Steve