mtd: cleanup mtd_oobtest
PATCH 1/1 mtd: cleanup mtd_oobtest
- Remove unnecessary memset for bbt
All entries will be initialized at a few lines below
- Remove unnecessary initialization for mtd->erasesize
- Use write_whole_device()
Cc David Woodhouse <[email protected]>
Cc Artem Bityutskiy <[email protected]>
Signed-off-by Akinobu Mita <[email protected]>
--- drivers/mtd/tests/mtd_oobtest.c | 18 ++++-------------- 1 files changed, 4 insertions(+), 14 deletions(-)
drivers/mtd/tests/mtd_oobtest.c +4 -14
@@ -343,7 +343,6 @@ static int scan_for_bad_eraseblocks(void)printk (PRINT_PREF "error: cannot allocate memory\n" );return -ENOMEM ; } -memset (bbt,0 , ebcnt);printk (PRINT_PREF "scanning for bad eraseblocks\n" );for (i =0 ; i < ebcnt; ++i) {
@@ -392,7 +391,6 @@ static int __init mtd_oobtest_init(void) mtd->writesize, ebcnt, pgcnt, mtd->oobsize); err = -ENOMEM ; - mtd->erasesize = mtd->erasesize; readbuf =kmalloc (mtd->erasesize,GFP_KERNEL );if (!readbuf) {printk (PRINT_PREF "error: cannot allocate memory\n" );
@@ -476,18 +474,10 @@ static int __init mtd_oobtest_init(void) use_len_max = mtd->ecclayout->oobavail; vary_offset =1 ;simple_srand (5 ); -printk (PRINT_PREF "writing OOBs of whole device\n" ); -for (i =0 ; i < ebcnt; ++i) { -if (bbt[i]) -continue ; - err =write_eraseblock (i); -if (err) - goto out; -if (i %256 ==0 ) -printk (PRINT_PREF "written up to eraseblock %u\n" , i); -cond_resched (); - } -printk (PRINT_PREF "written %u eraseblocks\n" , i); + + err =write_whole_device (); +if (err) + goto out;/* Check all eraseblocks */ use_offset =0 ;
Signature · 1 line
1.5.4.3
Quoted 4 lines · Akinobu Mita
- Remove unnecessary memset for bbt
All entries will be initialized at a few lines below
Quoted 8 lines
- Remove unnecessary initialization for
mtd->erasesize- Use
write_whole_device()Cc David Woodhouse <[email protected]>Cc Artem Bityutskiy <[email protected]>Signed-off-by Akinobu Mita <[email protected]>
I've added this patch to my l2-mtd-2.6.git tree:
http://git.infradead.org/users/dedekind/l2-mtd-2.6.git/commit/152bd342f1c36cde54e52565947527a70c6b4afb
Thanks!
Signature · 2 lines
Best Regards, Artem Bityutskiy (Артём Битюцкий)