Skip to contentSkip to conversation

ARM: OMAP: McBSP: Fix incorrect receiver stop in omap_mcbsp_stop

PATCH New Jarkko Nikula 2 participants 2 messages Oct 11, 2009 – Oct 13, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: OMAP: McBSP: Fix incorrect receiver stop in omap_mcbsp_stop

This small typo written by author causes that McBSP receiver is disabled on OMAP2430 and OMAP3430 even if only transmitter is stopped. This was noted with ALSA SoC where simultaneous recording halted if playback was stopped first.

---
 arch/arm/plat-omap/mcbsp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-omap/mcbsp.c +1 -1
index 88ac976..e664b91 100644
@@ -595,7 +595,7 @@ void omap_mcbsp_stop(unsigned int id, int tx, int rx)
 	rx &= 1;
 	if (cpu_is_omap2430() || cpu_is_omap34xx()) {
 		w = OMAP_MCBSP_READ(io_base, RCCR);
-		w |= (tx ? RDISABLE : 0);
+		w |= (rx ? RDISABLE : 0);
 		OMAP_MCBSP_WRITE(io_base, RCCR, w);
 	}
 	w = OMAP_MCBSP_READ(io_base, SPCR1);
Signature · 1 line
1.6.3.3
#1 lore raw

PATCH 1/1 ARM: OMAP: McBSP: Fix incorrect receiver stop in

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Initial commit ID (Likely to change): 9fd9fe496604919d9d23f284ebd4a84cb2f97066

PatchWorks
http://patchwork.kernel.org/patch/53005/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=9fd9fe496604919d9d23f284ebd4a84cb2f97066