fcntl: rename F_OWNER_GID to F_OWNER_PGRP
PATCH 1/1 fcntl: rename F_OWNER_GID to F_OWNER_PGRP
I noticed this patch never quite made it to LKML..
---
Subject: fcntl: rename F_OWNER_GID to F_OWNER_PGRP
From: Peter Zijlstra <[email protected]>
Date: Mon, 05 Oct 2009 14:44:47 +0200
Quoted 7 lines · Michael Kerrisk
Please, could you change
F_OWNER_GIDtoF_OWNER_PGRP.This is for consistency with various
ioctl()operations that include the suffix "PGRP" in their names, and also for consistency withPRIO_PGRP, used withsetpriority()andgetpriority(). Also, using PGRP instead of GID avoids confusion with the common abbreviation of "group ID".
I'm fine with anything that makes it more consistent, and if PGRP is what is the predominant abbreviation then I see no need to further confuse matters by adding a third one.
Signed-off-by Peter Zijlstra <[email protected]>
Acked-by Michael Kerrisk <[email protected]>
--- fs/fcntl.c | 4 ++-- include/asm-generic/fcntl.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
fs/fcntl.c +2 -2
@@ -284,7 +284,7 @@ static int f_setown_ex(struct file *filp type =PIDTYPE_PID ;break ; -case F_OWNER_GID : +case F_OWNER_PGRP : type =PIDTYPE_PGID ;break ;
@@ -321,7 +321,7 @@ static int f_getown_ex(struct file *filpbreak ;case PIDTYPE_PGID : - owner.type =F_OWNER_GID ; + owner.type =F_OWNER_PGRP ;break ;default :
include/asm-generic/fcntl.h +1 -1
@@ -80,7 +80,7 @@#define F_OWNER_TID 0#define F_OWNER_PID 1 -#define F_OWNER_GID 2 +#define F_OWNER_PGRP 2struct f_owner_ex {int type;