Fix *-user build error
PATCH 1/1 Fix *-user build error
---
Currently building i386-linux-user fails with this error:
CC i386-linux-user/fpu/softfloat-native.o
[...]/qemu/fpu/softfloat-native.c:132:5: error: "HOST_LONG_BITS" is not defined make[3]: *** [fpu/softfloat-native.o] Error 1
make[2]: *** [all] Error 2
make[1]: *** [subdir-i386-linux-user] Error 2
make: *** [build-all] Error 2
This trivial patch seems to fix it (without messing up the i386-softmmu build, the other one I sort of tested). I assume it also fixes similar errors in building the other *-user targets.
fpu/softfloat.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
fpu/softfloat.h +1 -1
@@ -37,7 +37,7 @@ these four paragraphs for those parts of this code that are retained.#endif #include <inttypes.h> -#include "config.h" +#include "../config.h" /*---------------------------------------------------------------------------- | Each of the following `typedef's defines the most convenient type that holds
Signature · 1 line
1.6.5.rc2
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 17 lines · Juan Quintela
Quoted 11 lines · Paul Bolle
Signed-off-by Paul Bolle <[email protected]>---
Currently building i386-linux-user fails with this error:CC
i386-linux-user/fpu/softfloat-native.o
[...]/qemu/fpu/softfloat-native.c:132:5: error: "HOST_LONG_BITS" is not defined make[3]: *** [fpu/softfloat-native.o] Error 1
make[2]: *** [all] Error 2
make[1]: *** [subdir-i386-linux-user] Error 2
make: *** [build-all] Error 2make disclean
or
rm -f*/config.h
Quoted 5 lines
Will fix the problem.
config.hwas a generated file, and now it is not :( To make things more interesting, it moved from one place to other (now it is shared for all targets).
make distclean didn't help here (neither did "make clean", which is what I used before submitting the trivial patch).
"rm */config.h" did work. Thanks.
Why doesn't "make clean" do what one expects it to do? Can't it be made to behave properly?
Paul
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 18 lines · Juan Quintela
Quoted 4 lines · Paul Bolle
Quoted 1 line · Juan Quintela
Paul Bolle <[email protected]> wrote:
Why doesn't "make clean" do what one expects it to do? Can't it be made to behave properly?
Not trivial.
foo-softmmu/config.hgot renamedfoo-softmmu/config-target.hnow a newconfig.hgot created at toplevel directory, that includesconfig-target.h(and more things, that is the whore reason why it was created).Adding removal of
foo-softmmu/config.hto theMakefileis an option, but this is a "once" affair, i.e. it is only needed if you have ever compiled in that directory. Both options are bad:
- add a removal offoo-softmmu/config.hthat is not generated at all
- require users to removalconfig.honce
Quoted 3 lines
2nd one was adopted, both have disadvantages, just different ones. The other option was to rename
config.hto something different, but that was a BIIIIIIIG patch for no gain either :(
I see. All that basically happened was that this rename etc. took place in a repository in which I had previously built qemu and I should not run into this issue anymore. Thanks.
Paul