Skip to contentSkip to conversation

aaci: ARM1176 aaci-pl041 AC97 register read timeout

PATCH Applied Philby John 2 participants 2 messages Oct 13, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 aaci: ARM1176 aaci-pl041 AC97 register read timeout

From: Philby John <[email protected]>
Date: Tue, 13 Oct 2009 16:30:22 +0530
Subject: [PATCH] aaci: ARM1176 aaci-pl041 AC97 register read timeout

After a reboot on an ARM1176 which amounts to a softreset, it has been noted that the ALSA driver does not get registered and the probe fails with the error "aaci-pl041 fpga:04: ac97 read back fail". In the process of reading from a register the SL1TxBusy bit is set indicating that the transceiver is busy and remains so until the default timeout occurs. Set the Power down register 0x26 to an arbitrary value as specified in the PL041 manual (page: 3-18) so that AACISL1TX/AACISL2TX registers take their default state.

---
 sound/arm/aaci.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
sound/arm/aaci.c +1 -0
index 89096e8..98b6ffe 100644
@@ -937,6 +937,7 @@ static int __devinit aaci_probe_ac97(struct aaci *aaci)
 	struct snd_ac97 *ac97;
 	int ret;
 
+	writel(0, aaci->base + AC97_POWERDOWN);
 	/*
 	 * Assert AACIRESET for 2us
 	 */
Signature · 1 line
1.6.3.3.MVISTA
Applied
#1 lore raw

At Tue, 13 Oct 2009 19:28:24 +0530,

Quoted 14 lines · Philby John

From: Philby John <[email protected]>
Date: Tue, 13 Oct 2009 16:30:22 +0530
Subject: [PATCH] aaci: ARM1176 aaci-pl041 AC97 register read timeout

After a reboot on an ARM1176 which amounts to a softreset, it has been noted that the ALSA driver does not get registered and the probe fails with the error "aaci-pl041 fpga:04: ac97 read back fail". In the process of reading from a register the SL1TxBusy bit is set indicating that the transceiver is busy and remains so until the default timeout occurs. Set the Power down register 0x26 to an arbitrary value as specified in the PL041 manual (page: 3-18) so that AACISL1TX/AACISL2TX registers take their default state.

Quoted 1 line

Thanks, applied now.

Takashi

Quoted 25 lines
---
 sound/arm/aaci.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
sound/arm/aaci.c +1 -0
index 89096e8..98b6ffe 100644
@@ -937,6 +937,7 @@ static int __devinit aaci_probe_ac97(struct aaci *aaci)
 	struct snd_ac97 *ac97;
 	int ret;
 
+	writel(0, aaci->base + AC97_POWERDOWN);
 	/*
 	 * Assert AACIRESET for 2us
 	 */
Signature · 7 lines
1.6.3.3.MVISTA


_______________________________________________
Alsa-devel mailing list
Alsa-devel at alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel