i2c-powermac: Reject unsupported I2C transactions
Subsystems (2)
PATCH 1/1 i2c-powermac: Reject unsupported I2C transactions
The i2c-powermac driver doesn't support arbitrary multi-message I2C transactions, only SMBus ones. Make it clear by returning an error if a multi-message I2C transaction is attempted. This is better than only processing the first message, because most callers won't recover from the short transaction. Anyone wishing to issue multi-message transactions should use the SMBus API instead of the raw I2C API.
--- drivers/i2c/busses/i2c-powermac.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/i2c/busses/i2c-powermac.c +6 -0
@@ -146,6 +146,12 @@ static int i2c_powermac_master_xfer( strint read;int addrdir; +if (num !=1 ) { +dev_err (&adap->dev, +"Multi-message I2C transactions not supported\n" ); +return -EOPNOTSUPP ; + } +if (msgs->flags &I2C_M_TEN )return -EINVAL ; read = (msgs->flags &I2C_M_RD ) !=0 ;
Signature · 1 line
Jean Delvare
Quoted 8 lines · Jean Delvare
The i2c-powermac driver doesn't support arbitrary multi-message I2C transactions, only SMBus ones. Make it clear by returning an error if a multi-message I2C transaction is attempted. This is better than only processing the first message, because most callers won't recover from the short transaction. Anyone wishing to issue multi-message transactions should use the SMBus API instead of the raw I2C API.
Signed-off-by Jean Delvare <[email protected]>
Quoted 22 lines
Cc Paul Mackerras <[email protected]>--- drivers/i2c/busses/i2c-powermac.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/i2c/busses/i2c-powermac.c +6
-0@@ -146,6 +146,12 @@ static int i2c_powermac_master_xfer( strint read;int addrdir; +if (num !=1 ) { +dev_err (&adap->dev, +"Multi-message I2C transactions not supported\n" ); +return -EOPNOTSUPP ; + } +if (msgs->flags &I2C_M_TEN )return -EINVAL ; read = (msgs->flags &I2C_M_RD ) !=0 ;