Skip to contentSkip to conversation

libertas: remove unused lbs_cmd_802_11_inactivity_timeout()

PATCH In review Holger Schurig 2 participants 5 messages Oct 16, 2009 – Oct 22, 2009 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libertas: remove unused lbs_cmd_802_11_inactivity_timeout()

drivers/net/wireless/libertas/cmd.c +0 -27
@@ -273,33 +273,6 @@
 	return 0;
 }
 
-int lbs_cmd_802_11_inactivity_timeout(struct lbs_private *priv,
-				      uint16_t cmd_action, uint16_t *timeout)
-{
-	struct cmd_ds_802_11_inactivity_timeout cmd;
-	int ret;
-
-	lbs_deb_enter(LBS_DEB_CMD);
-
-	cmd.hdr.command = cpu_to_le16(CMD_802_11_INACTIVITY_TIMEOUT);
-	cmd.hdr.size = cpu_to_le16(sizeof(cmd));
-
-	cmd.action = cpu_to_le16(cmd_action);
-
-	if (cmd_action == CMD_ACT_SET)
-		cmd.timeout = cpu_to_le16(*timeout);
-	else
-		cmd.timeout = 0;
-
-	ret = lbs_cmd_with_response(priv, CMD_802_11_INACTIVITY_TIMEOUT, &cmd);
-
-	if (!ret)
-		*timeout = le16_to_cpu(cmd.timeout);
-
-	lbs_deb_leave_args(LBS_DEB_CMD, "ret %d", ret);
-	return 0;
-}
-
 int lbs_cmd_802_11_sleep_params(struct lbs_private *priv, uint16_t cmd_action,
 				struct sleep_params *sp)
 {
drivers/net/wireless/libertas/cmd.h +0 -3
@@ -135,9 +135,6 @@
 int lbs_cmd_802_11_rate_adapt_rateset(struct lbs_private *priv,
 				      uint16_t cmd_action);
 
-int lbs_cmd_802_11_inactivity_timeout(struct lbs_private *priv,
-				      uint16_t cmd_action, uint16_t *timeout);
-
 int lbs_cmd_802_11_set_wep(struct lbs_private *priv, uint16_t cmd_action,
 			   struct assoc_request *assoc);
 
drivers/net/wireless/libertas/host.h +0 -10
@@ -621,16 +621,6 @@
 	__le16 reserved;
 } __attribute__ ((packed));
 
-struct cmd_ds_802_11_inactivity_timeout {
-	struct cmd_header hdr;
-
-	/* ACT_GET/ACT_SET */
-	__le16 action;
-
-	/* Inactivity timeout in msec */
-	__le16 timeout;
-} __attribute__ ((packed));
-
 struct cmd_ds_802_11_rf_channel {
 	struct cmd_header hdr;
 
Signature · 1 line
http://www.holgerschurig.de
Acked-by on v1 1/1
#1 lore raw
Quoted 1 line · Holger Schurig

We were going to use this at one point, but we haven't yet, so we can add it back when we do.

Quoted 68 lines
drivers/net/wireless/libertas/cmd.c +0 -27
@@ -273,33 +273,6 @@
 	return 0;
 }
 
-int lbs_cmd_802_11_inactivity_timeout(struct lbs_private *priv,
-				      uint16_t cmd_action, uint16_t *timeout)
-{
-	struct cmd_ds_802_11_inactivity_timeout cmd;
-	int ret;
-
-	lbs_deb_enter(LBS_DEB_CMD);
-
-	cmd.hdr.command = cpu_to_le16(CMD_802_11_INACTIVITY_TIMEOUT);
-	cmd.hdr.size = cpu_to_le16(sizeof(cmd));
-
-	cmd.action = cpu_to_le16(cmd_action);
-
-	if (cmd_action == CMD_ACT_SET)
-		cmd.timeout = cpu_to_le16(*timeout);
-	else
-		cmd.timeout = 0;
-
-	ret = lbs_cmd_with_response(priv, CMD_802_11_INACTIVITY_TIMEOUT, &cmd);
-
-	if (!ret)
-		*timeout = le16_to_cpu(cmd.timeout);
-
-	lbs_deb_leave_args(LBS_DEB_CMD, "ret %d", ret);
-	return 0;
-}
-
 int lbs_cmd_802_11_sleep_params(struct lbs_private *priv, uint16_t cmd_action,
 				struct sleep_params *sp)
 {
drivers/net/wireless/libertas/cmd.h +0 -3
@@ -135,9 +135,6 @@
 int lbs_cmd_802_11_rate_adapt_rateset(struct lbs_private *priv,
 				      uint16_t cmd_action);
 
-int lbs_cmd_802_11_inactivity_timeout(struct lbs_private *priv,
-				      uint16_t cmd_action, uint16_t *timeout);
-
 int lbs_cmd_802_11_set_wep(struct lbs_private *priv, uint16_t cmd_action,
 			   struct assoc_request *assoc);
 
drivers/net/wireless/libertas/host.h +0 -10
@@ -621,16 +621,6 @@
 	__le16 reserved;
 } __attribute__ ((packed));
 
-struct cmd_ds_802_11_inactivity_timeout {
-	struct cmd_header hdr;
-
-	/* ACT_GET/ACT_SET */
-	__le16 action;
-
-	/* Inactivity timeout in msec */
-	__le16 timeout;
-} __attribute__ ((packed));
-
 struct cmd_ds_802_11_rf_channel {
 	struct cmd_header hdr;
 
#2 lore raw
Quoted 2 lines

We were going to use this at one point, but we haven't yet, so we can add it back when we do.

So, what does this actually do?

Signature · 1 line
http://www.holgerschurig.de
#3 lore raw
Quoted 4 lines · Holger Schurig
Quoted 2 lines

We were going to use this at one point, but we haven't yet, so we can add it back when we do.

So, what does this actually do?

Pretty much like it sounds; it lets the device go to into powersave at user-specified interval after the last TX or RX, instead of having to wait one full beacon of inactivity.

Dan

#4 lore raw
Quoted 3 lines

Pretty much like it sounds; it lets the device go to into powersave at user-specified interval after the last TX or RX, instead of having to wait one full beacon of inactivity.

Ok, nice.

But it could also have sounded like "report how long the card was inactive", e.g. what "iw XXX link" can show.

Do you already have any idea about how to make those things like TCP, inactivity etc available in NL80211/cfg80211 ?

Signature · 1 line
http://www.holgerschurig.de