Per route TCP options
Subsystems (4)
RFC PATCH 1/1 Per route TCP options
Turn the global sysctls allowing disabling of TCP SACK, DSCAK, time stamp and window scale into per route entry feature options, laying the ground to future removal of the relevant global sysctls.
You really only want to disable SACK, DSACK, time stamp or window scale if you've got a piece of broken networking equipment somewhere as a stop gap until you can bring a big enough hammer to deal with the broken network equipment. It doesn't make sense to "punish" the entire connections going through the machine to destinations not related to the broken equipment.
This is doubly true when you're dealing with network containers used to isolate several virtual domains.
Per route options implemented in free bits in the features route entry property, which in some cases were reserved by name for these options, so this does not inflate any structure and I expect that when the apropriate global sysctls will be removed the overall code base will be smaller.
Tested on x86 using Qemu/KVM.
Will send the matching patch to iproute2 if/when this is ACKed or if someone wants to test this.
Patchset based on original work by Ori Finkelman and Yoni Amit from ComSleep Ltd.
Gilad Ben-Yossef (8):
Only parse time stamp TCP option in time wait sock Allow tcp_parse_options to consult dst entry Infrastructure for querying route entry features Add the no SACK route option feature
Allow disabling TCP timestamp options per route Allow to turn off TCP window scale opt per route Allow disabling of DSACK TCP option per route Document future removal of sysctl_tcp_* options
Documentation/feature-removal-schedule.txt | 12 ++++++++++++ include/linux/rtnetlink.h | 6 ++++-- include/net/dst.h | 8 +++++++- include/net/tcp.h | 3 ++- net/ipv4/syncookies.c | 27 ++++++++++++++------------- net/ipv4/tcp_input.c | 26 ++++++++++++++++++-------- net/ipv4/tcp_ipv4.c | 19 ++++++++++--------- net/ipv4/tcp_minisocks.c | 8 +++++--- net/ipv4/tcp_output.c | 18 +++++++++++++----- net/ipv6/syncookies.c | 28 +++++++++++++++------------- net/ipv6/tcp_ipv6.c | 3 ++- 11 files changed, 102 insertions(+), 56 deletions(-)
RFC PATCH 1/1 Only parse time stamp TCP option in time wait sock
A time wait socket is established - we already know if time stamp option is called for or not.
--- net/ipv4/tcp_minisocks.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
net/ipv4/tcp_minisocks.c +1 -2
@@ -100,9 +100,8 @@ tcp_timewait_state_process(struct inet_timewait_sock *tw, struct sk_buff *skb,struct tcp_options_received tmp_opt;int paws_reject =0 ; - tmp_opt.saw_tstamp =0 ;if (th->doff > (sizeof (*th) >>2 ) && tcptw->tw_ts_recent_stamp) { -tcp_parse_options (skb, &tmp_opt,0 ); +tcp_parse_options (skb, &tmp_opt,1 );if (tmp_opt.saw_tstamp) { tmp_opt.ts_recent = tcptw->tw_ts_recent;
Signature · 1 line
1.5.6.3
RFC PATCH 1/1 Allow tcp_parse_options to consult dst entry
We need tcp_parse_options to be aware of dst_entry to take into account per dst_entry TCP options settings
--- include/net/tcp.h | 3 ++- net/ipv4/syncookies.c | 27 ++++++++++++++------------- net/ipv4/tcp_input.c | 9 ++++++--- net/ipv4/tcp_ipv4.c | 19 ++++++++++--------- net/ipv4/tcp_minisocks.c | 7 +++++-- net/ipv6/syncookies.c | 28 +++++++++++++++------------- net/ipv6/tcp_ipv6.c | 3 ++- 7 files changed, 54 insertions(+), 42 deletions(-)
include/net/tcp.h +2 -1
@@ -409,7 +409,8 @@ extern int tcp_recvmsg(struct kiocb *iocb, struct sock *sk,extern void tcp_parse_options (struct sk_buff *skb,struct tcp_options_received *opt_rx, -int estab); +int estab, +struct dst_entry *dst);extern u8 *tcp_parse_md5sig_option (struct tcphdr *th);
net/ipv4/syncookies.c +14 -13
@@ -276,13 +276,6 @@ struct sock *cookie_v4_check(struct sock *sk, struct sk_buff *skb,NET_INC_STATS_BH (sock_net (sk),LINUX_MIB_SYNCOOKIESRECV ); -/* check for timestamp cookie support */ -memset (&tcp_opt,0 ,sizeof (tcp_opt)); -tcp_parse_options (skb, &tcp_opt,0 ); - -if (tcp_opt.saw_tstamp) -cookie_check_timestamp (&tcp_opt); - ret =NULL ; req =inet_reqsk_alloc (&tcp_request_sock_ops);/* for safety */ if (!req)
@@ -298,12 +291,6 @@ struct sock *cookie_v4_check(struct sock *sk, struct sk_buff *skb, ireq->loc_addr =ip_hdr (skb)->daddr; ireq->rmt_addr =ip_hdr (skb)->saddr; ireq->ecn_ok =0 ; - ireq->snd_wscale = tcp_opt.snd_wscale; - ireq->rcv_wscale = tcp_opt.rcv_wscale; - ireq->sack_ok = tcp_opt.sack_ok; - ireq->wscale_ok = tcp_opt.wscale_ok; - ireq->tstamp_ok = tcp_opt.saw_tstamp; - req->ts_recent = tcp_opt.saw_tstamp ? tcp_opt.rcv_tsval :0 ;/* We throwed the options of the initial SYN away, so we hope * the ACK carries the same options again (see RFC1122 4.2.3.8)
@@ -351,6 +338,20 @@ struct sock *cookie_v4_check(struct sock *sk, struct sk_buff *skb, } } +/* check for timestamp cookie support */ +memset (&tcp_opt,0 ,sizeof (tcp_opt)); +tcp_parse_options (skb, &tcp_opt,0 , &rt->u.dst); + +if (tcp_opt.saw_tstamp) +cookie_check_timestamp (&tcp_opt); + + ireq->snd_wscale = tcp_opt.snd_wscale; + ireq->rcv_wscale = tcp_opt.rcv_wscale; + ireq->sack_ok = tcp_opt.sack_ok; + ireq->wscale_ok = tcp_opt.wscale_ok; + ireq->tstamp_ok = tcp_opt.saw_tstamp; + req->ts_recent = tcp_opt.saw_tstamp ? tcp_opt.rcv_tsval :0 ; +/* Try to redo what tcp_v4_send_synack did. */ req->window_clamp = tp->window_clamp ? :dst_metric (&rt->u.dst,RTAX_WINDOW );
net/ipv4/tcp_input.c +6 -3
@@ -3698,12 +3698,14 @@ old_ack:* the fast version below fails. */ void tcp_parse_options (struct sk_buff *skb,struct tcp_options_received *opt_rx, -int estab) +int estab,struct dst_entry *dst) {unsigned char *ptr;struct tcphdr *th =tcp_hdr (skb);int length = (th->doff *4 ) -sizeof (struct tcphdr ); +BUG_ON (!estab && !dst); + ptr = (unsigned char *)(th +1 ); opt_rx->saw_tstamp =0 ;
@@ -3820,7 +3822,7 @@ static int tcp_fast_parse_options(struct sk_buff *skb, struct tcphdr *th,if (tcp_parse_aligned_timestamp (tp, th))return 1 ; } -tcp_parse_options (skb, &tp->rx_opt,1 ); +tcp_parse_options (skb, &tp->rx_opt,1 ,NULL );return 1 ; }
@@ -5364,8 +5366,9 @@ static int tcp_rcv_synsent_state_process(struct sock *sk, struct sk_buff *skb,struct tcp_sock *tp =tcp_sk (sk);struct inet_connection_sock *icsk =inet_csk (sk);int saved_clamp = tp->rx_opt.mss_clamp; +struct dst_entry *dst =__sk_dst_get (sk); -tcp_parse_options (skb, &tp->rx_opt,0 ); +tcp_parse_options (skb, &tp->rx_opt,0 , dst);if (th->ack) {/* rfc793:
net/ipv4/tcp_ipv4.c +10 -9
@@ -1256,11 +1256,18 @@ int tcp_v4_conn_request(struct sock *sk, struct sk_buff *skb)tcp_rsk (req)->af_specific = &tcp_request_sock_ipv4_ops;#endif + ireq =inet_rsk (req); + ireq->loc_addr = daddr; + ireq->rmt_addr = saddr; + ireq->no_srccheck =inet_sk (sk)->transparent; + ireq->opt =tcp_v4_save_options (sk, skb); + + dst =inet_csk_route_req (sk, req);tcp_clear_options (&tmp_opt); tmp_opt.mss_clamp =536 ; tmp_opt.user_mss =tcp_sk (sk)->rx_opt.user_mss; -tcp_parse_options (skb, &tmp_opt,0 ); +tcp_parse_options (skb, &tmp_opt,0 , dst);if (want_cookie && !tmp_opt.saw_tstamp)tcp_clear_options (&tmp_opt);
@@ -1269,14 +1276,8 @@ int tcp_v4_conn_request(struct sock *sk, struct sk_buff *skb)tcp_openreq_init (req, &tmp_opt, skb); - ireq =inet_rsk (req); - ireq->loc_addr = daddr; - ireq->rmt_addr = saddr; - ireq->no_srccheck =inet_sk (sk)->transparent; - ireq->opt =tcp_v4_save_options (sk, skb); -if (security_inet_conn_request (sk, skb, req)) - goto drop_and_free; + goto drop_and_release;if (!want_cookie)TCP_ECN_create_request (req,tcp_hdr (skb));
@@ -1301,7 +1302,7 @@ int tcp_v4_conn_request(struct sock *sk, struct sk_buff *skb)*/ if (tmp_opt.saw_tstamp && tcp_death_row.sysctl_tw_recycle && - (dst =inet_csk_route_req (sk, req)) !=NULL && + dst !=NULL && (peer =rt_get_peer ((struct rtable *)dst)) !=NULL && peer->v4daddr == saddr) { if (get_seconds() < peer->tcp_ts_stamp + TCP_PAWS_MSL &&
net/ipv4/tcp_minisocks.c +5 -2
@@ -101,7 +101,7 @@ tcp_timewait_state_process(struct inet_timewait_sock *tw, struct sk_buff *skb,int paws_reject =0 ;if (th->doff > (sizeof (*th) >>2 ) && tcptw->tw_ts_recent_stamp) { -tcp_parse_options (skb, &tmp_opt,1 ); +tcp_parse_options (skb, &tmp_opt,1 ,NULL );if (tmp_opt.saw_tstamp) { tmp_opt.ts_recent = tcptw->tw_ts_recent;
@@ -499,10 +499,11 @@ struct sock *tcp_check_req(struct sock *sk, struct sk_buff *skb,int paws_reject =0 ;struct tcp_options_received tmp_opt;struct sock *child; +struct dst_entry *dst =inet_csk_route_req (sk, req); tmp_opt.saw_tstamp =0 ;if (th->doff > (sizeof (struct tcphdr )>>2 )) { -tcp_parse_options (skb, &tmp_opt,0 ); +tcp_parse_options (skb, &tmp_opt,0 , dst);if (tmp_opt.saw_tstamp) { tmp_opt.ts_recent = req->ts_recent;
@@ -515,6 +516,8 @@ struct sock *tcp_check_req(struct sock *sk, struct sk_buff *skb, } } +dst_release (dst); +/* Check for pure retransmitted SYN. */ if (TCP_SKB_CB(skb)->seq == tcp_rsk(req)->rcv_isn && flg == TCP_FLAG_SYN &&
net/ipv6/syncookies.c +15 -13
@@ -184,13 +184,6 @@ struct sock *cookie_v6_check(struct sock *sk, struct sk_buff *skb)NET_INC_STATS_BH (sock_net (sk),LINUX_MIB_SYNCOOKIESRECV ); -/* check for timestamp cookie support */ -memset (&tcp_opt,0 ,sizeof (tcp_opt)); -tcp_parse_options (skb, &tcp_opt,0 ); - -if (tcp_opt.saw_tstamp) -cookie_check_timestamp (&tcp_opt); - ret =NULL ; req =inet6_reqsk_alloc (&tcp6_request_sock_ops);if (!req)
@@ -224,12 +217,6 @@ struct sock *cookie_v6_check(struct sock *sk, struct sk_buff *skb) req->expires =0UL ; req->retrans =0 ; ireq->ecn_ok =0 ; - ireq->snd_wscale = tcp_opt.snd_wscale; - ireq->rcv_wscale = tcp_opt.rcv_wscale; - ireq->sack_ok = tcp_opt.sack_ok; - ireq->wscale_ok = tcp_opt.wscale_ok; - ireq->tstamp_ok = tcp_opt.saw_tstamp; - req->ts_recent = tcp_opt.saw_tstamp ? tcp_opt.rcv_tsval :0 ; treq->rcv_isn =ntohl (th->seq) -1 ; treq->snt_isn = cookie;
@@ -264,6 +251,21 @@ struct sock *cookie_v6_check(struct sock *sk, struct sk_buff *skb) goto out_free; } +/* check for timestamp cookie support */ +memset (&tcp_opt,0 ,sizeof (tcp_opt)); +tcp_parse_options (skb, &tcp_opt,0 , dst); + +if (tcp_opt.saw_tstamp) +cookie_check_timestamp (&tcp_opt); + + req->ts_recent = tcp_opt.saw_tstamp ? tcp_opt.rcv_tsval :0 ; + + ireq->snd_wscale = tcp_opt.snd_wscale; + ireq->rcv_wscale = tcp_opt.rcv_wscale; + ireq->sack_ok = tcp_opt.sack_ok; + ireq->wscale_ok = tcp_opt.wscale_ok; + ireq->tstamp_ok = tcp_opt.saw_tstamp; + req->window_clamp = tp->window_clamp ? :dst_metric (dst,RTAX_WINDOW ); tcp_select_initial_window(tcp_full_space(sk), req->mss, &req->rcv_wnd, &req->window_clamp,
net/ipv6/tcp_ipv6.c +2 -1
@@ -1165,6 +1165,7 @@ static int tcp_v6_conn_request(struct sock *sk, struct sk_buff *skb)struct tcp_sock *tp =tcp_sk (sk);struct request_sock *req =NULL ;__u32 isn =TCP_SKB_CB (skb)->when; +struct dst_entry *dst =__sk_dst_get (sk);#ifdef CONFIG_SYN_COOKIES int want_cookie =0 ;#else
@@ -1203,7 +1204,7 @@ static int tcp_v6_conn_request(struct sock *sk, struct sk_buff *skb) tmp_opt.mss_clamp =IPV6_MIN_MTU -sizeof (struct tcphdr ) -sizeof (struct ipv6hdr ); tmp_opt.user_mss = tp->rx_opt.user_mss; -tcp_parse_options (skb, &tmp_opt,0 ); +tcp_parse_options (skb, &tmp_opt,0 , dst);if (want_cookie && !tmp_opt.saw_tstamp)tcp_clear_options (&tmp_opt);
Signature · 1 line
1.5.6.3
RFC PATCH 1/1 Add dst_feature to query route entry features
Adding an accessor to existing dst_entry feautres field and refactor the only supported feature (allfrag) to use it.
--- include/net/dst.h | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-)
include/net/dst.h +7 -1
@@ -111,6 +111,12 @@ dst_metric(const struct dst_entry *dst, int metric)return dst->metrics[metric-1 ]; } +static inline u32 +dst_feature (const struct dst_entry *dst,u32 feature) +{ +return dst_metric (dst,RTAX_FEATURES ) & feature; +} +static inline u32 dst_mtu (const struct dst_entry *dst) {u32 mtu =dst_metric (dst,RTAX_MTU );
@@ -136,7 +142,7 @@ static inline void set_dst_metric_rtt(struct dst_entry *dst, int metric,static inline u32 dst_allfrag (const struct dst_entry *dst) { -int ret =dst_metric (dst,RTAX_FEATURES ) &RTAX_FEATURE_ALLFRAG ; +int ret =dst_feature (dst,RTAX_FEATURE_ALLFRAG );/* Yes, _exactly_. This is paranoia. */ barrier ();return ret;
Signature · 1 line
1.5.6.3
RFC PATCH 1/1 Add the no SACK route option feature
Implement querying and acting upon the no sack bit in the features field.
--- include/linux/rtnetlink.h | 2 +- net/ipv4/tcp_input.c | 3 ++- net/ipv4/tcp_output.c | 4 +++- 3 files changed, 6 insertions(+), 3 deletions(-)
include/linux/rtnetlink.h +1 -1
@@ -377,7 +377,7 @@ enum#define RTAX_MAX (__RTAX_MAX - 1)#define RTAX_FEATURE_ECN 0x00000001 -#define RTAX_FEATURE_SACK 0x00000002 +#define RTAX_FEATURE_NO_SACK 0x00000002#define RTAX_FEATURE_TIMESTAMP 0x00000004#define RTAX_FEATURE_ALLFRAG 0x00000008
net/ipv4/tcp_input.c +2 -1
@@ -3763,7 +3763,8 @@ void tcp_parse_options(struct sk_buff *skb, struct tcp_options_received *opt_rx,break ;case TCPOPT_SACK_PERM :if (opsize ==TCPOLEN_SACK_PERM && th->syn && - !estab && sysctl_tcp_sack) { + !estab && sysctl_tcp_sack && + !dst_feature (dst,RTAX_FEATURE_NO_SACK )) { opt_rx->sack_ok =1 ;tcp_sack_reset (opt_rx); }
net/ipv4/tcp_output.c +3 -1
@@ -464,6 +464,7 @@ static unsigned tcp_syn_options(struct sock *sk, struct sk_buff *skb, struct tcp_md5sig_key **md5) {struct tcp_sock *tp =tcp_sk (sk);unsigned size =0 ; +struct dst_entry *dst =__sk_dst_get (sk);#ifdef CONFIG_TCP_MD5SIG *md5 = tp->af_specific->md5_lookup (sk, sk);
@@ -498,7 +499,8 @@ static unsigned tcp_syn_options(struct sock *sk, struct sk_buff *skb, opts->options |=OPTION_WSCALE ; size +=TCPOLEN_WSCALE_ALIGNED ; } -if (likely (sysctl_tcp_sack)) { +if (likely (sysctl_tcp_sack && + !dst_feature (dst,RTAX_FEATURE_NO_SACK ))) { opts->options |=OPTION_SACK_ADVERTISE ;if (unlikely (!(OPTION_TS & opts->options))) size +=TCPOLEN_SACKPERM_ALIGNED ;
Signature · 1 line
1.5.6.3
RFC PATCH 1/1 Allow disabling TCP timestamp options per route
Implement querying and acting upon the no timestamp bit in the feature field.
--- include/linux/rtnetlink.h | 2 +- net/ipv4/tcp_input.c | 3 ++- net/ipv4/tcp_output.c | 8 ++++++-- 3 files changed, 9 insertions(+), 4 deletions(-)
include/linux/rtnetlink.h +1 -1
@@ -378,7 +378,7 @@ enum#define RTAX_FEATURE_ECN 0x00000001#define RTAX_FEATURE_NO_SACK 0x00000002 -#define RTAX_FEATURE_TIMESTAMP 0x00000004 +#define RTAX_FEATURE_NO_TSTAMP 0x00000004#define RTAX_FEATURE_ALLFRAG 0x00000008struct rta_session
net/ipv4/tcp_input.c +2 -1
@@ -3755,7 +3755,8 @@ void tcp_parse_options(struct sk_buff *skb, struct tcp_options_received *opt_rx,case TCPOPT_TIMESTAMP :if ((opsize ==TCPOLEN_TIMESTAMP ) && ((estab && opt_rx->tstamp_ok) || - (!estab && sysctl_tcp_timestamps))) { + (!estab && sysctl_tcp_timestamps && + !dst_feature (dst,RTAX_FEATURE_NO_TSTAMP )))) { opt_rx->saw_tstamp =1 ; opt_rx->rcv_tsval =get_unaligned_be32 (ptr); opt_rx->rcv_tsecr =get_unaligned_be32 (ptr +4 );
net/ipv4/tcp_output.c +6 -2
@@ -488,7 +488,9 @@ static unsigned tcp_syn_options(struct sock *sk, struct sk_buff *skb, opts->mss =tcp_advertise_mss (sk); size +=TCPOLEN_MSS_ALIGNED ; -if (likely (sysctl_tcp_timestamps && *md5 ==NULL )) { +if (likely (sysctl_tcp_timestamps && + !dst_feature (dst,RTAX_FEATURE_NO_TSTAMP ) && + *md5 ==NULL )) { opts->options |=OPTION_TS ; opts->tsval =TCP_SKB_CB (skb)->when; opts->tsecr = tp->rx_opt.ts_recent;
@@ -2317,7 +2319,9 @@ static void tcp_connect_init(struct sock *sk)* See tcp_input.c:tcp_rcv_state_process case TCP_SYN_SENT. */ tp->tcp_header_len =sizeof (struct tcphdr ) + - (sysctl_tcp_timestamps ?TCPOLEN_TSTAMP_ALIGNED :0 ); + (sysctl_tcp_timestamps && + (!dst_feature (dst,RTAX_FEATURE_NO_TSTAMP ) ? +TCPOLEN_TSTAMP_ALIGNED :0 ));#ifdef CONFIG_TCP_MD5SIG if (tp->af_specific->md5_lookup (sk, sk) !=NULL )
Signature · 1 line
1.5.6.3
RFC PATCH 1/1 Allow to turn off TCP window scale opt per route
Add and use no window scale bit in the features field.
--- include/linux/rtnetlink.h | 1 + net/ipv4/tcp_input.c | 3 ++- net/ipv4/tcp_output.c | 6 ++++-- 3 files changed, 7 insertions(+), 3 deletions(-)
include/linux/rtnetlink.h +1 -0
@@ -380,6 +380,7 @@ enum#define RTAX_FEATURE_NO_SACK 0x00000002#define RTAX_FEATURE_NO_TSTAMP 0x00000004#define RTAX_FEATURE_ALLFRAG 0x00000008 +#define RTAX_FEATURE_NO_WSCALE 0x00000010struct rta_session {
net/ipv4/tcp_input.c +2 -1
@@ -3739,7 +3739,8 @@ void tcp_parse_options(struct sk_buff *skb, struct tcp_options_received *opt_rx,break ;case TCPOPT_WINDOW :if (opsize ==TCPOLEN_WINDOW && th->syn && - !estab && sysctl_tcp_window_scaling) { + !estab && sysctl_tcp_window_scaling && + !dst_feature (dst,RTAX_FEATURE_NO_WSCALE )) {__u8 snd_wscale = *(__u8 *)ptr; opt_rx->wscale_ok =1 ;if (snd_wscale >14 ) {
net/ipv4/tcp_output.c +4 -2
@@ -496,7 +496,8 @@ static unsigned tcp_syn_options(struct sock *sk, struct sk_buff *skb, opts->tsecr = tp->rx_opt.ts_recent; size +=TCPOLEN_TSTAMP_ALIGNED ; } -if (likely (sysctl_tcp_window_scaling)) { +if (likely (sysctl_tcp_window_scaling && + !dst_feature (dst,RTAX_FEATURE_NO_WSCALE ))) { opts->ws = tp->rx_opt.rcv_wscale; opts->options |=OPTION_WSCALE ; size +=TCPOLEN_WSCALE_ALIGNED ;
@@ -2347,7 +2348,8 @@ static void tcp_connect_init(struct sock *sk) tp->advmss - (tp->rx_opt.ts_recent_stamp ? tp->tcp_header_len -sizeof (struct tcphdr ) :0 ), &tp->rcv_wnd, &tp->window_clamp, - sysctl_tcp_window_scaling, + (sysctl_tcp_window_scaling && + !dst_feature (dst,RTAX_FEATURE_NO_WSCALE )), &rcv_wscale); tp->rx_opt.rcv_wscale = rcv_wscale;
Signature · 1 line
1.5.6.3
RFC PATCH 1/1 Allow disabling of DSACK TCP option per route
Add and use no DSCAK bit in the features field.
--- include/linux/rtnetlink.h | 1 + net/ipv4/tcp_input.c | 8 ++++++-- 2 files changed, 7 insertions(+), 2 deletions(-)
include/linux/rtnetlink.h +1 -0
@@ -381,6 +381,7 @@ enum#define RTAX_FEATURE_NO_TSTAMP 0x00000004#define RTAX_FEATURE_ALLFRAG 0x00000008#define RTAX_FEATURE_NO_WSCALE 0x00000010 +#define RTAX_FEATURE_NO_DSACK 0x00000020struct rta_session {
net/ipv4/tcp_input.c +6 -2
@@ -4080,8 +4080,10 @@ static inline int tcp_sack_extend(struct tcp_sack_block *sp, u32 seq,static void tcp_dsack_set (struct sock *sk,u32 seq,u32 end_seq) {struct tcp_sock *tp =tcp_sk (sk); +struct dst_entry *dst =__sk_dst_get (sk); -if (tcp_is_sack (tp) && sysctl_tcp_dsack) { +if (tcp_is_sack (tp) && sysctl_tcp_dsack && + !dst_feature (dst,RTAX_FEATURE_NO_DSACK )) {int mib_idx;if (before (seq, tp->rcv_nxt))
@@ -4110,13 +4112,15 @@ static void tcp_dsack_extend(struct sock *sk, u32 seq, u32 end_seq)static void tcp_send_dupack (struct sock *sk,struct sk_buff *skb) {struct tcp_sock *tp =tcp_sk (sk); +struct dst_entry *dst =__sk_dst_get (sk);if (TCP_SKB_CB (skb)->end_seq !=TCP_SKB_CB (skb)->seq &&before (TCP_SKB_CB (skb)->seq, tp->rcv_nxt)) {NET_INC_STATS_BH (sock_net (sk),LINUX_MIB_DELAYEDACKLOST );tcp_enter_quickack_mode (sk); -if (tcp_is_sack (tp) && sysctl_tcp_dsack) { +if (tcp_is_sack (tp) && sysctl_tcp_dsack && + !dst_feature (dst,RTAX_FEATURE_NO_DSACK )) {u32 end_seq =TCP_SKB_CB (skb)->end_seq;if (after (TCP_SKB_CB (skb)->end_seq, tp->rcv_nxt))
Signature · 1 line
1.5.6.3
RFC PATCH 1/1 Document future removal of sysctl_tcp_* options
No need for global kill switches if we have per route entry controls. Wait a year before removing in case someone is using this.
--- Documentation/feature-removal-schedule.txt | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-)
Documentation/feature-removal-schedule.txt +12 -0
@@ -6,6 +6,18 @@ be removed from this file. --------------------------- +What: sysctl_tcp_sack, sysctl_tcp_timestamps, sysctl_tcp_window_scaling, + sysctl_tcp_dsack +When: October 2010 + +Why: These options can now be set on a per route basis via the + RTAX_FEATURE_NO_SACK, RTAX_FEATURE_NO_TSTAMP, RTAX_FEATURE_NO_WSCALE, + and RTAX_FEATURE_NO_DSACK route feature options. + +Who: Gilad Ben-Yossef <[email protected]> + +--------------------------- + What: PRISM54 When: 2.6.34
Signature · 1 line
1.5.6.3
Re: [PATCH RFC] Allow to turn off TCP window scale opt per route
In reply to Gilad Ben-YossefQuoted 5 lines · On Tue, 20 Oct 2009 17:22:39 +0200 Gilad Ben-Yossef <[email protected]>…
Add and use no window scale bit in the features field.
Signed-off-by Gilad Ben-Yossef <[email protected]>Sigend-off-by Ori Finkelman <[email protected]>Sigend-off-by Yony Amit <[email protected]>
The same effect can by just using window limit on route
Re: [PATCH RFC] Allow to turn off TCP window scale opt per route
Quoted 4 lines · Stephen Hemminger
On Tue, 20 Oct 2009 17:22:39 +0200
Gilad Ben-Yossef <[email protected]> wrote:
Quoted 9 lines
Quoted 6 lines
Add and use no window scale bit in the features field.
Signed-off-by Gilad Ben-Yossef <[email protected]>Sigend-off-by Ori Finkelman <[email protected]>Sigend-off-by Yony Amit <[email protected]>The same effect can by just using window limit on route
Actually, not exactly. There is a subtle but important difference between "I support window scaling, but choose a scale of 0", which is what your suggestion will imply and "I don't support window scaling at all", which is what the suggested feature field does.
To make things more complicated, until the previous patch I sent, when Linux would choose a window scale of zero for any reason, it would also wrongfully report it does not support window scaling at all to the other side, with some subtle bug caused by it, but this is no longer the behavior and I believe rightly so.
Thanks,
Gilad
Signature · 15 lines
Gilad Ben-Yossef Chief Coffee Drinker & CTO Codefidence Ltd. Web: http://codefidence.com Cell: +972-52-8260388 Skype: gilad_codefidence Tel: +972-8-9316883 ext. 201 Fax: +972-8-9316884 Email: [email protected] Check out our Open Source technology and training blog - http://tuxology.net "Sorry cannot parse this, its too long to be true :)" -- Eric Dumazet on netdev mailing list
Quoted 28 lines · Gilad Ben-Yossef
Turn the global sysctls allowing disabling of TCP SACK, DSCAK, time stamp and window scale into per route entry feature options, laying the ground to future removal of the relevant global sysctls.
You really only want to disable SACK, DSACK, time stamp or window scale if you've got a piece of broken networking equipment somewhere as a stop gap until you can bring a big enough hammer to deal with the broken network equipment. It doesn't make sense to "punish" the entire connections going through the machine to destinations not related to the broken equipment.
This is doubly true when you're dealing with network containers used to isolate several virtual domains.
Per route options implemented in free bits in the features route entry property, which in some cases were reserved by name for these options, so this does not inflate any structure and I expect that when the apropriate global sysctls will be removed the overall code base will be smaller.
Tested on x86 using Qemu/KVM.
Will send the matching patch to iproute2 if/when this is ACKed or if someone wants to test this.
Patchset based on original work by Ori Finkelman and Yoni Amit from ComSleep Ltd.
Quoted 10 lines
Gilad Ben-Yossef (8):
Only parse time stamp TCP option in time wait sock Allowtcp_parse_optionsto consult dst entry Infrastructure for querying route entry features Add the no SACK route option feature
Allow disabling TCP timestamp options per route Allow to turn off TCP window scale opt per route Allow disabling of DSACK TCP option per route Document future removal of sysctl_tcp_* options
Interesting... But you should give numbers to your patches so that we know their order
You could also do the ECN part for consistency (ie RTAX_FEATURE_ECN -> RTAX_FEATURE_NO_ECN)
And please post iproute2 patches as well :)
Thanks
Quoted 9 lines · Eric Dumazet
Quoted 5 lines · Gilad Ben-Yossef
Turn the global sysctls allowing disabling of TCP SACK, DSCAK, time stamp and window scale into per route entry feature options, laying the ground to future removal of the relevant global sysctls.
...
Interesting... But you should give numbers to your patches so that we know their order
Will do.
Quoted 2 lines
You could also do the ECN part for consistency (ie
RTAX_FEATURE_ECN->RTAX_FEATURE_NO_ECN)
That and sysctl_tcp_mtu_probing are on my todo list, assuming the general direction is accepted, of course.
Specifically, I couldn't understand why sysctl_tcp_ecn is documented to be a boolean value, but is initialized to 2 and queried with if (sysctl_tcp_ecn == 1) so I decided to let it be until I figure it out... ;-)
Quoted 2 lines
And please post iproute2 patches as well :)
Will do. Note that the patch I have still has an ugly bit that needs addressing - it sets the features by name, but right now only displays numeric values to the, for "show". This of course will be fixed, but it does work for testing.
Thanks,
Gilad
Signature · 15 lines
Gilad Ben-Yossef Chief Coffee Drinker & CTO Codefidence Ltd. Web: http://codefidence.com Cell: +972-52-8260388 Skype: gilad_codefidence Tel: +972-8-9316883 ext. 201 Fax: +972-8-9316884 Email: [email protected] Check out our Open Source technology and training blog - http://tuxology.net "Sorry cannot parse this, its too long to be true :)" -- Eric Dumazet on netdev mailing list
Quoted 16 lines · Gilad Ben-Yossef
Quoted 10 lines · Eric Dumazet
Quoted 5 lines · Gilad Ben-Yossef
Turn the global sysctls allowing disabling of TCP SACK, DSCAK, time stamp and window scale into per route entry feature options, laying the ground to future removal of the relevant global sysctls.
...
Interesting... But you should give numbers to your patches so that we know their order
Will do.
Quoted 3 lines
You could also do the ECN part for consistency (ie
RTAX_FEATURE_ECN->RTAX_FEATURE_NO_ECN)
Quoted 6 lines
That and
sysctl_tcp_mtu_probingare on my todo list, assuming the general direction is accepted, of course.Specifically, I couldn't understand why
sysctl_tcp_ecnis documented to be a boolean value, but is initialized to 2 and queried with if (sysctl_tcp_ecn==
1) so I decided to let it be until I figure it out... ;-)
Ah, I didn't notice that "- BOOLEAN" there so I modified only the description (some blindness to caps perhaps :-)), did you perhaps read it fully?
Signature · 1 line
i.
Hi Ilpo,
Quoted 10 lines · Ilpo Järvinen
Quoted 5 lines
Specifically, I couldn't understand why
sysctl_tcp_ecnis documented to be a boolean value, but is initialized to 2 and queried with if (sysctl_tcp_ecn==
1) so I decided to let it be until I figure it out... ;-)Ah, I didn't notice that "- BOOLEAN" there so I modified only the description (some blindness to caps perhaps :-)), did you perhaps read it fully?
Yes, I did finally. What threw me off was that that TCP_ECN_create_request() were the value if checked as a boolean was inlined in the include file. I've missed that. Thanks for the tip.
At any rate, it means that "noecn" is not a good route option feature, since it is not boolean. I plan to handle those in the next patch set, if the current one is accepted.
Thanks,
Gilad
Signature · 15 lines
Gilad Ben-Yossef Chief Coffee Drinker & CTO Codefidence Ltd. Web: http://codefidence.com Cell: +972-52-8260388 Skype: gilad_codefidence Tel: +972-8-9316883 ext. 201 Fax: +972-8-9316884 Email: [email protected] Check out our Open Source technology and training blog - http://tuxology.net "Sorry cannot parse this, its too long to be true :)" -- Eric Dumazet on netdev mailing list
Quoted 8 lines · Gilad Ben-Yossef
Turn the global sysctls allowing disabling of TCP SACK, DSCAK, time stamp and window scale into per route entry feature options, laying the ground to future removal of the relevant global sysctls.
You really only want to disable SACK, DSACK, time stamp or window
scale if you've got a piece of broken networking equipment somewhere as a stop gap until you can bring a big enough hammer to deal with the broken network equipment. It doesn't make sense to "punish" the
entire connections going through the machine to destinations not related to the broken equipment.
Is it really only the case that those options get disabled for broken networking equipment? Does this presage making all TCP options per-route only?
rick jones
Quoted 11 lines · Rick Jones
Quoted 8 lines · Gilad Ben-Yossef
Turn the global sysctls allowing disabling of TCP SACK, DSCAK, time stamp and window scale into per route entry feature options, laying the ground to future removal of the relevant global sysctls.
You really only want to disable SACK, DSACK, time stamp or window
scale if you've got a piece of broken networking equipment somewhere as a stop gap until you can bring a big enough hammer to deal with the broken network equipment. It doesn't make sense to "punish" the
entire connections going through the machine to destinations not related to the broken equipment.Is it really only the case that those options get disabled for broken networking equipment? Does this presage making all TCP options per-route only?
Well, I assume it might be the case that there are situations where you are trying to communicate over some exotic link where the networking equipment is not broken as such, but the unusual properties of the link makes one of the features not desirable. I can't think of such a situation right now off the top of my head, but maybe they exist.
The point is that even then you are more then likely to wish to turn off these options to specific destination and routes (that go over said exotic link) and keep using them over others - e.g. timestamp OK for local LAN, but for default route that goes over exotic TCP/IP over carrier penguins turn it off.
To sum it up, I think making these options per route is a win no matter the situation. The question I am less certain about if it is also desirable to have a global kill switch in addition to the per route options. My gut feeling is that this is not needed once you have a per route option.
Cheers,
Gilad
Signature · 15 lines
Gilad Ben-Yossef Chief Coffee Drinker & CTO Codefidence Ltd. Web: http://codefidence.com Cell: +972-52-8260388 Skype: gilad_codefidence Tel: +972-8-9316883 ext. 201 Fax: +972-8-9316884 Email: [email protected] Check out our Open Source technology and training blog - http://tuxology.net "Sorry cannot parse this, its too long to be true :)" -- Eric Dumazet on netdev mailing list
Quoted 5 lines · Gilad Ben-Yossef
The point is that even then you are more then likely to wish to turn off these options to specific destination and routes (that go over said exotic link) and keep using them over others - e.g. timestamp OK for local LAN, but for default route that goes over exotic TCP/IP over carrier penguins turn it off.
If you need a bandaid solution, its is possible to replace tcp options with NOOPs using netfilters TCPOPTSTRIP target.
There is also an ECN target to work around ECN blackholes.
Hi Florian,
Quoted 9 lines · Florian Westphal
Quoted 6 lines · Gilad Ben-Yossef
The point is that even then you are more then likely to wish to turn off these options to specific destination and routes (that go over said exotic link) and keep using them over others - e.g. timestamp OK for local LAN, but for default route that goes over exotic TCP/IP over carrier penguins turn it off.
Quoted 5 lines
If you need a bandaid solution, its is possible to replace tcp options with NOOPs using netfilters TCPOPTSTRIP target.
There is also an ECN target to work around ECN blackholes.
Thanks for the tip. It is appreciated.
The band aid solution that Ori and company found was
simply to patch the local copy of the kernel used but being that sitting on a bunch of "private" patches seems like a lose-lose situation (there is a term you don't hear much when talking to MBAs :-) I'm now trying to get it mainlined for them.
Thanks,
Gilad
Signature · 15 lines
Gilad Ben-Yossef Chief Coffee Drinker & CTO Codefidence Ltd. Web: http://codefidence.com Cell: +972-52-8260388 Skype: gilad_codefidence Tel: +972-8-9316883 ext. 201 Fax: +972-8-9316884 Email: [email protected] Check out our Open Source technology and training blog - http://tuxology.net "Sorry cannot parse this, its too long to be true :)" -- Eric Dumazet on netdev mailing list
David Miller
maintainerWhen sending more than one patch in a patch set, you must number your patches so that people know in what order your pathes should be applied.
Mailing lists and other entities reorder list postings quite severely, so it's not "obvious" what order your postings matter just based upon arrival order.
Quoted 9 lines · David Miller
When sending more than one patch in a patch set, you must number your patches so that people know in what order your pathes should be applied.
Mailing lists and other entities reorder list postings quite severely, so it's not "obvious" what order your postings matter just based upon arrival order.
Yes, of course. How silly of me not to notice. My apologies.
git and I are currently have a bit of love hate thing going on...
I will re-send the patch set in a more favorable form.
Thanks,
Gilad
Signature · 15 lines
Gilad Ben-Yossef Chief Coffee Drinker & CTO Codefidence Ltd. Web: http://codefidence.com Cell: +972-52-8260388 Skype: gilad_codefidence Tel: +972-8-9316883 ext. 201 Fax: +972-8-9316884 Email: [email protected] Check out our Open Source technology and training blog - http://tuxology.net "Sorry cannot parse this, its too long to be true :)" -- Eric Dumazet on netdev mailing list
Quoted 10 lines · Gilad Ben-Yossef
Turn the global sysctls allowing disabling of TCP SACK, DSCAK, time stamp and window scale into per route entry feature options, laying the ground to future removal of the relevant global sysctls.
You really only want to disable SACK, DSACK, time stamp or window scale if you've got a piece of broken networking equipment somewhere as a stop gap until you can bring a big enough hammer to deal with the broken network equipment. It doesn't make sense to "punish" the entire connections going through the machine to destinations not related to the broken equipment.
For certain test situations, it is sometimes desirable to globally disable TCP timestamps. Although I have not personally wanted to globally disable the other mentioned features, I can imagine test scenarios where it could be useful. Admittedly it could also be accomplished with per route features, just not as conveniently, especially if there are a large number of interfaces and/or routes.
-Bill
Hi,
Quoted 13 lines · Bill Fink
Quoted 9 lines · Gilad Ben-Yossef
Turn the global sysctls allowing disabling of TCP SACK, DSCAK, time stamp and window scale into per route entry feature options, laying the ground to future removal of the relevant global sysctls.
You really only want to disable SACK, DSACK, time stamp or window
scale if you've got a piece of broken networking equipment somewhere as a stop gap until you can bring a big enough hammer to deal with the broken network equipment. It doesn't make sense to "punish" the
entire connections going through the machine to destinations not related to the broken equipment.
Quoted 8 lines
For certain test situations, it is sometimes desirable to globally disable TCP timestamps. Although I have not personally wanted to globally disable the other mentioned features, I can imagine test scenarios where it could be useful. Admittedly it could also be accomplished with per route features, just not as conveniently, especially if there are a large number of interfaces and/or routes.
I don't feel that strongly about it either way, just trying to hearken to Linus "Linux is bloated" message by not fostering duplicate ways to do the same thing... ;-)
If the consensus is to adopt the route features but leave the global kill switches, I certainly have no problem with that.
Thanks,
Gilad
Signature · 15 lines
Gilad Ben-Yossef Chief Coffee Drinker & CTO Codefidence Ltd. Web: http://codefidence.com Cell: +972-52-8260388 Skype: gilad_codefidence Tel: +972-8-9316883 ext. 201 Fax: +972-8-9316884 Email: [email protected] Check out our Open Source technology and training blog - http://tuxology.net "Sorry cannot parse this, its too long to be true :)" -- Eric Dumazet on netdev mailing list