Skip to contentSkip to conversation

oprofile/loongson2: rename cpu_type from godson2 to loongson2

PATCH In review Wu Zhangjin 3 participants 3 messages Oct 21, 2009 – Nov 2, 2009 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 oprofile/loongson2: rename cpu_type from godson2 to loongson2

This patch try to unify the naming method between kernel and the user-space oprofile tool. 'Cause loongson is used instead of godson in most of the places, and just confer with the developer of the user-space tool, we are agreed to use loongson instead, which will help a lot to the future maintaining.

(This patch is very important to help the user-space support upstream,
so, Ralf, could you please merge it into your -queue branch, thanks!)

---
 arch/mips/oprofile/op_model_loongson2.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/mips/oprofile/op_model_loongson2.c +1 -1
index 9536b21..08d4b09 100644
@@ -22,7 +22,7 @@
  * otherwise, the oprofile tool will not recognize this and complain about
  * "cpu_type 'unset' is not valid".
  */
-#define LOONGSON2_CPU_TYPE	"mips/godson2"
+#define LOONGSON2_CPU_TYPE	"mips/loongson2"
 
 #define LOONGSON2_COUNTER1_EVENT(event)	((event & 0x0f) << 5)
 #define LOONGSON2_COUNTER2_EVENT(event)	((event & 0x0f) << 9)
Signature · 1 line
1.6.2.1
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Wu Zhangjin

This patch try to unify the naming method between kernel and the user-space oprofile tool. 'Cause loongson is used instead of godson in most of the places, and just confer with the developer of the user-space tool, we are agreed to use loongson instead, which will help a lot to the future maintaining.

(This patch is very important to help the user-space support upstream,
so, Ralf, could you please merge it into your -queue branch, thanks!)

Ralf, please apply to your tree.

Thanks.

-Robert

Signature · 3 lines
Advanced Micro Devices, Inc.
Operating System Research Center
email: [email protected]
#2 lore raw
Quoted 9 lines · Robert Richter
Quoted 8 lines · Wu Zhangjin

This patch try to unify the naming method between kernel and the user-space oprofile tool. 'Cause loongson is used instead of godson in most of the places, and just confer with the developer of the user-space tool, we are agreed to use loongson instead, which will help a lot to the future maintaining.

(This patch is very important to help the user-space support upstream,
so, Ralf, could you please merge it into your -queue branch, thanks!)

Applied to master, not queue. The name is part of an API, so cosmetic changes like this are to be avoided. Fortunately the oprofile code in question is still fairly new, hasn't been art of any stable kernel release yet so it better go into the kernel now than later.

Quoted 5 lines
Quoted 1 line

Ralf, please apply to your tree.

Ralf