Driver-Core: devtmpfs - ignore umask while setting file mode
From: Kay Sievers <[email protected]>
Subject: Driver-Core: devtmpfs - ignore umask while setting file mode
--- drivers/base/devtmpfs.c | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-)
drivers/base/devtmpfs.c +14 -10
@@ -156,34 +156,38 @@ int devtmpfs_create_node(struct device * mode |=S_IFCHR ; curr_cred =override_creds (&init_cred); + err =vfs_path_lookup (dev_mnt->mnt_root, dev_mnt, nodename,LOOKUP_PARENT , &nd);if (err == -ENOENT ) { -/* create missing parent directories */ create_path (nodename); err =vfs_path_lookup (dev_mnt->mnt_root, dev_mnt, nodename,LOOKUP_PARENT , &nd); -if (err) - goto out; } +if (err) + goto out; dentry =lookup_create (&nd,0 );if (!IS_ERR (dentry)) { -int umask; - - umask =sys_umask (0000 ); err =vfs_mknod (nd.path.dentry->d_inode, dentry, mode, dev->devt); -sys_umask (umask); -/* mark as kernel created inode */ -if (!err) +if (!err) { +struct iattr newattrs; + +/* fixup possibly umasked mode */ + newattrs.ia_mode = mode; + newattrs.ia_valid =ATTR_MODE ; +notify_change (dentry, &newattrs); + +/* mark as kernel-created inode */ dentry->d_inode->i_private = &dev_mnt; + }dput (dentry); }else { err =PTR_ERR (dentry); } -mutex_unlock (&nd.path.dentry->d_inode->i_mutex); +mutex_unlock (&nd.path.dentry->d_inode->i_mutex);path_put (&nd.path); out:kfree (tmp);
[email protected]
Appliedpatch driver-core-devtmpfs-ignore-umask-while-setting-file-mode.patch added to gregkh-2.6 tree
This is a note to let you know that I've just added the patch titled
Subject: Driver Core: devtmpfs: ignore umask while setting file mode
to my gregkh-2.6 tree. Its filename is
driver-core-devtmpfs-ignore-umask-while-setting-file-mode.patch
This tree can be found at
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/
Quoted 1 line
From [email protected] Thu Oct 29 11:59:08 2009
From: Kay Sievers <[email protected]>
Date: Wed, 28 Oct 2009 19:50:57 +0100
Subject: Driver Core: devtmpfs: ignore umask while setting file mode
To: Greg KH <[email protected]>
Cc: linux-kernel <[email protected]>
Message-ID: <[email protected]>
From: Kay Sievers <[email protected]>
--- drivers/base/devtmpfs.c | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-)
drivers/base/devtmpfs.c +14 -10
@@ -156,34 +156,38 @@ int devtmpfs_create_node(struct device * mode |=S_IFCHR ; curr_cred =override_creds (&init_cred); + err =vfs_path_lookup (dev_mnt->mnt_root, dev_mnt, nodename,LOOKUP_PARENT , &nd);if (err == -ENOENT ) { -/* create missing parent directories */ create_path (nodename); err =vfs_path_lookup (dev_mnt->mnt_root, dev_mnt, nodename,LOOKUP_PARENT , &nd); -if (err) - goto out; } +if (err) + goto out; dentry =lookup_create (&nd,0 );if (!IS_ERR (dentry)) { -int umask; - - umask =sys_umask (0000 ); err =vfs_mknod (nd.path.dentry->d_inode, dentry, mode, dev->devt); -sys_umask (umask); -/* mark as kernel created inode */ -if (!err) +if (!err) { +struct iattr newattrs; + +/* fixup possibly umasked mode */ + newattrs.ia_mode = mode; + newattrs.ia_valid =ATTR_MODE ; +notify_change (dentry, &newattrs); + +/* mark as kernel-created inode */ dentry->d_inode->i_private = &dev_mnt; + }dput (dentry); }else { err =PTR_ERR (dentry); } -mutex_unlock (&nd.path.dentry->d_inode->i_mutex); +mutex_unlock (&nd.path.dentry->d_inode->i_mutex);path_put (&nd.path); out:kfree (tmp);