omap3: Change the default silicon
Subsystems (3)
PATCH 1/1 omap3: Change the default silicon
Currently the default silicon - in absence of identification - is set to OMAP3630 ES1.0.
Though, condition may/should not arise; but the default should be latest in the most common silicon variant - currently OMAP3430 ES3.1.
--- arch/arm/mach-omap2/id.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-omap2/id.c +2 -2
@@ -243,8 +243,8 @@ void __init omap3_check_revision(void) }break ;default : -/* Unknown default to latest silicon rev as default*/ - omap_revision =OMAP3630_REV_ES1_0 ; +/* Unknown. Default to latest among all variants */ + omap_revision =OMAP3430_REV_ES3_1 ; } }
Signature · 1 line
1.6.2.2
Tony Lindgren
maintainerQuoted 7 lines · Sanjeev Premi
Currently the default silicon - in absence of
identification - is set to OMAP3630 ES1.0.Though, condition may/should not arise; but
the default should be latest in the most
common silicon variant - currently OMAP3430
ES3.1.
Is this still needed? To me it seems more likely there will more 3630 based silicon than 3430 based silicon?
Regards,
Tony
Quoted 27 lines
Signed-off-by Sanjeev Premi <[email protected]>--- arch/arm/mach-omap2/id.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)arch/arm/mach-omap2/id.c +2
-2@@ -243,8 +243,8 @@ void __init omap3_check_revision(void) }break ;default : -/* Unknown default to latest silicon rev as default*/ - omap_revision =OMAP3630_REV_ES1_0 ; +/* Unknown. Default to latest among all variants */ + omap_revision =OMAP3430_REV_ES3_1 ; } }Signature · 6 lines
1.6.2.2 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 4 lines · Tony Lindgren
Quoted 3 lines · Sanjeev Premi
Currently the default silicon - in absence of identification - is set to OMAP3630 ES1.0.
Quoted 8 lines
Quoted 4 lines
Though, condition may/should not arise; but the default should be latest in the most common silicon variant - currently OMAP3430 ES3.1.
Is this still needed? To me it seems more likely there will more 3630 based silicon than 3430 based silicon?
3430 ES3.1s are the most common I believe. All boards in the wild are 3430 based.
3630 is just coming up and will take a while to be as common.
IMO, 3430 ES3.1 should be default.
- Anand
Quoted 24 lines
Regards,
Tony
Quoted 20 lines
Signed-off-by Sanjeev Premi <[email protected]>--- arch/arm/mach-omap2/id.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)arch/arm/mach-omap2/id.c +2
-2@@ -243,8 +243,8 @@ void __init omap3_check_revision(void) }break ;default : -/* Unknown default to latest silicon rev as default*/ - omap_revision =OMAP3630_REV_ES1_0 ; +/* Unknown. Default to latest among all variants */ + omap_revision =OMAP3430_REV_ES3_1 ; } }
Quoted 21 lines
-----Original Message-----
From: Gadiyar, Anand
Sent: Friday, November 13, 2009 10:41 AM
To: Tony Lindgren; Premi, Sanjeev
Cc: [email protected]
Subject: RE: [PATCH] omap3: Change the default siliconQuoted 4 lines · Tony Lindgren
Quoted 3 lines · Sanjeev Premi
Currently the default silicon - in absence of identification - is set to OMAP3630 ES1.0.
Quoted 8 lines
Quoted 4 lines
Though, condition may/should not arise; but the default should be latest in the most common silicon variant - currently OMAP3430 ES3.1.
Is this still needed? To me it seems more likely there will more 3630 based silicon than 3430 based silicon?
Quoted 8 lines
3430 ES3.1s are the most common I believe. All boards in the wild are 3430 based.
3630 is just coming up and will take a while to be as common.
IMO, 3430 ES3.1 should be default.
- Anand
[sp] That's exactly the reason for this patch.
There is a small typo in the comment though :(
/* Unknown. Default to latest among all variants */
Should be:
/* Unknown. Default to common among all variants */
Sending a v2 for the same.~sanjeev
Quoted 27 lines
Quoted 26 lines
Regards,
Tony
Quoted 20 lines
Signed-off-by Sanjeev Premi <[email protected]>--- arch/arm/mach-omap2/id.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)arch/arm/mach-omap2/id.c +2
-2@@ -243,8 +243,8 @@ void __init omap3_check_revision(void) }break ;default : -/* Unknown default to latest silicon rev as default*/ - omap_revision =OMAP3630_REV_ES1_0 ; +/* Unknown. Default to latest among all variants */ + omap_revision =OMAP3430_REV_ES3_1 ; } }
Premi, Sanjeev had written, on 11/13/2009 04:10 AM, the following:
Quoted 27 lines
Quoted 18 lines
-----Original Message-----
From: Gadiyar, Anand Sent: Friday, November 13, 2009 10:41 AM
To: Tony Lindgren; Premi, Sanjeev
Cc: [email protected]
Subject: RE: [PATCH] omap3: Change the default siliconQuoted 11 lines · Tony Lindgren
Quoted 7 lines · Sanjeev Premi
Currently the default silicon - in absence of identification - is set to OMAP3630 ES1.0.
Though, condition may/should not arise; but the default should be latest in the most common silicon variant - currently OMAP3430 ES3.1.
Is this still needed? To me it seems more likely there will more 3630 based silicon than 3430 based silicon?
Quoted 8 lines
3430 ES3.1s are the most common I believe. All boards in the wild are 3430 based.
3630 is just coming up and will take a while to be as common.
IMO, 3430 ES3.1 should be default.
- Anand
Quoted 9 lines
[sp] That's exactly the reason for this patch.
There is a small typo in the comment though :( /* Unknown. Default to latest among all variants */ Should be: /* Unknown. Default to common among all variants */ Sending a v2 for the same.
I believe this patch should be dropped -> here is why -> if you have new silicons that are in 3430 category, you should be sending patches for them ;)..
The latest and greatest in the bucket of silicons is 3630 and I would rather go with felipe's patch [1] cleaning up the id.c than this -> in my opinion, hitting this condition is only because you have the next generation of devices..
Signature · 5 lines
Regards, Nishanth Menon Ref: [1]: http://patchwork.kernel.org/patch/59540/
Quoted 43 lines
-----Original Message-----
From: Menon, Nishanth
Sent: Friday, November 13, 2009 3:46 PM
To: Premi, Sanjeev
Cc: Gadiyar, Anand; Tony Lindgren; [email protected]
Subject: Re: [PATCH] omap3: Change the default siliconPremi, Sanjeev had written, on 11/13/2009 04:10 AM, the following:
Quoted 35 lines
Quoted 19 lines
-----Original Message-----
From: Gadiyar, Anand
Sent: Friday, November 13, 2009 10:41 AM
To: Tony Lindgren; Premi, Sanjeev
Cc: [email protected]
Subject: RE: [PATCH] omap3: Change the default siliconQuoted 11 lines · Tony Lindgren
Quoted 7 lines · Sanjeev Premi
Currently the default silicon - in absence of identification - is set to OMAP3630 ES1.0.
Though, condition may/should not arise; but the default should be latest in the most common silicon variant - currently OMAP3430 ES3.1.
Is this still needed? To me it seems more likely there will more 3630 based silicon than 3430 based silicon?
Quoted 8 lines
3430 ES3.1s are the most common I believe. All boards in the wild are 3430 based.
3630 is just coming up and will take a while to be as common.
IMO, 3430 ES3.1 should be default.
- Anand
[sp] That's exactly the reason for this patch.
There is a small typo in the comment though :( /* Unknown. Default to latest among all variants */ Should be: /* Unknown. Default to common among all variants */
Quoted 7 lines
Quoted 2 lines
Sending a v2 for the same.
I believe this patch should be dropped -> here is why -> if you have new
silicons that are in 3430 category, you should be sending patches for them ;)..
Default != new si
Quoted 3 lines
The latest and greatest in the bucket of silicons is 3630 and I would rather go with felipe's patch [1] cleaning up the
id.cthan
No issues with felipe's patch. It is cleaning the code style.
Quoted 3 lines
this -> in
my opinion, hitting this condition is only because you have the next generation of devices..
Since we are talking OMAP3 derivatives, the default should be the base - in case the condition ever arises. The fall back should usually be 'most common' than 'latest'.
~sanjeev
Quoted 9 lines
Signature · 6 lines
-- Regards, Nishanth Menon Ref: [1]: http://patchwork.kernel.org/patch/59540/
Premi, Sanjeev had written, on 11/13/2009 04:53 AM, the following:
Quoted 40 lines
Quoted 40 lines
-----Original Message-----
From: Menon, Nishanth Sent: Friday, November 13, 2009 3:46 PM
To: Premi, Sanjeev
Cc: Gadiyar, Anand; Tony Lindgren; [email protected]
Subject: Re: [PATCH] omap3: Change the default siliconPremi, Sanjeev had written, on 11/13/2009 04:10 AM, the following:
Quoted 33 lines
Quoted 18 lines
-----Original Message-----
From: Gadiyar, Anand Sent: Friday, November 13, 2009 10:41 AM
To: Tony Lindgren; Premi, Sanjeev
Cc: [email protected]
Subject: RE: [PATCH] omap3: Change the default siliconQuoted 11 lines · Tony Lindgren
Quoted 7 lines · Sanjeev Premi
Currently the default silicon - in absence of identification - is set to OMAP3630 ES1.0.
Though, condition may/should not arise; but the default should be latest in the most common silicon variant - currently OMAP3430 ES3.1.
Is this still needed? To me it seems more likely there will more 3630 based silicon than 3430 based silicon?
Quoted 8 lines
3430 ES3.1s are the most common I believe. All boards in the wild are 3430 based.
3630 is just coming up and will take a while to be as common.
IMO, 3430 ES3.1 should be default.
- Anand
[sp] That's exactly the reason for this patch.
There is a small typo in the comment though :( /* Unknown. Default to latest among all variants */ Should be: /* Unknown. Default to common among all variants */
Quoted 5 lines
Quoted 3 lines
Quoted 2 lines
Sending a v2 for the same.
I believe this patch should be dropped -> here is why -> if you have new silicons that are in 3430 category, you should be sending patches for them ;)..
Default != new si
IMHO, I would rather have it as a BUG() instead of giving something default there.. essentially hitting that case points at: "hey here is a chip the programmers did not think about, let me be smart and try to dream up what they might be using" - lets face it, our code aint' that smart.. we have two options:
a) Make a guess what it might be
b) force the programmer to fix the bug and send us the patch ;)..
just my 2 cents..
Quoted 19 lines
Quoted 2 lines
The latest and greatest in the bucket of silicons is 3630 and I would rather go with felipe's patch [1] cleaning up the
id.cthanNo issues with felipe's patch. It is cleaning the code style.
Quoted 1 line
this -> in my opinion, hitting this condition is only because you have the next generation of devices..
Since we are talking OMAP3 derivatives, the default should be the base - in case the condition ever arises. The fall back should usually be 'most common' than 'latest'.
~sanjeev
Quoted 7 lines
Signature · 6 lines
-- Regards, Nishanth Menon Ref: [1]: http://patchwork.kernel.org/patch/59540/
Signature · 2 lines
Regards, Nishanth Menon